Commit Graph

45645 Commits

Author SHA1 Message Date
227963047a Fix hash validity check function returning incorrect results after soft deleting a beatmap
The soft-deleted one would potentially match before the newly imported
copy, resulting in a false-positive hash mismatch.
2021-11-01 15:15:45 +09:00
123b10f647 Fix playlist item download button being clickable when it shouldn't 2021-11-01 15:10:32 +09:00
21e0074d3b Add missing AddInternal call for BeatmapSetHeaderContent's download tracker 2021-11-01 14:43:32 +09:00
19feae4a8e Merge branch 'master' into beatmap-refactor/download-tracker 2021-11-01 13:15:36 +09:00
74d408149d Merge pull request #15377 from bdach/song-select-beatmap-details-stars
Fix star rating not updating for some mods on details tab in song select
2021-11-01 11:21:59 +09:00
914e5c0f9d Fix star rating not updating for some mods on details tab in song select
`AdvancedStats` was locally assuming that the only changes in mods that
are relevant to it are if the mods are `IApplicableToDifficulty`. This
is not true, as other mods (such as `IApplicableToRate` mods, or more
recently, Flashlight) can also affect star difficulty, which is shown on
one of the bars in `AdvancedStats`.
2021-10-31 18:58:17 +01:00
53afed19ec Merge pull request #15371 from Opelkuh/add-hw-accel-setting
Add setting for hardware video acceleration
2021-10-30 15:46:32 +02:00
9e05e7af74 Merge branch 'master' into add-hw-accel-setting 2021-10-30 15:19:01 +02:00
7de16ff799 Merge pull request #15350 from peppy/long-online-id-score-info
Allow for `long` online IDs and implement in `ScoreInfo`
2021-10-30 15:02:31 +02:00
b0c4fa662d Merge branch 'master' into long-online-id-score-info 2021-10-30 14:35:30 +02:00
f6c19c9538 Merge pull request #15360 from peppy/beatmap-refactor/difficulty-icons
Update `DifficultyIcon` classes to use `IBeatmapInfo`
2021-10-30 21:32:46 +09:00
6e4f7af8d3 Mark IHasOnlineID implementation with region 2021-10-30 14:15:20 +02:00
5a8dff0e4e Merge branch 'master' into beatmap-refactor/difficulty-icons 2021-10-30 14:06:15 +02:00
e9473db77c Reorder to have video settings next to renderer
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2021-10-30 20:37:55 +09:00
4d988340eb Add hardware acceleration toggle 2021-10-30 01:02:53 +02:00
f8aa4c2851 Merge pull request #15352 from bdach/text-flow-parts
Update text flow usages to use `ITextPart`
2021-10-29 22:32:46 +09:00
1fd05ab78a Update framework 2021-10-29 18:56:13 +09:00
04acc7601c Fix one more missed case 2021-10-29 18:35:15 +09:00
07e3ced315 Fix test scene and remove "impossible" nullable coalesce 2021-10-29 18:22:23 +09:00
7db8bdfb7c Fix fallback logic not considering case where ruleset is not available
Occurs only in tests.
2021-10-29 18:16:54 +09:00
159a7af556 Merge branch 'master' into beatmap-refactor/difficulty-icons 2021-10-29 18:03:17 +09:00
32f89791c9 Merge pull request #15357 from peppy/beatmap-refactor/beatmap-difficulty-cache
Refactor `BeatmapDifficultyCache` to work with `IBeatmapInfo`
2021-10-29 17:31:14 +09:00
be0564f732 Update DifficultyIcon classes to use IBeatmapInfo 2021-10-29 17:05:06 +09:00
3598adb344 Fix test implementing old version of class 2021-10-29 17:04:56 +09:00
7583435901 Refactor BeatmapDifficultyCache to work with IBeatmapInfo 2021-10-29 16:45:10 +09:00
61f0339c1d Avoid double-adding chunks in link flow container 2021-10-29 06:34:08 +02:00
6f863ca204 Adjust game-side text flow containers to part-based model 2021-10-29 06:34:08 +02:00
414d920ca2 Revert to previous exposure of RoomSubScreen.BeatmapAvailability 2021-10-29 12:02:10 +09:00
b252b176d4 Seal implementation and add comment about LoadComplete execution order 2021-10-29 11:59:07 +09:00
f3811edb0b Add inline comment explaining usage of RequiresChildrenUpdate override 2021-10-29 11:57:54 +09:00
dc44734db2 Simplify null check in ScoreDownloadTracker and remove unnecessary ID check 2021-10-29 11:56:17 +09:00
75a088d4f4 Fix variable name mismatch 2021-10-29 11:54:42 +09:00
748003b016 Simplify Manager null check to a single pre-check 2021-10-29 11:54:19 +09:00
3b095e1626 Merge branch 'master' into beatmap-refactor/download-tracker 2021-10-29 11:50:54 +09:00
34d4715220 Allow for long online IDs and implement in ScoreInfo 2021-10-29 11:48:36 +09:00
fe86ae51b0 Merge pull request #15349 from peppy/remap-mania-scroll-speed-adjust
Change scroll speed adjust defaults to F3/F4
2021-10-29 11:42:44 +09:00
3838fe5c6a Fix typo in variable name 2021-10-29 11:39:15 +09:00
8d21f0b04b Add migration to reset conflicting scroll speed key bindings 2021-10-29 11:14:22 +09:00
ce29d6fd81 Change scroll speed adjust defaults to F3/F4
Not the most obvious keys, but does match stable expectations so let's
go with it for now.

Rationale for not using +/- is that local audio offset was bound to
those, and people will expect it to be when we get to implementing
eventually.

Also, adjust the scroll speed is a pretty rare thing to do since it's
been constant across beatmaps for years now.
2021-10-29 11:13:07 +09:00
7ab68525b4 Merge pull request #15031 from Joehuu/ui-scaling-keybind
Add ability to change ui scaling via keyboard
2021-10-29 01:48:08 +09:00
9199f2b337 Merge branch 'master' into ui-scaling-keybind 2021-10-28 18:20:34 +02:00
d14421723a Merge pull request #15341 from peppy/always-unique-test-online-ids
Ensure all test beatmaps have unique OnlineIDs to avoid import conflicts
2021-10-29 00:21:19 +09:00
c96b07c625 Remove unnecessary/wrong code 2021-10-28 18:24:04 +09:00
2b3e63470d Merge branch 'master' into always-unique-test-online-ids 2021-10-28 18:23:45 +09:00
6e79a0947a Merge pull request #15340 from peppy/add-number-setting-source-test
Add visual test for `SettingsNumberBox` usage in settings source context
2021-10-28 18:19:45 +09:00
d8d4839e43 Merge pull request #15339 from smoogipoo/fix-test-crash
Fix playlists room creation test crash
2021-10-28 17:28:46 +09:00
4f4f2503aa Merge pull request #15335 from smoogipoo/cleanup-multiplayer-screen-tests
Clean up multiplayer-screen tests by removing intermediate screen
2021-10-28 17:28:26 +09:00
c0848486d6 Add missing test coverage for attempt count display 2021-10-28 17:27:16 +09:00
8076e22e70 Replace weird import handling 2021-10-28 17:27:16 +09:00
b21f42ec76 Merge branch 'master' into add-number-setting-source-test 2021-10-28 17:25:52 +09:00