054938be02
Merge pull request #22387 from peppy/beatmap-leaderboard-cancel-request-eagerly
...
Fix beatmap leaderboard potentially showing incorrect leaderboard
2023-01-24 19:49:11 +01:00
b9291cb116
Change some order and assert for positive visibility before scheduling an operation in changelog overlay
2023-01-24 17:59:25 +09:00
c6bf755e68
Remove IsPresent override from ChangelogOverlay
2023-01-24 00:22:29 -08:00
df895c4fd6
Always make settings footer build display clickable
2023-01-24 00:21:39 -08:00
a966d6c330
Merge pull request #18402 from ggliv/mod-accuracy-challenge
...
Add accuracy challenge mod
2023-01-24 16:00:55 +09:00
b46ef67a14
increase min minimum accuracy to 60%
2023-01-24 00:31:46 -05:00
bb15ee50e0
Fix beatmap leaderboard potentially showing incorrect leaderboard
2023-01-24 13:52:59 +09:00
7483967157
Merge branch 'master' into SliderEnd-Snap
2023-01-23 21:33:16 +01:00
1f40b2daf6
Clean up xmldocs
2023-01-23 21:22:18 +01:00
9f2ed853eb
Merge pull request #22371 from peppy/more-settings-keywords
...
Add more keywords to settings based on feedback
2023-01-23 20:19:53 +01:00
432e0a6a37
Merge branch 'master' into level-badge-colour
2023-01-23 15:46:15 +09:00
9c2494383f
Rename fetch method to be non-plural to match all others
2023-01-23 15:43:52 +09:00
e3932c077b
Merge pull request #22032 from frenzibyte/fix-potential-difficulty-failure-alt
...
Fix advanced statistics display potentially performing invalid difficulty calculation
2023-01-23 15:39:47 +09:00
7ebd31d42f
Add more keywords to settings based on feedback
2023-01-23 15:14:16 +09:00
2ed9fe3747
Add support for externally specified keywords in SettingsButtons
2023-01-23 15:10:26 +09:00
73f083a316
Refactor how additional points are provided to avoid confusion
2023-01-23 14:13:46 +09:00
f87bb589a2
Merge pull request #22340 from EXtremeExploit/groups-modes
...
Add modes text to groups tooltip
2023-01-23 01:10:25 +09:00
e1acf85bb3
Merge branch 'master' into groups-modes
2023-01-22 10:09:34 +01:00
9bde1ef9bf
Privatise setter
2023-01-22 10:09:08 +01:00
b98da506c1
Fix code quality inspection
2023-01-22 10:07:47 +01:00
31e7d7333b
Merge branch 'master' into fix-fail-sample-playing-after-leaving-dialog
2023-01-22 09:35:37 +01:00
06aa3f7798
Rename Stop{SampleAndRemoveFilters -> }()
...
Now that just one method for stopping samples is left, let's just
repurpose st as the general "stop global effects" method rather than
have it there with a hyperspecific name. It also has good symmetry, as
there already was a `Start()` method in the class.
2023-01-22 09:29:22 +01:00
9e4e85e3e3
Inline StopSample() into StopSampleAndRemoveFilters()
...
The first method no longer has any callers except for the second one.
2023-01-22 09:26:01 +01:00
0edfd24410
Remove unnecessary sample stop in Restart()
...
It is unnecessary, as a successful restart will exit the current player
screen, and `OnExiting()` has another `StopSampleAndRemoveFilters()`
call, which means that in the restart flow the sample was actually
getting stopped twice.
Standard exit flow is fine, it only stopped the sample once.
2023-01-22 09:24:12 +01:00
88d58e8476
Merge pull request #22337 from Joehuu/fix-comment-editor-sounds
...
Fix comment editor text boxes not having sound feedback
2023-01-22 09:10:20 +01:00
b66279c5d7
Merge pull request #22341 from peppy/screen-scaling-keywords
...
Add search keywords for screen scaling sub-settings
2023-01-22 08:56:14 +01:00
db0b69db6b
Merge branch 'master' into fix-fail-sample-playing-after-leaving-dialog
2023-01-22 02:12:07 -03:00
7040743249
Add search keywords for screen scaling sub-settings
2023-01-22 13:47:31 +09:00
5b1a23c697
Replace RemoveFilters call with StopSampleAndRemoveFilters
2023-01-22 01:44:16 -03:00
2e1ba6ef49
Create StopSampleAndRemoveFilters method and change RemoveFilters to private
2023-01-22 01:43:40 -03:00
2f3971b6fb
Move code to already existing if block
2023-01-22 01:40:00 -03:00
8c208da324
Cleanup
2023-01-22 01:39:01 -03:00
05f77d2cab
Add modes text to groups tooltip
2023-01-22 01:36:53 -03:00
a746cbc6ed
Fix failSample still playing after player left FailOverlay
2023-01-22 01:14:33 -03:00
da03abc812
Fix comment editor text boxes not having sound feedback
2023-01-21 17:32:42 -08:00
718cbf9382
Fix SegmentedGraph draw node calculating segment colours in unsafe manner
...
The `SegmentedGraph`'s draw node would call `getSegmentColour()`
on the drawable, which would query the `DrawColourInfo` and
`tierColours` properties of the drawable. This is a cross-thread access
and as such completely unsafe, as due to being cross-thread it can die
on invalidations or out-of-bounds accesses.
Fix by transferring everything to the draw node first before attempting
to draw. `SegmentedGraph.TierColours` setter already correctly
invalidates the draw node via `graphNeedsUpdate`, so no further
intervention was required there.
Closes #22326 .
2023-01-21 23:19:34 +01:00
c48af79588
Fix test browsers on longer working after framework update
2023-01-21 14:49:47 +03:00
19450bfe12
Update framework
2023-01-20 23:23:25 +09:00
2ce32e3209
Refactor update logic to be easier to follow
2023-01-19 19:27:05 +09:00
b22363ed8c
Fix JudgementCounterDisplay.cs max judgement always showing upon changing display mode
2023-01-19 10:31:02 +01:00
4916a742d5
Immediately focus the textbox when clicking to reply to a comment
2023-01-19 16:08:27 +09:00
81e6c3792c
Remove unused method
2023-01-19 16:03:46 +09:00
56ce8504ae
Merge branch 'master' into comment-reply
2023-01-19 16:01:47 +09:00
07af18b8a7
Remove ReplyCommentEditor into its own class
2023-01-19 16:01:37 +09:00
db8084570d
Merge pull request #22285 from bdach/segmented-graph-tint
...
Apply draw colour to segmented graph
2023-01-19 13:36:19 +09:00
e58abf7d1a
Merge pull request #22284 from bdach/judgement-counter-broken
...
Fix "show max judgement" setting not applying initially on judgement counter display
2023-01-19 09:09:06 +09:00
a0fe71c706
Use alternative segment colour computation method
2023-01-19 00:08:32 +01:00
b62ff8d644
Merge branch 'master' into skin/argon-song-progress-cleaner
2023-01-18 23:52:12 +01:00
b8b7442eb8
Make SongProgressInfo.ShowProgress init-only (and remove duplicate init)
2023-01-18 23:35:40 +01:00
903c37bf32
Apply draw colour to segmented graph segments
2023-01-18 23:17:57 +01:00
