25bf4e68ec
remove useless wait
2023-05-03 22:53:13 +09:00
b932e4d986
Rename DrawableUsername
to DrawableChatUsername
and only pass message ID
2023-05-03 18:53:22 +09:00
4f55afb60d
Merge branch 'master' into chat-report
2023-05-03 18:50:38 +09:00
384693a431
Fix test failure in MultiplayerMatchSongSelect
due to multiple overlays present
...
https://github.com/ppy/osu/actions/runs/4868337922/jobs/8681736995?pr=23308 .
2023-05-03 14:30:58 +09:00
6b017ac05f
Merge pull request #23308 from OliBomby/sample-control-points
...
Remove SampleControlPoint and DifficultyControlPoint from HitObject
2023-05-03 14:21:51 +09:00
e42b0cc5b1
Merge pull request #23370 from peppy/fix-editor-playfield-padding
...
Add more padding around playfield in editor to avoid overlap with tool areas
2023-05-03 11:44:55 +09:00
95badb9455
Adjust composer tests to new screen layout
...
`TestSceneHitObjectComposer.TestPlacementFailsWhenClickingButton()` was
attempting to cover the case of the user clicking a toolbox button which
was in front of the playfield, and ensure that the click did not result
in a placement. However, since the paddings in
67f83f246b
were added, it is impossible
for a toolbox button to be in front of the playfield in the collapsed
state, which the test was relying on.
The test scenario is still however relevant in the case of the toolbox
being expanded, as in that state the toolbux buttons may very well end
up being in front of the playfield, and they still should not result in
a hitobject being placed. To ensure that this is the case, add a few
extra test steps ensuring that the toolbox is expanded first before
trying to retrieve an overlapping button.
2023-05-02 18:45:45 +02:00
94ae9d7664
Merge pull request #23357 from OliBomby/fix-reverse-crash
...
Prevent infinite repeat count when adjusting repeats of 0 length slider
2023-05-02 19:53:26 +09:00
1e4a628cb1
Merge pull request #23284 from Hy0tic/multiplier-doesnt-update-with-preset-mod
...
Fix issue where multiplier show wrong value when adjusting speed on preset
2023-05-02 14:59:41 +09:00
e3c384c6b5
Merge branch 'master' into sample-control-points
2023-05-02 14:38:39 +09:00
983a8f7dfe
Merge branch 'master' into fix-reverse-crash
2023-05-02 13:14:34 +09:00
87db891143
Adjust test to reliabily fail
2023-05-02 13:12:11 +09:00
1fb4c814f4
Remove no longer needed API call mocking
...
The online ID will be reset unconditionally after any local change is
made to any beatmap. That behaviour no longer depends on online lookups
succeeding or failing.
This may change at a later date when beatmap submission is integrated
into lazer - the idea is that online IDs would get re-populated on local
beatmaps once they are submitted to web.
2023-05-01 19:08:41 +02:00
8ab3a87b13
Add failing test case covering online ID reset on save
...
This test scene passes at e58e1151f3
and
fails at current master, due to an inadvertent regression caused by
e72f103c17
.
As it turns out, the online lookup flow that was causing UI thread
freezes when saving beatmaps in the editor, was also responsible for
resetting the online ID of locally-modified beatmaps if online lookup
failed.
2023-05-01 18:17:35 +02:00
dbb2a8980b
add test
2023-05-01 15:56:23 +02:00
608fa3cc73
Merge remote-tracking branch 'upstream/master' into sample-control-points
2023-04-30 19:47:03 +02:00
7cedbca9be
Merge branch 'master' into multiplier-doesnt-update-with-preset-mod
2023-04-30 17:36:00 +02:00
d35355970f
Add test case covering failure scenario
2023-04-30 17:23:45 +02:00
2643100644
Add xmldoc to new test mentioning failure rate and general purpose
2023-04-29 11:05:10 +09:00
32f8c674f4
Extract beatmap retrieval method for more legibility
2023-04-29 11:01:29 +09:00
a6f0186112
Improve legibility and code quality of new test
2023-04-29 10:51:56 +09:00
428b5fad3c
Rename test scene to explicitly mention navigation testing
2023-04-29 10:51:56 +09:00
d9b3c97179
Fix testing
2023-04-29 10:29:33 +09:00
c5357d30ab
Add test
2023-04-29 10:29:33 +09:00
07efa7d660
Merge branch 'master' into fix-storyboard-loop-end-time
2023-04-26 21:53:26 +02:00
354cd23874
removed all usage of hitobject's DifficultyControlPoint
2023-04-26 18:17:02 +02:00
c44f71a737
remove all regular usage of DifficultyControlPoint
2023-04-26 17:55:38 +02:00
9f8d7bccba
fix usings
2023-04-26 17:34:02 +02:00
c6fc180659
remove all test usages of SampleControlPoint
2023-04-26 14:21:52 +02:00
196b5b41eb
Also disable counting on argon display in test
...
Mostly for my own peace of mind.
2023-04-25 20:17:57 +02:00
753fa09356
Fix test failures due to type mismatch
2023-04-25 20:10:11 +02:00
0c3a015953
Fix key counter test not testing the full binding of IsCounting
2023-04-25 21:37:19 +09:00
d8b4db3a13
Merge branch 'master' into gameplay/argon-key-counter_le-retour
2023-04-25 19:54:31 +09:00
e330052852
Add second definition of EndTime
for storyboard elements to account for loops in lifetime
2023-04-25 15:22:11 +09:00
26a2d1fdea
Merge pull request #23000 from Joehuu/fix-beatmap-terminology
...
Fix song select matching label not using right terminology
2023-04-18 13:53:05 +09:00
c80a25328d
Shorten label to just "matches"
2023-04-17 20:59:41 -07:00
0cc92ce5f9
Add failing test case
...
Covering nested object reverts not firing the parent's `RevertResult`
event in accordance with what the xmldoc of the event states.
2023-04-11 18:24:34 +02:00
d0cbe206a9
Revert back to one number with "matching beatmap difficulties" label
2023-04-10 23:37:29 -07:00
52bb7891f7
Merge branch 'master' into fix-count-not-updating-when-deleting
2023-04-11 09:04:02 +09:00
1f2c96c8e8
Merge branch 'master' into gd-onlinesetoverlay
2023-04-10 15:35:03 +02:00
6e08105e2c
Remove usage of "diff" vernacular
2023-04-10 15:27:10 +02:00
bfb7ead689
Add failing text box beatmap difficulty count test
2023-04-09 22:12:50 -07:00
ed208ef127
Fix more typos and adjust font size to match web
2023-04-07 21:10:37 -07:00
0c71fa1bbd
Merge branch 'master' into gameplay/argon-key-counter_le-retour
2023-04-06 23:39:57 +09:00
e6872629f3
Merge pull request #22868 from peppy/no-epilepsy-warning-storyboard-disable
...
Don't show epilepsy warning when storyboards are disabled
2023-04-06 12:32:38 +09:00
809b817e8e
Merge branch 'master' into gameplay/argon-key-counter_le-retour
2023-04-05 22:57:36 +02:00
ba753a8aac
Merge branch 'master' into update-skinnable-sound-before-playing
2023-04-05 22:56:25 +02:00
6df7614b9d
Add tests for suppressing epilepsy warning when storyboard disabled
2023-04-05 20:56:50 +02:00
02c6126be7
Ensure storyboards are enabled in existing epilepsy warning tests
2023-04-05 20:53:54 +02:00
432f698697
Merge branch 'master' into gameplay/key-counter-abstraction
2023-04-05 19:45:14 +02:00