Commit Graph

39882 Commits

Author SHA1 Message Date
a0c6c4da35 Rename and refactor token request process to be easier to understand 2021-03-24 13:17:29 +09:00
7b395ed783 Add exterior arc test 2021-03-24 05:15:50 +01:00
23a4d1c135 Shorten recovery test name 2021-03-24 05:15:28 +01:00
6fbe530016 Fix coordinates 2021-03-24 05:14:35 +01:00
847d44c7d9 Remove unnecessary length asserts
We don't actually care about the length (as this isn't what we're testing), just the type of the slider.
2021-03-24 05:13:37 +01:00
e372e355ef Reorder overrides in SoloPlayer to better follow chronological request order 2021-03-24 13:12:51 +09:00
7bae4ff43d Add control point dragging tests 2021-03-24 05:06:04 +01:00
8bed7748d6 Rename token request method to avoid double Request terminology 2021-03-24 13:02:37 +09:00
a1c35677ef Add more xmldoc 2021-03-24 13:02:17 +09:00
4ae3eaaac6 Move path type correction
This is better because `PathControlPointVisualizer` is local to the editor, meaning there is no chance that this could affect gameplay.
2021-03-24 03:02:19 +01:00
0bcd38e661 Simplify path type maintenance when dragging 2021-03-24 02:57:47 +01:00
5ee280f941 Update PointsInSegment when adding/removing points
There was a bug where if you created a slider, moved the last point, and then added a point such that it became a PerfectCurve, it would fail to recover after becoming a Bezier.

This fixes that.
2021-03-24 02:56:32 +01:00
c8542d2434 Merge branch 'master' into default-fullscreen 2021-03-23 19:44:22 -05:00
437dadc85f Changed comment on GetFrameworkConfigDefaults() to be more accurate 2021-03-23 19:37:55 -05:00
67a03ebc23 Fixed formatting issues to be in line with osu coding standards 2021-03-23 19:31:16 -05:00
fbb992fc7e Added a comment to new method 2021-03-23 19:18:32 -05:00
d17c431faf Disable relative mode for TournamentGame 2021-03-23 23:22:17 +01:00
217f6083ca Merge branch 'master' into solo-score-submission 2021-03-23 21:12:52 +09:00
bb6e50eb27 Merge pull request #12151 from peppy/fail-dummy-api-requests
Fail all API requests sent to DummyAPIAccess
2021-03-23 20:54:04 +09:00
578128f803 Merge branch 'master' into fail-dummy-api-requests 2021-03-23 20:14:56 +09:00
ade542191a Merge pull request #12154 from peppy/fix-hitcircle-glow-fade-out
Fix default skin's glow resetting fade on miss
2021-03-23 20:14:51 +09:00
5f956971cc Merge pull request #12153 from peppy/fix-appproach-circle-fade-out
Always fade out approach circles at a HitObject's start time to better match stable
2021-03-23 20:04:38 +09:00
d10ff615fe Fix default skin's glow resetting fade on miss 2021-03-23 19:28:08 +09:00
64e85ba995 Always fade out approach circles at a HitObject's start time to better match stable 2021-03-23 19:19:07 +09:00
e649a330a4 Implement SoloPlayer's request construction 2021-03-23 18:23:25 +09:00
242b847516 Add flow for allowing gameplay to continue even when an error occurs with token retrieval 2021-03-23 18:23:25 +09:00
3cd8bf2d7f Move token request construction to LoadAsyncComplete to better allow DI usage 2021-03-23 18:20:55 +09:00
571124669d Remove all references to "score submission" from Player 2021-03-23 18:20:55 +09:00
194b2d05d3 Update SoloPlayer to derive SubmittingPlayer 2021-03-23 18:20:55 +09:00
12f050264a Further split out a player class which submits to "rooms" 2021-03-23 18:20:55 +09:00
7045fce555 Move score submission logic in general out to its own Player type 2021-03-23 18:20:55 +09:00
6cb14e91c9 Make Player abstract and introduce SoloPlayer 2021-03-23 18:18:49 +09:00
5267fb74c4 Add submission requests 2021-03-23 18:18:49 +09:00
aeff9bd853 Add return bool to HandleRequest to better trigger failures 2021-03-23 18:17:29 +09:00
ce452565f4 Avoid firing any kind of failures after success 2021-03-23 17:50:31 +09:00
9e38d580ca Merge pull request #12139 from peppy/fix-editor-spinner-looping-too-long
Fix spinners playing looping sound too long in the editor
2021-03-23 17:44:07 +09:00
f5ba746ae5 Fail all API requests sent to DummyAPIAccess
Until now, API requests sent to dummy API were just lost in the void. In most cases this somehow worked as expected, but any logic which is waiting on a request to finish will potentially never get a response.

Going forward, I'm not 100% sure that every `Wait` on a web response will have local timeout logic (I think there is a certain amount of assumption that this is being managed for us by `APIAccess`), so I've made this change to better handle such cases going forward. Now, rather than nothing happening, requests will trigger a failure via the existing exception logic rather than silently pretending the request never arrived.
2021-03-23 17:37:45 +09:00
3594c42b79 Merge pull request #12141 from smoogipoo/perfect-curve-failure-testcase 2021-03-23 17:23:00 +09:00
3ec3624ac5 Merge branch 'master' into fix-editor-spinner-looping-too-long 2021-03-23 16:45:41 +09:00
f6ed3c1b1e Merge branch 'master' into perfect-curve-failure-testcase 2021-03-23 16:44:58 +09:00
17a28f4f65 Merge pull request #12136 from peppy/remove-skin-sample-workarounds
Remove local workarounds to attempt to avoid crashes on skin change
2021-03-23 16:44:29 +09:00
08fcdc8ee4 Update difficulty calculator tests with floating point differences 2021-03-23 15:38:01 +09:00
d758343a45 Merge pull request #12149 from peppy/fix-score-token-data-type
Fix APIScoreToken's data type not matching server side
2021-03-23 14:54:02 +09:00
1171214541 Update framework 2021-03-23 14:51:22 +09:00
a5842a5485 Merge branch 'master' into remove-skin-sample-workarounds 2021-03-23 14:51:14 +09:00
5f2c6b8d59 Merge pull request #12145 from bdach/mania-auto-hold-note-release
Remove release delay for hold notes when generating autoplay
2021-03-23 14:24:56 +09:00
254b0f5dc3 removed line (?) - tried doing testing to see if it launched in fullscreen (i.e., overriding the method ppy mentioned), but to no avail :( 2021-03-23 00:24:33 -05:00
9c690f9545 Fix second usage 2021-03-23 14:08:00 +09:00
58c60100b4 Fix APIScoreToken's data type not matching server side 2021-03-23 14:04:47 +09:00
d9e2c44a34 implemented GetFrameworkConfigDefaults for overriding framework default, removed previous code that added a new OsuSetting and modified settings layout. 2021-03-22 23:36:55 -05:00