ab9603b06a
Merge remote-tracking branch 'upstream/master' into #7146
2020-01-09 17:08:12 +08:00
f0fe3bc804
Pass bindable to BeatmapMetadataDisplay
...
It was reported that mods selected in song select would show up during
loading of replays which were recorded under a different set of mods.
This was caused by BeatmapMetadataDisplay accepting a plain read-only
value of the Mods bindable in PlayerLoader.load(), therefore making the
mod value assignment in ReplayPlayerLoader.OnEntering() have no effect
on that component.
To resolve this issue, make BeatmapMetadataDisplay accept the
higher-level bindable, bind to it locally and pass it down the hierarchy
to ModDisplay.
2020-01-08 20:10:43 +01:00
a3f7d3c445
Add failing test
...
Add test case demonstrating the lack of update of the metadata display's
mods upon setting the Mods property in PlayerLoader.
2020-01-08 19:55:35 +01:00
d33a507d96
Implement a login placeholder ( #7438 )
...
Implement a login placeholder
2020-01-08 16:55:41 +08:00
6dd45e52ef
Move text definition inside class
2020-01-08 17:22:51 +09:00
48502eba7f
Merge branch 'master' into difficulty-tooltip-unused-var
2020-01-08 14:40:40 +09:00
e0cfc2f405
Merge branch 'master' into prev-button-revamp
2020-01-07 21:49:53 +01:00
7f92cefe10
Apply review suggestions
2020-01-07 19:06:47 +01:00
0fb27ef153
Merge remote-tracking branch 'upstream/master' into difficulty-tooltip-unused-var
2020-01-07 17:59:10 +07:00
e33de0c2e4
Fix ScrollContainer crashes
2020-01-07 15:14:09 +08:00
be19bb8a27
Merge remote-tracking branch 'upstream/master' into set_user_agent_on_web_request_level
2020-01-07 15:01:09 +08:00
fadd53106c
Merge remote-tracking branch 'upstream/master' into medals-fix
2020-01-07 13:39:42 +09:00
fd925526e2
Fix medal overlay display
2020-01-07 13:39:30 +09:00
b3a7b02e3b
Merge remote-tracking branch 'upstream/master' into fix-cancelling-request-not-correct
2020-01-07 11:43:01 +09:00
cb43020118
Merge remote-tracking branch 'upstream/master' into triangles-color
2020-01-07 10:00:10 +09:00
0b9cc8ed1b
Revert "Move colour generation to TriangleParticle"
...
This reverts commit de4c62788c
.
2020-01-07 09:58:37 +09:00
031bed15da
Fix comments async loading wasn't really async
2020-01-06 20:56:32 +03:00
de4c62788c
Move colour generation to TriangleParticle
2020-01-06 12:51:38 +01:00
e433e8b78f
Remove unused variable
2020-01-06 17:12:10 +07:00
28510674ac
Shorten body text
2020-01-06 17:48:29 +09:00
61c269b17b
Leaderboard should not change the model
2020-01-06 17:32:24 +09:00
4a7f5f98df
Cleanup methods/events
2020-01-06 17:20:09 +09:00
d188d33f18
Fix osu!direct global action not being bound to a key
2020-01-05 18:59:06 -08:00
d1f3cb3dbd
Premature checks to avoid unnecessary updates
2020-01-06 01:53:29 +01:00
f70f25098b
Change visible triangles colour when dark or light colour is changed
2020-01-06 00:32:13 +01:00
21e6351c53
Allow DI for LoginOverlay to resolve to null in non-graphical environments (fix tests)
2020-01-05 14:33:44 +01:00
3d747835dc
Fix CI issues
2020-01-04 21:09:40 +01:00
5fd5665467
Use implementation on song select leaderboards.
2020-01-04 19:59:25 +01:00
474b8fc8fd
Add LoginPlaceholder
2020-01-04 19:56:42 +01:00
3bd3ebad49
Move placeholders to a dedicated namespace
2020-01-04 19:56:34 +01:00
9fb29cc7a7
Move medal loading to LoadComplete
2020-01-04 18:45:34 +03:00
0a9d14826c
Merge remote-tracking branch 'refs/remotes/ppy/master' into medals-fix
2020-01-04 18:28:17 +03:00
a756d5d95d
Fix new account registration attempting to login with email
2020-01-04 14:52:07 +09:00
e23c71be80
Update Resolved and Cached attribute issues
2020-01-03 11:34:26 -08:00
0a4e180ce7
Merge branch 'master' of github.com:ppy/osu into #7146
2020-01-03 11:32:06 -08:00
d4888c39de
cleanup
2020-01-03 15:22:33 +00:00
23ed64c5fd
Merge branch 'rpc' of https://github.com/aspriddell/osu into rpc
2020-01-03 13:08:06 +00:00
71a3db7cd6
remove from rulesetinfo
2020-01-03 13:08:01 +00:00
b500ee44fb
Update osu.Game/Rulesets/Ruleset.cs
...
Co-Authored-By: Salman Ahmed <email@iisalman.me >
2020-01-03 13:00:57 +00:00
5940851519
remove database dependency
2020-01-03 12:17:01 +00:00
3a903339d6
add playingverb and database migrations
2020-01-03 11:39:15 +00:00
c07cfce3b3
Merge branch 'master' into resource-assembly
2020-01-03 17:56:25 +09:00
e9b57de76f
Update framework
2020-01-03 17:23:17 +09:00
78e9ab912d
Merge remote-tracking branch 'upstream/master' into set_user_agent_on_web_request_level
2020-01-03 17:23:11 +09:00
7d79edf335
Merge remote-tracking branch 'upstream/master' into overlay-headers-update-three
2020-01-03 15:35:33 +09:00
fe581bf27e
Remove unnecessarily exposed value
2020-01-03 15:35:18 +09:00
e8567414c6
Refactor into some kind of sanity
2020-01-03 15:01:42 +09:00
b54491cc82
Make sure an exception is thrown
2020-01-03 14:16:38 +09:00
132b420aaa
Fix changelog overlay hard crashing on no internet connection
2020-01-02 19:19:42 +09:00
a5c23e7cf7
Remove underline from breadcrumb display
2020-01-02 11:09:47 +03:00