Commit Graph

94 Commits

Author SHA1 Message Date
7f30140b7e Add new method handling hit state specifically
Until now UpdateStateTransforms was applying results offsets to
StartTime. This didn't cover the case of a HitObject with duration,
where the call would be made with `StartTime + hitOffset` rather than
`EndTime + hitOffset`.

To resolve this, a new method has been added which should be used to
handle hit-specific state transforms.
2020-11-04 16:13:14 +09:00
601675db07 Adjust health increase values to match old ones better 2020-10-03 12:16:22 +02:00
309714081f Make new health increase values mania-specific 2020-10-03 12:16:22 +02:00
1ec96e1bb1 Merge branch 'master' into adjust-hp-increases 2020-10-01 16:58:29 +09:00
3a26bd8d9b Adjust obsoletion + xmldoc of NumericResultFor() 2020-10-01 12:14:16 +09:00
806d8b4b1d Make scoring int-based again 2020-10-01 12:13:24 +09:00
cc9fa4675c Adjust HP increases 2020-09-29 17:59:42 +09:00
a1394c1830 Fix a few missed judgements 2020-09-29 16:33:38 +09:00
519f376e7b Standardise Judgement across all rulesets 2020-09-29 16:33:38 +09:00
a210deee9a Remove unnecessary depth setter 2020-07-28 12:16:01 +09:00
5fc7039bf2 Prevent DrawableJudgement from removing other children 2020-07-27 19:07:21 +02:00
8a3cadc111 Fix judgement animations not resetting on use 2020-07-13 21:21:59 +09:00
f872343bab Make Apply virtual to further simplify application process 2020-07-10 18:35:20 +09:00
8aff828dfe Move application of judgements to Apply method 2020-07-10 18:34:31 +09:00
51050ec4ef Add per-result type pooling 2020-07-06 12:54:39 +09:00
ffec4298a7 Use DrawablePool for DrawableJudgements 2020-07-04 16:45:50 +09:00
5f09c70f75 Move judgement colours to OsuColour 2020-03-18 17:21:36 +09:00
fab49fb1ba Slightly increase HP awarded for 100s 2020-02-26 12:18:46 +09:00
ffc7eaa3f2 Fix hitobjects with unknown lifetimes by enforcing non-null judgement
We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
CreateJudgement() must be implemented and return a non-null judgement.

This fixes BananaShower and JuiceStreams in osu!catch.

This also makes HitObject abstract and cleans up convert HitObject implementations.
2020-02-23 13:49:06 +09:00
c753cb46c5 Use [Resolved] wherever possible 2020-02-14 20:14:00 +07:00
3b07c3913d Add perfect and ok values, move to base Judgement 2019-12-26 15:00:59 +09:00
0640b2eb35 Fix judgement sizes not matching legacy skins (#6145)
Fix judgement sizes not matching legacy skins
2019-09-19 18:49:35 +09:00
e6c36a8bc7 Fix scaling mode being applied to judgements 2019-09-19 17:36:32 +09:00
26eca5b1f4 Fix judgement sizes not matching skins stable 2019-09-18 02:56:03 +09:00
ba76f09c99 Add initial implementation of hit lighting
Requires a supporting skin, like osu!classic for now.
2019-09-18 02:49:54 +09:00
6ce36bd39e Merge branch 'master' into stop-counting-to-score-after-fail 2019-09-06 16:12:53 +09:00
05ed9d3802 Merge remote-tracking branch 'upstream/master' into non-timeoffset-judgements 2019-09-03 13:07:58 +09:00
0c73c5acf3 Expose full hitobject rather than hit windows 2019-09-02 17:14:40 +09:00
f2bdf94a1d Add HitWindows to JudgementResult to indicate timing errors 2019-09-02 16:28:14 +09:00
70e417533f Update naming 2019-08-30 15:13:29 +09:00
a15828ab25 Introduce the concept of SkinComponents
Removes reliance on string lookups and better defines elements for introduction into database
2019-08-30 14:55:52 +09:00
88fa06efba Refactor as proposed 2019-08-09 13:38:04 +09:00
74c961bcff Add more flexible skin element confine modes 2019-07-22 14:42:56 +09:00
d7c09e7dbd Merge remote-tracking branch 'origin/master' into fix-new-inspections
# Conflicts:
#	osu.Game.Rulesets.Catch/Judgements/CatchDropletJudgement.cs
#	osu.Game.Rulesets.Catch/Judgements/CatchJudgement.cs
#	osu.Game.Rulesets.Mania/Scoring/ManiaScoreProcessor.cs
#	osu.Game.Rulesets.Osu/Replays/OsuAutoGenerator.cs
#	osu.Game.Rulesets.Osu/UI/Cursor/CursorTrail.cs
#	osu.Game.Tests/Visual/SongSelect/TestCaseBeatmapScoresContainer.cs
#	osu.Game/Graphics/OsuFont.cs
#	osu.Game/Online/API/Requests/Responses/APILegacyScoreInfo.cs
#	osu.Game/Overlays/Profile/Header/BadgeContainer.cs
#	osu.Game/Overlays/Profile/ProfileHeader.cs
#	osu.Game/Screens/Select/PlaySongSelect.cs
#	osu.Game/Skinning/LegacySkinDecoder.cs
2019-05-07 13:20:17 +09:00
4edb17a88a Make hp work + cleanup 2019-04-22 18:02:49 +09:00
fbb4e9df04 Implement hp at base ScoreProcessor 2019-04-22 16:51:38 +09:00
c39c37a18d Apply more missed cases 2019-04-01 12:44:46 +09:00
3d4a80957f Improve comment 2019-03-13 18:27:54 +09:00
7eb253b687 Fix incorrect scale duration 2019-03-12 19:44:53 +09:00
3b3b1e51ee Move hit animation logic into virtual method 2019-03-12 19:41:33 +09:00
9850122245 Fix incorrect delay 2019-03-12 19:24:46 +09:00
12f334035f Create properties for use in DrawableManiaJudgement 2019-03-12 19:23:24 +09:00
d61dfe888e Fix venera fonts not being correctly specified 2019-02-22 19:42:09 +09:00
3015d40f8f Merge branch 'master' into osu-fontusage 2019-02-22 18:09:23 +09:00
f919f2252f Add ToString for Judgements to ease debugging 2019-02-22 12:02:54 +09:00
a2aa3ec5cb Adjust sprite texts in-line with framework changes 2019-02-20 15:03:20 +09:00
8617aaa2a7 Update licence header (and remove year) 2019-01-24 17:43:03 +09:00
1b6658f4ee Move HealthIncreaseFor to Judgement 2018-12-06 15:09:42 +07:00
f27bd3ef3e OpenTK -> osuTK 2018-11-20 17:14:59 +09:00
87d8945af9 Give the body a size 2018-10-02 09:33:31 +09:00