Commit Graph

4342 Commits

Author SHA1 Message Date
7394c62cc8 Make ModTimeRamp and ModRateAdjust incompatible 2021-02-23 18:10:03 +00:00
a6e840634b Adjust scrubbing behaviour to allow dragging through rate values 2021-02-23 15:52:53 +00:00
f45cedeb85 Adjust initial and final rate ranges and prevent them from overlapping 2021-02-23 15:38:09 +00:00
ec4b770cba Remove unused using statement 2021-02-23 14:56:03 +09:00
672fd3f9d2 When disable mouse buttons during gameplay is selected, disable more globally
Until now the disable setting would only apply to left/right buttons,
and only in gameplay. This change will cause any global actions bound to
mouse buttons to also not work during gameplay.

Closes #11879.
2021-02-23 14:37:46 +09:00
ee6a94273d Merge branch 'master' into fix-unsafe-skinnable-sample-play 2021-02-22 18:31:27 +09:00
63dd55c92c Add missing methods from updated audio component interface implementation 2021-02-22 14:18:52 +09:00
66643a97b0 Add a list of mods to Skill class
Although this isn't necessary for existing official rulesets and calculators, custom calculators can have use cases for accessing mods in difficulty calculation.
For example, accounting for the effects of visual mods.
2021-02-20 20:37:44 +11:00
442347df8e Fix clockrate adjusted difficulty calculations bug in strain decay
When starting a new section, the starting strain value was calculated using the unadjusted timing value, meaning decay curves were essentially being stretched or squashed according to the clockrate.

This caused incorrect strain peaks for any section where the peak occurs at the start of the section (none of the objects in the section added enough strain after decay to exceed the starting strain).

This bug caused star ratings with clockrates above 1 to be lower than they should and below 1 to be higher than they should.
2021-02-20 20:23:49 +11:00
487a39eea9 Update interface implementations with framework changes 2021-02-18 18:52:34 +09:00
143e145670 Update implementation of AdjustableAudioComponents 2021-02-18 15:44:23 +09:00
d3f0c0730d Merge branch 'master' into non-concurrent-sample-playback 2021-02-12 17:22:15 +09:00
cb4d119f23 Merge pull request #11740 from peppy/editor-fix-slider-samples-new-placement
Fix newly placed sliders in the editor not playing hitsounds
2021-02-12 13:31:00 +09:00
f84ea30637 Expose Mods in DrawableRuleset to avoid using external DI 2021-02-11 17:47:29 +09:00
aaa0362b12 Merge branch 'master' into autoplay-rate-independence 2021-02-11 17:39:45 +09:00
e9730d4782 Move default sample addition to inside PlacementBlueprint
This isn't actually required to fix the behaviour but it does feel like
a better place to put this logic.
2021-02-11 17:16:18 +09:00
be9b07a4cf Merge branch 'master' into difficulty-adjustment-extension 2021-02-10 20:42:08 +09:00
4e3bb27cd5 Merge branch 'master' into fix-mod-settings-fuckery 2021-02-09 16:47:39 +09:00
1cb51fa8d2 Merge branch 'master' into autoplay-rate-independence 2021-02-09 16:05:34 +09:00
8204d360a8 Always reset local user settings when a mod is deselected in ModSelectOverlay 2021-02-09 13:44:42 +09:00
be379e0e3c Change CopyFrom to always overwrite all settings with incoming values 2021-02-09 13:44:11 +09:00
f4a31287bf Add/use IHitObjectContainer interface instead of IEnumerables 2021-02-08 20:11:06 +09:00
0229851c9c Apply rounding to ModTimeRamp to improve SPM consistency 2021-02-07 19:02:09 +01:00
7daeacaff2 Add and implement IApplicableToRate interface 2021-02-07 18:35:34 +01:00
68c20a2a37 Allow autoplay score generation to access mod list 2021-02-07 18:35:34 +01:00
06a3a72e43 Merge pull request #11670 from smoogipoo/mania-constant-speed-mod
Implement mania constant speed mod
2021-02-05 00:26:04 +09:00
8295fb9081 Implement mania constant speed mod 2021-02-03 16:28:22 +09:00
921f008217 Fix ModIcon not updating background colour correctly 2021-02-02 21:35:08 +09:00
a0de1cbfd0 Handle no-duration single-object edge case 2021-01-31 21:09:41 +01:00
547b3d8bed Fix speed change calculation in time ramp mods 2021-01-31 20:34:56 +01:00
81b052b866 Add failing test cases 2021-01-31 20:34:22 +01:00
2c08ce05fa Remove game-local enum [Order] attribute
In favour of the newly-added framework one.
2021-01-27 22:29:52 +01:00
7d06af916c Merge branch 'master' into add-messagepack 2021-01-27 13:00:46 +09:00
a5f3418e56 Avoid tooltip display 2021-01-26 19:11:19 +09:00
9537090d28 Setup all spectator model classes for MessagePack 2021-01-26 16:39:35 +09:00
dee0d3c33a Merge branch 'master' into apply-sv-to-taiko-hr-ez 2021-01-25 14:28:06 +09:00
04095cd5b9 Merge branch 'master' into fix-editor-scroll-interruption 2021-01-21 17:46:18 +09:00
1d9aaac2c2 Fix HOC not propagating DHO results applied on kill
`DrawableHitObject.OnKilled()` calls `UpdateResult()` to clean up a
hitobject's state definitively with regards to the judgement result
before returning the DHO back to the pool.

As it turns out, if a consumer was relying on this code path (as taiko
was in the case of nested strong hit objects), it would not work
properly with pooling, due to `HitObjectContainer` unsubscribing from
`On{New,Revert}Result` *before* calling the DHO's `OnKilled()`.

This in turn would lead to users potentially getting stuck in gameplay,
due to `ScoreProcessor` not receiving all results via that event path.

To resolve, change the call ordering to allow hit result changes applied
in `OnKilled()` to propagate normally.
2021-01-21 00:05:37 +01:00
de9d075f94 Initial sample + samplechannel rework 2021-01-19 17:11:40 +09:00
ced7a36788 Update namespaces 2021-01-18 21:24:10 +09:00
04fa32bc34 Rename and add xmldoc for smooth seeking method 2021-01-15 16:14:21 +09:00
d5878db615 Fix default judgement text mispositioned for one frame 2021-01-14 12:33:33 +09:00
4b4adc927c Rename param to match method body 2021-01-10 15:35:53 +01:00
0aad0c7c6c Target logic at this and adjust variables 2021-01-09 00:31:18 +03:00
375ecf92ed Merge remote-tracking branch 'upstream/master' into fix-mod-buttons-not-copying-settings 2021-01-09 00:26:18 +03:00
05ba5d4c31 Merge pull request #11438 from bdach/difficulty-adjust-defaults
Fix difficulty adjust mod treating default values as user overrides
2021-01-09 01:18:34 +09:00
303cc62ee7 Transfer flags indicating if settings were changed 2021-01-06 22:46:46 +01:00
68352782db Change .StartsWith() to .Equals()
In line with planned-but-delayed breaking change.
2021-01-06 18:38:24 +01:00
9cc63e8dce Remove obsoleted IHasEndTime 2021-01-06 18:38:24 +01:00
539785e422 Remove obsoleted IHasCurve 2021-01-06 18:38:24 +01:00