Commit Graph

117 Commits

Author SHA1 Message Date
7b2f58eb30 Apply OnRelease method signature refactorings 2020-01-22 13:22:34 +09:00
193e41f878 Add origin adjustment for hitobject lifetime
Visual inspection of taiko gameplay has shown that hitobjects appeared
on screen only when the origin of the hitobject came into the bounds
of the screen, instead of appearing when any visible part of the
hitobject came into the screen bounds.

This behaviour was due to lifetime calculation being based on the origin
of the hitobject and not taking into account the actual object
dimensions. Adjust the lifetime start of the hitobject by subtracting
the time needed to show the part of the hitobject that should already
be visible on screen when the origin comes into frame.
2019-12-26 20:37:29 +01:00
5861eca80d Make DrawableRuleset take a converted beatmap 2019-12-12 15:58:11 +09:00
c0fe91a84c Merge branch 'master' into sharpen 2019-11-26 18:21:50 +08:00
709ec1404f Centralise End/StartTime retrieval to extension method 2019-11-25 19:09:14 +09:00
818553027b Merge branch 'master' into sharpen 2019-11-21 23:42:46 +08:00
6cab517b2d .NET Standard 2.1 implements Math.Clamp , use it instead of MathHelper.Clamp from osuTK. 2019-11-20 13:37:47 +01:00
374ef6ff83 Merge branch 'master' into sharpen 2019-11-20 17:30:58 +08:00
b1b234c6fb Use paramref. 2019-11-17 20:49:36 +08:00
e5e8e70704 Use pattern matching. 2019-11-12 19:55:19 +08:00
0171b2ae7c Fix scrolling hitobjects expiring too soon 2019-11-01 12:10:03 +09:00
244627ff10 Add comment + test for slider multiplier 2019-09-25 20:12:01 +09:00
4abe0473b9 Fix relative beat length not considering slider multiplier 2019-09-24 16:49:42 +09:00
af0c15a93c Fix initial hitobject states not being recomputed correctly 2019-09-24 16:48:39 +09:00
d74e1b9b64 Remove from dictionary on Remove() 2019-09-02 15:06:43 +09:00
8f8d35bd15 Delay initial hitobject state computation 2019-09-02 15:06:34 +09:00
6ab2b20c70 Add an interface for working beatmaps 2019-08-29 19:38:44 +09:00
f6ad95018a Centralise default beat length specification 2019-08-28 20:22:16 +09:00
6aab7168d4 Merge branch 'master' into relative-beat-lengths 2019-08-27 10:59:52 +09:00
0422c19c2f Group lifetime setters together 2019-08-26 19:06:23 +09:00
fb1cd9e5e7 Add a sane default lifetime end for scrolling hitobjects 2019-08-26 16:47:23 +09:00
1cfe2b7de8 Fix timing points beyond the end time potentially becoming dominant 2019-08-26 16:31:34 +09:00
d99c60adc7 Provide a way to scale beat lengths relative to each other 2019-08-26 12:51:13 +09:00
90b1fe81f3 Update cached usage in line with framework changes 2019-08-09 19:12:29 +09:00
d7c09e7dbd Merge remote-tracking branch 'origin/master' into fix-new-inspections
# Conflicts:
#	osu.Game.Rulesets.Catch/Judgements/CatchDropletJudgement.cs
#	osu.Game.Rulesets.Catch/Judgements/CatchJudgement.cs
#	osu.Game.Rulesets.Mania/Scoring/ManiaScoreProcessor.cs
#	osu.Game.Rulesets.Osu/Replays/OsuAutoGenerator.cs
#	osu.Game.Rulesets.Osu/UI/Cursor/CursorTrail.cs
#	osu.Game.Tests/Visual/SongSelect/TestCaseBeatmapScoresContainer.cs
#	osu.Game/Graphics/OsuFont.cs
#	osu.Game/Online/API/Requests/Responses/APILegacyScoreInfo.cs
#	osu.Game/Overlays/Profile/Header/BadgeContainer.cs
#	osu.Game/Overlays/Profile/ProfileHeader.cs
#	osu.Game/Screens/Select/PlaySongSelect.cs
#	osu.Game/Skinning/LegacySkinDecoder.cs
2019-05-07 13:20:17 +09:00
0bd35ab7bb Turn on warnings, resolve issues 2019-04-25 17:36:17 +09:00
0222424aef Make mods IReadOnlyList<Mod> gamewide
Prevents potential multiple evaluations of enumerable.
2019-04-10 17:20:36 +09:00
c584967eb1 Remove mods from workingbeatmap 2019-04-09 12:59:32 +09:00
c39c37a18d Apply more missed cases 2019-04-01 12:44:46 +09:00
936c3e1ed9 Add safety type check to DrawableScrollingRuleset 2019-03-20 11:34:06 +09:00
7b6d882ce6 Remove double-generic type 2019-03-20 11:29:16 +09:00
baea7230bc Rename RulesetContainer to DrawableRuleset 2019-03-19 23:47:31 +09:00
26d53d06a9 Fix remaining issues 2019-02-28 13:31:40 +09:00
d8c55bc729 Adjust namespaces 2019-02-21 19:05:52 +09:00
bca347427f Update with framework bindable changes 2019-02-21 18:56:34 +09:00
8617aaa2a7 Update licence header (and remove year) 2019-01-24 17:43:03 +09:00
f27bd3ef3e OpenTK -> osuTK 2018-11-20 17:14:59 +09:00
2ae139d260 Merge branch 'master' into more-global-scrollalgo 2018-11-14 13:54:53 +09:00
b9b20607af Add IScrollAlgorithm.TimeAt() 2018-11-12 17:43:22 +09:00
d8e7ad8241 Fix post-rebase issues 2018-11-12 17:36:19 +09:00
10543cf1b6 Move rest of ScrollingPlayfield into ScrollingRulesetContainer 2018-11-12 17:34:35 +09:00
e7969ecec7 Move ScrollAlgorithm inside IScrollingInfo 2018-11-12 17:34:35 +09:00
54668a0dec Simplify construction of ScrollingInfo 2018-11-12 17:34:35 +09:00
ad45bc7666 Move scroll direction to scrollinginfo 2018-11-12 17:34:35 +09:00
48486895ba Remove unused code 2018-11-12 17:34:35 +09:00
9fde7f7f44 Move scrolling info to osu.Game 2018-11-12 17:34:35 +09:00
7f0f143a1b Move IScrollAlgorithm to ScrollingRulesetContainer + use DI 2018-11-12 17:34:35 +09:00
aee7a80e71 ScrollAlgorithm -> ScrollVisualisationMethod 2018-11-12 17:26:37 +09:00
33056b8098 Adjust namespaces 2018-11-08 14:04:21 +09:00
f66a9f4f1e Rename IScrollChangeVisualiser -> IScrollAlgorithm 2018-11-08 14:04:21 +09:00