83c0cb1acc
Fix beatmap set to null after exiting song select
2022-09-07 21:34:29 +09:00
fcea244537
Remove initial selection from OnlinePlaySongSelect
...
This stuff never really worked anyway - every case except with an
already created multiplayer room was broken anyway.
2022-09-07 21:34:29 +09:00
208bd0f391
Give OnlinePlaySongSelect a reference PlaylistItem
2022-09-07 21:34:29 +09:00
6a03b4e0de
Merge branch 'master' into true-gameplay-rate
2022-09-07 20:01:03 +09:00
770c1ade2f
Add test coverage of track rate adjusting during multi spectator
2022-09-07 20:00:24 +09:00
cb9bae1f5c
Enable NRT
2022-09-07 19:54:55 +09:00
e6b449fe0b
Fix case of zero rate calculating a zero true gameplay rate
2022-09-07 19:23:44 +09:00
1be3b74ff3
Fix multiplayer spectator not getting gameplay adjustments applied
2022-09-07 19:12:34 +09:00
fa15502384
Move full track adjustment flow inside MasterGameplayClockContainer
2022-09-07 19:12:16 +09:00
75d0deef72
Apply proposed changes to remove inheritance from MasterGameplayClockContainer
2022-09-07 17:49:05 +09:00
f8e37af2e0
Merge pull request #20171 from peppy/beatmap-carousel-nrt
...
Fix missing null checks on `selectedBeatmap` fields in `BeatmapCarousel`
2022-09-07 17:15:00 +09:00
68c27522e7
Merge pull request #20158 from smoogipoo/taiko-geki-katu
...
Decode taiko Geki/Katu from legacy scores into `LargeBonus`
2022-09-07 17:06:42 +09:00
99ef0c95fe
Simplify children assignment
2022-09-07 16:51:51 +09:00
5b758afd09
Merge branch 'master' into taiko-geki-katu
2022-09-07 16:22:47 +09:00
824e68dab3
Fix VectorScale set to 0 still showing some sprites in storyboard
...
This implementation was matching the [framework side implementation of
scale](16d1c2d335/osu.Framework/Graphics/Drawable.cs (L973-L976)https://github.com/ppy/osu/issues/20155 .
2022-09-07 15:39:19 +09:00
dc71abdf56
Merge pull request #20144 from peppy/fix-notification-overlay-presence
...
Fix completion toasts sometimes not displaying
2022-09-07 14:55:33 +09:00
f3bda4e040
Fix weird edge case of nullability in CarouselRoot
...
A bit unfortunately, but it's what we get for having ctor level bindings..
2022-09-07 14:27:25 +09:00
e18b524f8e
Fix missing null checks on selectedBeatmap fields in BeatmapCarousel
2022-09-07 14:12:35 +09:00
241d33d415
Apply NRT to BeatmapCarousel
2022-09-07 14:07:53 +09:00
cb1d886c9c
Add audio feedback for Esc/Back clearing text from a FocusedTextBox
2022-09-07 13:17:04 +09:00
3003fc1061
refactor(osu.Game): improve code quality
2022-09-07 02:29:15 +09:00
90207b6032
Merge branch 'master' into feature/EditorDeleteDiff
2022-09-06 18:48:06 +03:00
7c0e99c5a8
Decode Geki/Katu from legacy taiko scores into LargeBonus
2022-09-07 00:12:34 +09:00
66c44f5913
Delegate interface to valid target
2022-09-06 22:26:46 +09:00
bc1212f4e6
Change NonGameplayAdjustments to GameplayAdjustments and convert TrueGameplayRate to extension method
2022-09-06 22:26:46 +09:00
db15bd56e8
Invalidate working beatmap cache when calling DeleteDifficultyImmediately rather than in editor code
2022-09-06 18:12:47 +09:00
579e7e1f17
Fix deleting a difficulty not updating the beatmap set hash
2022-09-06 18:12:47 +09:00
a3de5f808e
Fix typo in LoopStartTime addition
2022-09-06 17:46:03 +09:00
6e52dbb266
Update IsDisplayingToasts to check the flow count directly
2022-09-06 17:30:24 +09:00
677708c5e4
Rewrite logic using a list
2022-09-06 16:58:51 +09:00
d667f46830
Refactor alpha check to not overwrite sourced overrides with values from later commands
2022-09-06 16:41:32 +09:00
bea42d2862
Handle earliest-alpha-start-time logic in StoryboardSprite itself
2022-09-06 16:16:58 +09:00
a5e57b083c
Remove EarliestDisplayTime's input to CommandStartTime
2022-09-06 16:16:58 +09:00
9e3228aa65
Fix completion notification not being posted if completion occurs during NotificationOverlay load
2022-09-06 04:07:49 +09:00
b109e5de6c
chore(osu.Game): align height of bars on timing distribution graph to basalHeight first and combine their transitions into each one
2022-09-06 00:04:10 +09:00
44b456e216
Use gameplay clock's TrueGameplayRate in FrameStabilityContainer?
2022-09-05 23:38:22 +09:00
266eb758aa
Use new flow to calcaulate TrueGameplayRate
2022-09-05 23:37:49 +09:00
7084aeee05
Add method flow to reset applied adjustments
2022-09-05 23:22:38 +09:00
e33486a766
Implement IAdjustableAudioComponent in MasterGameplayClockContainer
2022-09-05 23:20:02 +09:00
6296c971f8
Merge pull request #20136 from smoogipoo/fix-cancellation-perf
...
Improve performance when cancelling import with debugger attached
2022-09-05 22:03:50 +09:00
b2f30fbf8c
Add countdown exclusivity
2022-09-05 20:13:23 +09:00
510972e3ad
Avoid reference counting by using height calculation for IsPresent instead
...
The reference counting was to guarantee performance (zero allocations)
when the notification overlay was not required, but adds extra
complexity.
Instead, the toast tray now uses its ongoing height calculation as a
metric for presence.
2022-09-05 19:38:09 +09:00
0514c96191
Fix incorrect count tracking when notification is manually disposed
2022-09-05 19:26:40 +09:00
229e1a8ef7
Fix notification overlay being present when it doesn't need to
2022-09-05 19:13:58 +09:00
f754686521
Remove necessity of AlwaysPresent for ProgressUpdate completion posting
2022-09-05 19:13:58 +09:00
2923c10cd8
Rewrite rooms to store multiple active countdowns
...
Update test to the new structure
2022-09-05 19:03:26 +09:00
0d4ee6bd80
Centralise ability to fetch all toast tray notifications (including animating ones)
2022-09-05 18:42:20 +09:00
eca7b8f988
Fix completion notifications not always showing as toasts
2022-09-05 18:39:11 +09:00
4fa6707bf0
Set all progress notifications to non-important
2022-09-05 18:29:35 +09:00
87e26e34b8
Merge pull request #20141 from peppy/fix-editor-timeline-sv-display
...
Fix incorrect slider length in timeline when non-default velocity is inherited from previous object
2022-09-05 17:51:25 +09:00
