3bcdce128c
Use dictionary add for safety
2022-01-21 15:29:21 +09:00
ff4f40db8a
Merge branch 'master' into carousel-performance-n
2022-01-21 15:27:42 +09:00
c4f24ef96c
Merge pull request #16542 from peppy/carousel-search-performance-less-simple
...
Avoid performing full filter when updating carousel beatmap sets
2022-01-21 15:05:30 +09:00
bed7b69464
Apply NRT to CarouselGroup
2022-01-21 13:26:29 +09:00
5b24800b0e
Avoid applying filter in UpdateBeatmapSet
flow
2022-01-21 13:26:25 +09:00
45bf35c425
Avoid performing keyword filtering at song select unless keywords are specified
2022-01-21 12:26:24 +09:00
ba31ddee01
Revert beatmapSets
reference to fix tests
...
New version changed order.
2022-01-21 00:34:12 +09:00
80f3a67876
Use for
instead of foreach
to avoid enumerator overhead
2022-01-20 22:21:00 +09:00
0b93f3c88f
Add <Guid,CarouselBeatmapSet>
dictionary to speed up update operations in carousel
2022-01-20 22:12:49 +09:00
9a864267d2
Fix CarouselGroupEagerSelect
not invoking subclassed AddChild
from AddChildren
calls
2022-01-20 21:57:16 +09:00
a8ce2c5edf
Detach before sending BeatmapSetInfo
to any handling method
2022-01-20 21:14:10 +09:00
b1cf3befa6
Fix incorrect query in comment
2022-01-20 18:36:20 +09:00
3ba712703b
Add a note about hidden beatmap check
2022-01-20 17:50:17 +09:00
1dabf6c8a5
Fix BeatmapCarousel
signalling it is finished loading before catching up on realm changes
2022-01-20 16:39:42 +09:00
6c46fd6931
Fix some failing tests due to realm beatmaps overwriting test beatmaps
2022-01-20 00:19:16 +09:00
2789986699
Use asynchronous loading for beatmap carousel again
2022-01-19 18:15:43 +09:00
200fcb6f83
Detach beatmap set before checking hidden state
2022-01-19 16:59:49 +09:00
581873f944
Merge pull request #16497 from peppy/top-local-rank-optimisation
...
Rewrite `TopLocalRank` to use realm subscriptions
2022-01-19 14:22:12 +09:00
9be5bf38c6
Simplify binding/invalidation in TopLocalRank
2022-01-19 13:20:52 +09:00
7f65f3a47f
Remove all usage of BaseDifficulty
(and access Difficulty
instead)
2022-01-18 22:57:39 +09:00
f5b8653491
Add spaces to query string
2022-01-18 19:28:09 +09:00
27ea37c690
Rewrite TopLocalRank
to use realm subscriptions
...
This addresses the number one performance concern with realm (when
entering song select). Previous logic was causing instantiation and
property reads of every score in the database due to the `AsEnumerable`
specfication.
2022-01-18 18:17:53 +09:00
11ca1b6e7b
Remove one more usage of IsManaged
which could potentially go wrong
2022-01-17 13:40:27 +09:00
03e4ec4214
Merge branch 'master' into realm-integration/score-and-beatmaps
2022-01-15 14:45:42 +01:00
19467e58c1
Remove unused params from BDL methods
2022-01-15 01:06:39 +01:00
54804ebfbd
Fix delete/clear scores buttons not working
2022-01-13 18:38:38 +09:00
069d6d2954
Remove pointless compatibility parameter BeatmapSetInfoID
2022-01-13 18:02:10 +09:00
6025fe325d
Fix filter criteria not being applied after carousel loads new beatmap sets
2022-01-13 15:08:51 +09:00
b2d09b7b10
Fix further warnings
2022-01-12 23:42:12 +09:00
51251e3204
Fix CI reported warnings
2022-01-12 22:39:00 +09:00
ef0f794fd6
Remove stay newline
2022-01-12 18:13:14 +09:00
eb70a1eeb7
Replace compatibility properties with direct references
2022-01-12 18:13:14 +09:00
34aa1bf21d
Sanitise and remove some usages of Detach
which are no longer required
2022-01-12 17:49:11 +09:00
dc3730f334
Fix song select import popup not always showing
2022-01-12 17:49:11 +09:00
0aff1c232b
Fix deleted/hidden carousel queries
2022-01-12 17:49:11 +09:00
7dba3c3551
Fix most remaining test issues
2022-01-12 17:49:11 +09:00
58f8aae731
Fix one missed instance of GetResultSafely
2022-01-12 17:49:11 +09:00
02d0ca2741
Fix protected beatmaps showing up in the song select carousel
2022-01-12 17:49:10 +09:00
41d90cd0b5
Fix beatmap carousel test failures
2022-01-12 17:49:10 +09:00
e74a5022c9
Fix multiple tests via null checks and changing ToLive
to Detach
...
flow
2022-01-12 17:00:17 +09:00
6919df18fa
Fix incorrect ordering and grouping of difficulties at song select
2022-01-12 17:00:17 +09:00
2b8706b6ce
Detach and reattach scores to make work
2022-01-12 17:00:16 +09:00
60d2de8a3b
Fix potential nullref when song select filters to no results
2022-01-12 17:00:16 +09:00
de3a338d02
Update realm queries to use Filter
to allow for indirect property filtering
2022-01-12 17:00:16 +09:00
8461eaab46
BeatmapSetInfo
detach support
2022-01-12 17:00:16 +09:00
3811bd8520
Fix some null inspections
2022-01-12 17:00:16 +09:00
33060990b7
Temporarily disable WorkingBeatmapCache
and fix multiple invalid data flows
2022-01-12 17:00:16 +09:00
4295815c7d
Fix invalid equality comparison in BeatmapLeaderboard
2022-01-12 17:00:16 +09:00
6d60aa7d9c
Replace TopLocalRank
event flow with realm subscriptions
2022-01-12 17:00:16 +09:00
c9257e9ecc
Fix missing disposal of realm subscriptions in BeatmapCarousel
2022-01-12 17:00:16 +09:00