2d33859e7a
Merge pull request #18094 from apollo-dw/sliderticks
...
Reimplement slider ticks in Strict Tracking mod sliders
2022-05-09 17:16:47 +09:00
2aa5524c8f
Merge pull request #18155 from frenzibyte/results-screen-scaling
...
Remove dual-direction mouse wheel scrolling at results screen
2022-05-09 17:16:29 +09:00
1677f1d696
Merge branch 'master' into results-screen-scaling
2022-05-09 11:11:55 +03:00
2f3ac61b47
Revert "Replace vertical scrolling in results screen with size-preserving container"
...
This reverts commit 298c2a1828
2022-05-09 10:35:14 +03:00
422531d8ec
Revert "Remove no longer required constant"
...
This reverts commit 6f4cdccf6c
2022-05-09 10:35:13 +03:00
3407a299ef
Revert "Revert scale locking changes for now"
...
This reverts commit e4521b1fff
2022-05-09 10:35:12 +03:00
e4521b1fff
Revert scale locking changes for now
2022-05-09 10:16:57 +03:00
bf9384b7fe
Merge pull request #18124 from ThePooN/sentry-new-dsn
...
🔧 Update Sentry DSN
2022-05-09 15:40:35 +09:00
6aff531014
Merge pull request #18157 from bdach/mod-overlay/empty-columns
...
Hide empty columns on new mod select design
2022-05-09 14:59:18 +09:00
36cda34561
Merge pull request #18165 from smoogipoo/lookup-cache-unobserved
...
Prevent throwing exceptions on first run without internet
2022-05-09 14:49:06 +09:00
3b4fdf20f9
Prevent throwing exceptions on first run without internet
2022-05-09 12:15:54 +09:00
45c6f5edef
Merge pull request #18158 from ekrctb/fix-banana-shower-placement-negative-duration
...
Fix duration is negative while placing banana shower in catch editor
2022-05-09 11:26:06 +09:00
9512d591d7
Merge pull request #18149 from ekrctb/fix-catch-editor-placement-not-shown-in-timeline
...
Fix catch editor juice stream and banana shower not shown in timeline while placement is waiting
2022-05-09 11:19:15 +09:00
0d0d999199
Merge pull request #18147 from ekrctb/fix-catch-per-hit-object-slider-velocity
...
Fix per-hit object slider velocity ignored in osu!catch
2022-05-09 11:17:25 +09:00
158f134260
Fix duration is negative while placing banana shower in catch editor.
...
Timeline blueprint is glitched when the hit object has negative duration.
Negative duration is unwanted anyways so placement implementation is fixed instead of supporting it in timline blueprint.
2022-05-09 00:01:05 +09:00
483a611c41
Fix BeginPlacement location.
2022-05-08 23:10:51 +09:00
d964b4f23c
Fix uneven spacing when some mod columns are hidden
2022-05-08 15:40:21 +02:00
6bdcf893b7
Move alpha management closer to screen level
...
Felt bad messing with alpha at the column level.
2022-05-08 15:40:10 +02:00
6f4cdccf6c
Remove no longer required constant
2022-05-08 16:20:26 +03:00
7f1ad149d5
Remove no longer necessary horizontal scroll blocker
2022-05-08 16:04:24 +03:00
298c2a1828
Replace vertical scrolling in results screen with size-preserving container
2022-05-08 16:03:57 +03:00
077c77d524
Add method for scaling results screen in tests
2022-05-08 16:00:07 +03:00
38c004d734
Add test coverage for hiding mod columns
2022-05-08 14:54:06 +02:00
92ccec20d7
Hide mod columns if all mods within are filtered out
2022-05-08 14:53:59 +02:00
dcf0d5a9d5
Fix slider velocity wrongly decoded as scrolling speed in osu!catch
2022-05-08 21:49:42 +09:00
569b73cf69
Merge pull request #18152 from peppy/scroll-mod-select-into-view
...
Scroll mod select slightly into view on first display
2022-05-08 13:58:16 +02:00
b8cb2c1b82
Increase scroll amount slightly
2022-05-08 19:57:03 +09:00
778497b9e2
Scroll mod select slightly into view on first display
2022-05-08 18:58:54 +09:00
aef5093e47
Merge pull request #18151 from bdach/mod-overlay/samples-playing-while-hidden
...
Fix mod panel samples playing when using autoplay shortcut
2022-05-08 18:45:52 +09:00
b92d95a17a
Fix mod panels playing samples when hidden at a higher level
2022-05-08 10:39:49 +02:00
81ca534f87
Implement ISamplePlaybackDisabler in mod select
2022-05-08 10:39:49 +02:00
cbd1169495
Move cache declarations of ISamplePlaybackDisabler to interface
2022-05-08 10:38:58 +02:00
9ae019eb39
Move ISamplePlaybackDisabler to more general namespace
2022-05-08 10:38:58 +02:00
4199bab1f1
Merge pull request #18145 from peppy/simplify-hide-logic
...
Simplify and centralise hiding logic for mod overlay
2022-05-08 10:26:57 +02:00
125628dd20
Fix hit object not shown in timline while placement is waiting
2022-05-08 15:52:14 +09:00
3eeedd8024
Fix per-hit object slider velocity ignored in osu!catch
2022-05-08 13:45:21 +09:00
230c4e27b8
Simplify and centralise hiding logic for mod overlay
...
Behaviourally, this also always toggles via button triggering to add the
button flash animation.
2022-05-08 13:03:28 +09:00
dabe295196
Merge pull request #18141 from bdach/mod-overlay/multiple-instance-loop
...
Fix toggling mods after exiting first run setup overlay at UI scale step causing stack overflow
2022-05-08 12:36:06 +09:00
834e7b4323
Merge pull request #18142 from bdach/mod-overlay/skin-editor-breakage
...
Fix skin editor overlay showing behind mod select overlay
2022-05-08 00:30:31 +03:00
a45ca2ad10
Fix focused overlays not registering as such
...
Also fixes bug wherein opening skin editor at song select with mod
select open would show mod select on top of the skin editor.
2022-05-07 22:50:14 +02:00
bdea6d8654
Add failing test for mod overlay not closing on entering skin editor
2022-05-07 22:47:19 +02:00
a3e61fddcb
Rename skin editor scene library test scene to be more general
2022-05-07 22:43:53 +02:00
836de49135
Adjust skin editor scene library test for extensibility
2022-05-07 22:43:47 +02:00
46d3220c07
Isolate sample screens from global mods bindable
...
Fixes scenario wherein entering the first run setup overlay, exiting at
the "UI scale" step (which shows a song select), then moving to actua
song select and trying to select a mod would lead to a crash.
The crash was caused by two active mod screen instances attempting to
swap the global mod bindable's mod instances for ones they owned. This
logic - while generally problematic and hard to maintain - was fixing
several issues with mod reference management and setting copying, so I'm
letting it live another day.
This change will mean that the song select preview on the "UI scale"
step will not receive the same mods that the actual game has enabled.
That said, it already doesn't use the same beatmap or ruleset, so this
looks fine to break.
2022-05-07 21:44:58 +02:00
3bb22dece6
Merge pull request #18111 from bdach/mod-overlay/integration
...
Replace old mod overlay with new design
2022-05-08 02:44:50 +09:00
2278da563e
Add various xmldoc for nested classes
2022-05-08 02:03:28 +09:00
03c80d9197
Reorder methods / properties in ModSelectScreen for legibility
2022-05-08 01:58:37 +09:00
1d27ef18dc
Add xmldoc for IsValidMod
2022-05-08 01:49:29 +09:00
0d32bf91eb
Hardcode hide key handling in ModSelectScreen
2022-05-08 01:35:11 +09:00
0c2b4a6c0b
Fix invalid IsLoaded check
...
Would fail when `availableMods` would be changed from a different thread
while the columns aren't loaded.
2022-05-07 15:44:22 +02:00
