Commit Graph

440 Commits

Author SHA1 Message Date
7d2b77cdbd improve selection box rotation UX 2020-12-13 07:58:58 -05:00
71a121389b Merge pull request #11033 from smoogipoo/immutable-hit-samples
Make HitSampleInfo immutable
2020-12-02 14:44:26 +09:00
94a8784e04 Allow editor change handler to be null 2020-12-01 20:08:31 +01:00
190c6ef45e Fix timeline not updating ticks correctly after arbitrary timing control point changes 2020-12-01 16:44:08 +09:00
5760e1c1fc Make HitSampleInfo immutable 2020-12-01 15:37:51 +09:00
c17d67bc7d Merge branch 'master' into editor-beat-snap-always 2020-11-30 18:34:38 +09:00
7edbba58f7 Avoid updating hitobjects unnecessarily for start time changes
This was firing regardless of whether the start time was changed, such
as where beat snap provided the same time the object already has.

The case where a change actually occurs is already handled by
EditorBeatmap (see `startTimeBindables`), so it turns out this local
handling is not required at all.
2020-11-27 16:31:06 +09:00
741902f1b3 Merge pull request #10971 from smoogipoo/fix-timeline-combo-colour
Fix timeline blueprints sometimes not receiving combo colours
2020-11-26 19:47:21 +09:00
da6bccc812 Apply beat snap if positional snap doesn't give a time result 2020-11-26 19:20:51 +09:00
91592cf32d Expose EditorClock for consumption 2020-11-26 19:20:39 +09:00
9811c46e35 Rename application method to better describe what it actually does 2020-11-26 19:16:18 +09:00
e53f849aa0 Completely separate combo colours from DHOs 2020-11-26 18:14:25 +09:00
f562854feb Fix timeline objects sometimes not receiving combo colours 2020-11-26 17:22:22 +09:00
0ddeff648d Fix incorrect index lookup on non-ordered selections 2020-11-25 17:25:54 +09:00
c9a41f9dae Make all objects in selection candidates for spatial snapping
Closes #10898.
2020-11-24 17:35:54 +09:00
f00c23b4a0 Add comment + xmldoc 2020-11-18 13:37:15 +09:00
783c172b5d Make sealed and cleanup comparator 2020-11-18 13:33:22 +09:00
58c8184ad7 Define blueprint order similarly to hitobjects 2020-11-17 22:56:31 +09:00
7b79b9b9c1 Merge branch 'master' into fix-quick-delete-crash 2020-11-16 13:54:54 +09:00
399a1a16a0 Refactor beginClickSelection in a slightly different way 2020-11-15 21:06:47 +01:00
1db303b159 Revert beginClickSelection logic 2020-11-15 16:54:48 +01:00
8a78d408db Add more missed null checks 2020-11-14 15:52:12 +01:00
610ed99ae3 Add null checks to unguarded resolved-as-null fields 2020-11-14 14:52:58 +01:00
4d2bc790fd Fix crash on shift+right-click deleting objects 2020-11-14 13:20:16 +01:00
0219aff7bc Add timeline visible range adjustment 2020-11-13 17:10:29 +09:00
3957697c48 Add pooling support to the editor 2020-11-13 17:08:20 +09:00
4ef2e9548c Pass HitObjectComposer to BlueprintContainer via ctor 2020-11-13 16:59:37 +09:00
de6fcd1792 Fix BlueprintContainer triggering assert when left and right mouse button are pressed together 2020-11-10 17:16:28 +09:00
a012105dac Fix editor quick delete being triggerable from left mouse button
Closes https://github.com/ppy/osu/issues/10629.
2020-11-10 16:54:37 +09:00
ddbd6df24d Unbind bindable lists for general safety 2020-11-07 20:59:57 +01:00
ea2fd831ab Merge branch 'master' into editor-slider-control-point-quick-delete 2020-11-05 00:38:42 +09:00
d19b799f44 Invert boolean logic 2020-11-04 17:53:03 +09:00
3322c2bbc5 Merge branch 'master' into ios-editor-crash-fix 2020-11-04 15:56:40 +09:00
487a5ecdba Replace all usage of IBindableList.GetBoundCopy 2020-11-04 15:29:14 +09:00
42c543f5b9 Merge branch 'master' into fix-editor-play-after-drag 2020-11-04 14:45:20 +09:00
3bb86ce127 Merge branch 'master' into editor-waveform-opacity 2020-11-03 23:04:19 +01:00
13f729916a Merge branch 'master' into editor-timeline-scroll-mousewheel 2020-11-03 22:27:35 +01:00
ddf0d75c38 Don't fall through to seek if handling zoom 2020-11-03 21:49:21 +01:00
4b528e80d0 Use AltPressed shorthand 2020-11-03 21:49:04 +01:00
18428dff8e Ensure hotkey actions are executable in handler 2020-11-03 18:01:12 +01:00
83c004bbde Add key bindings for flip and reverse patterns 2020-11-03 21:10:31 +09:00
9f333ac58a Add the ability to delete slider control points using shift+right click
Closes https://github.com/ppy/osu/issues/10672.

In two minds about how this should be implemented but went in this
direction initially. The other way would be to add local handling of
Shift-Right Click inside PathControlPointPiece (which is already doing
mouse handling itself).
2020-11-03 20:46:33 +09:00
c2ffc18379 Change editor timeline mouse wheel handling to scroll by default (and zoom with alt held) 2020-11-03 16:30:11 +09:00
0dcb4ea441 Add handling of opacity to timeline waveform display 2020-11-03 16:07:01 +09:00
34aa59f237 Fix editor clock not always remaining stopped when dragging timeline
Closes https://github.com/ppy/osu/issues/10461.
2020-11-03 15:00:01 +09:00
ab308d28d2 Debounce calls to UpdateTernaryStates
Just something I noticed in passing recently which may help with
reducing performance overhead of some batch operations.
2020-11-03 01:08:36 +09:00
8a768669ad Merge pull request #10606 from FamousPig/fix-timeline-drag-select-weirdness
Fix timeline zoom during drag-select causing unexpected behaviour
2020-11-02 13:04:26 +09:00
5ae3da9399 Merge branch 'master' into fix-timeline-drag-select-weirdness 2020-11-02 11:18:37 +09:00
432282e8de Use alternative solution to avoid storing last zoom 2020-11-01 21:25:05 +01:00
1f8d627af4 Merge branch 'master' into shift-delete-all-selected 2020-11-01 23:03:01 +09:00