Commit Graph

21744 Commits

Author SHA1 Message Date
6c6540addf Merge pull request #11008 from peppy/settings-remove-transparency
Remove semi-transparent backgrounds from settings and notifications overlays
2020-11-30 19:29:53 +09:00
c29ad8edf8 Better API for dealing with the contained drawable samples 2020-11-30 19:26:25 +09:00
f5e8d1d14d Lose old reference immediately on updateSample() 2020-11-30 19:19:24 +09:00
7f34e11467 Merge pull request #10962 from smoogipoo/improve-dho-time-offsets
Fix judgement offsets in non-framestable contexts
2020-11-30 19:13:25 +09:00
51bddd4a0f Rename functions, and add NextInt. 2020-11-30 18:46:28 +09:00
afb8eb636d Apply simple PR reviews 2020-11-30 18:40:22 +09:00
3ad2eeaff5 Fix outdated xmldoc 2020-11-30 18:35:30 +09:00
c17d67bc7d Merge branch 'master' into editor-beat-snap-always 2020-11-30 18:34:38 +09:00
4bbeb9ebd4 Merge branch 'master' into hit-sample-pooling 2020-11-30 18:31:58 +09:00
b56e832e83 Merge pull request #10950 from ekrctb/pool-scrolling
Support hit object pooling in ScrollingPlayfield
2020-11-30 18:29:34 +09:00
731e689f2d Add summary tags to the doc comments 2020-11-30 18:07:37 +09:00
8f48389f89 Merge branch 'master' into improve-dho-time-offsets 2020-11-30 18:01:48 +09:00
965cc1f511 Remove unnecessary usings #2 2020-11-30 17:57:25 +09:00
46cab04929 Merge branch 'settings-remove-transparency' into settings-reduce-visual-clutter 2020-11-30 17:57:10 +09:00
a3ef858f3a Remove unnecessary multiplication 2020-11-30 17:56:04 +09:00
fe48b2279c Adjust various paddings and spacings in settings to make them easier to visually parse 2020-11-30 17:50:35 +09:00
a3dd22f5c2 Merge branch 'master' into settings-remove-transparency 2020-11-30 17:50:26 +09:00
bf2c6dc241 Remove unused usings rider couldn't see 2020-11-30 17:49:55 +09:00
7ac2fba127 More reordering of public vs private methods 2020-11-30 17:44:58 +09:00
b0637cebd1 Merge branch 'master' into song-select-track-selected-better-2 2020-11-30 17:26:15 +09:00
52cb30dff2 Merge pull request #10999 from bdach/user-interface-settings-section
Create "User Interface" settings section
2020-11-30 17:25:04 +09:00
a4e061cb11 Remove semi-transparent backgrounds from settings and notifications overlays
I tried also updating the colours to the "new" versions from designs but
they don't match due to colour profile differences (so I'm not yet sure
if they are correct or not) and also don't look great without all the UI
elements also being updated.
2020-11-30 17:19:55 +09:00
11d1450c76 Merge branch 'master' into fruit-bindables 2020-11-30 16:48:22 +09:00
4e1e45f3e7 Move hold-to-confirm back to UI section 2020-11-30 16:15:35 +09:00
55c8aa5d5f Move menu cursor size to UI section 2020-11-30 16:14:15 +09:00
e14db45374 Reorder settings to (probably) feel more correct 2020-11-30 16:09:38 +09:00
2745659986 Reword and xmldoc some comments 2020-11-30 15:54:20 +09:00
69c2a18220 Merge branch 'master' into fix-drawable-judgement-animation-loss 2020-11-30 14:05:03 +09:00
0c36a3c263 Merge branch 'master' into pool-scrolling 2020-11-30 14:04:54 +09:00
5a276f8577 Merge branch 'master' into fix-editor-reapply-same-state-change 2020-11-30 13:34:03 +09:00
9145557522 Revert "Revert "forgot to remove something... sorry""
This reverts commit 6478bed431.
2020-11-29 23:15:12 -05:00
6478bed431 Revert "forgot to remove something... sorry"
This reverts commit a780a8bbd8.
2020-11-29 23:14:43 -05:00
30dc0bc019 Merge pull request #10993 from LittleEndu/star-scale
Scale stars from 0.4 to 1
2020-11-30 13:05:44 +09:00
a780a8bbd8 forgot to remove something... sorry 2020-11-29 21:52:58 -05:00
3994cf082d add keybind for in game overlay 2020-11-29 20:59:02 -05:00
e0a84ff1dc Move hold-to-confirm setting back to gameplay section 2020-11-29 22:07:34 +01:00
a5c4a8d2e9 Create "User Interface" settings section 2020-11-29 22:07:33 +01:00
4057ca0a57 Merge branch 'master' into fix-editor-unnecessary-object-updates 2020-11-29 21:34:17 +01:00
a3afd88387 Use Interpolation.Lerp 2020-11-28 20:35:03 +01:00
8ad4cf73f5 Scale stars from 0.4 to 1 2020-11-28 17:09:43 +02:00
7e34c5e239 Fix state application always checking newest state for early abort, rather than current 2020-11-27 16:57:11 +09:00
18bb0cb45b Remove unnecessary schedule logic from Apply's local updateState call
There were cases in the editor where rewinding of transforms would
leave the `DrawableHitObject` in a non-`IsPresent` state, resulting in
this scheduled logic never running.

This would in turn cause ghost hitobjects, which disappear under certain
circumstances.

Reproduction:

- Open editor to empty beatmap
- Place single hitcircle at current point in time
- Drag editor timeline backwards to seek before zero, and wait for
  return to zero
- Select hitcircle in playfield
- Drag hitcircle to right in timeline, triggering a start time change
2020-11-27 16:32:05 +09:00
7edbba58f7 Avoid updating hitobjects unnecessarily for start time changes
This was firing regardless of whether the start time was changed, such
as where beat snap provided the same time the object already has.

The case where a change actually occurs is already handled by
EditorBeatmap (see `startTimeBindables`), so it turns out this local
handling is not required at all.
2020-11-27 16:31:06 +09:00
a7194e1bc3 add stateless RNG 2020-11-27 15:43:44 +09:00
b9b8857988 Update framework 2020-11-27 15:11:07 +09:00
bcc197f9fe Merge branch 'master' into improve-dho-time-offsets 2020-11-27 15:03:56 +09:00
792934f2c4 Allow scroll type to be specified
This brings back the ability for the carousel to scroll in a classic
way. It turns out this is generally what we want for "seek" operations
like "random", else it's quite hard to get the expected animation.

I did experiment with applying the animation after the pooled panels are
retrieved, but in a best-case scenario there is still a gap where no
panels are displayed during the random seek operation.
2020-11-27 13:54:38 +09:00
6e40de58e9 Use new OnAdd and OnRemove to invalidate DHO 2020-11-27 13:36:40 +09:00
8f5129323d Merge branch 'master' into pool-scrolling 2020-11-27 13:12:05 +09:00
018957c244 Merge branch 'master' into song-select-track-selected-better-2 2020-11-27 12:54:40 +09:00