1682260677
Remove left over logging line
2020-11-24 15:28:03 +09:00
ee33f62809
Fix DrawableJudgement not always animating correctly on skin change
...
If the skin is changed before gameplay has started (at the loading
screen) it is possible for a sequence of events to occur which results
in the animation not being played:
- `SkinReloadableDrawable` runs its BDL load (and calls `OnSkinChanged`
once)
- User changes skin, triggering `DrawableJudgement`'s skin change
handling (binding directly on the `SkinSource` locally)
- This will call `PrepareDrawables` and reinitialise the
`SkinnableDrawable` child hierarchy, then immediately apply the
animations to it.
- The new `SkinnableDrawable` will then get the `SkinChanged` event and
schedule a handler for it, which will run on its first Update call.
- Any added animations will be lost as a result.
Fixed by binding directly to the `SkinnableDrawable`'s `OnSkinChanged`.
This has the added bonus of not needing to reinitialise the child
hierarchy on skin change (which felt a bit weird in the first place).
2020-11-24 15:23:53 +09:00
57ff150051
Merge pull request #10829 from Joehuu/music-osd-bindings
...
Add music bindings to on screen display
2020-11-24 14:36:34 +09:00
1fd4b04767
Just set music shortcut text locally
2020-11-23 20:43:46 -08:00
e36b1051c1
Add spacing between inline comments
2020-11-24 13:15:59 +09:00
82640418ba
Invert hide logic for readability
2020-11-24 13:12:04 +09:00
44ca67c534
Simplify fill logic and add xmldoc
2020-11-24 13:10:11 +09:00
37ea65de2a
Merge branch 'master' into profile-overlay-graph-new
2020-11-24 12:52:59 +09:00
52f5473cc0
Set global action as a parameter in toast
2020-11-23 15:13:58 -08:00
5701b32bae
Handle constant graphs better
2020-11-23 22:12:32 +01:00
8347ecf494
Simplify row tick creation code
2020-11-23 21:52:47 +01:00
7b0d3dfe0c
Refactor tick calculation code for readability
2020-11-23 21:38:04 +01:00
bb5aa9a9c9
Guard against empty values early
2020-11-23 21:24:37 +01:00
e9ffeb8b5d
Make missing date check more robust
2020-11-23 21:09:42 +01:00
060acb9010
Merge pull request #10935 from bdach/fix-mania-judgement-fade-in
...
Rewind judgement transforms before clearing
2020-11-23 17:05:04 +09:00
5e014fc4fe
Merge pull request #10941 from LumpBloom7/improve-MenuVisualizer
...
Improve LogoVisualisation looks when MenuGlow colors are used
2020-11-23 15:25:18 +09:00
19faa2b9bb
Add comment covering intentional call to ClearTransformsAfter
2020-11-23 15:20:59 +09:00
1b33d30039
Simplify horizontal ticks creation
2020-11-23 08:52:29 +03:00
42741895e6
Merge remote-tracking branch 'refs/remotes/ppy/master' into profile-overlay-graph-new
2020-11-23 08:41:57 +03:00
898e2dae27
Restore kiai time flashing behaviour
2020-11-23 14:27:02 +09:00
5662e722ed
Merge pull request #10936 from bdach/fix-follow-points-getting-stuck
...
Fix legacy follow point animations not playing after a while
2020-11-23 14:14:00 +09:00
3ed7868801
Scroll editor setup screen to file selector on display
...
Previously the file selector would potentially display off-screen,
making for confusing UX.
Closes #10942 .
2020-11-23 13:49:14 +09:00
ae609b9d48
Remove unnecessary local variable
2020-11-23 13:35:13 +09:00
2ae5a95d77
Change opacity value to match master implementation
2020-11-23 13:35:02 +09:00
61078e9ae1
Use 0.2f instead of .2f
2020-11-22 18:59:16 +01:00
ba7ce4c933
Make colour readonly
2020-11-22 18:37:49 +01:00
458016d17d
Remove AccentColour member variable from LogoVisualisation
2020-11-22 17:36:59 +01:00
1551402a8d
Change IntroWelcome visualiser to use Colour instead of AccentColour
2020-11-22 17:33:40 +01:00
b468f061f1
Remove unused using
2020-11-22 17:20:00 +01:00
cc33b0f2c6
Apply MenuGlow to Visualisation Colour instead of AccentColour
2020-11-22 16:53:53 +01:00
827a089810
Merge branch 'master' into change-taiko-ez
2020-11-22 13:29:02 +01:00
1c31a4a6b6
Expose animation start time as mutable in interface
2020-11-22 13:11:22 +01:00
b62a873502
Merge branch 'master' into remove-default-retry-balue
2020-11-22 10:54:40 +01:00
666112cb5a
Address @bdach's minor suggestions
2020-11-22 18:51:16 +09:00
c506b438bf
Remove more code and make some methods private
2020-11-22 18:51:16 +09:00
b745fb681a
Fix incorrect static using placement
2020-11-22 04:40:55 +03:00
4887132947
Adjustments for edge cases support
2020-11-22 04:28:17 +03:00
f07f8089d6
Adjust monthsPerTick value
2020-11-22 03:58:56 +03:00
e6c116f0ab
Rework horizontal ticks creation
2020-11-22 03:49:00 +03:00
6e581902cd
Simplify column ticks creation
2020-11-22 03:11:38 +03:00
453f0ba675
Make tick lines thicker
2020-11-22 02:34:29 +03:00
3cb1d04667
Move dates fill into it's own method
2020-11-22 02:25:12 +03:00
d4b56aac84
Add missing whitespace
2020-11-22 02:17:54 +03:00
9d7ddf8343
Merge master with conflicts resolved
2020-11-22 02:13:35 +03:00
fe4c622041
Make OnUserChanged private
2020-11-21 23:13:46 +03:00
dbfc839df3
Move missing text to PaginatedProfileSubsection
2020-11-21 23:03:54 +03:00
11c3ccfcaa
Move rulesets property to PaginatedProfileSubsection
2020-11-21 22:49:56 +03:00
240c1b0aef
Add support for changing animation start time after load
2020-11-21 20:06:30 +01:00
9f997db958
Rewind judgement transforms before clearing
2020-11-21 17:56:49 +01:00
875f986979
Remove default from base ResultsScreen too
2020-11-21 14:38:38 +01:00
