Commit Graph

55997 Commits

Author SHA1 Message Date
9763a58392 Change to use ReferenceEquals 2022-06-21 12:05:52 +09:00
6a26461683 Compare by reference in ControlPoint.Equals() 2022-06-21 12:05:28 +09:00
345ae7bbc3 Fix build errors after implicit NRT enable 2022-06-21 00:46:52 +02:00
ee96d84ffa Merge branch 'master' into input-settings 2022-06-20 22:55:43 +02:00
21d60231b6 Add limited test coverage of osu:// scheme link IPC flow 2022-06-20 22:22:25 +02:00
330af7ec74 Handle osu:// scheme links via IPC in desktop game 2022-06-20 21:26:22 +02:00
92011124d1 Implement IPC channel for osu:// scheme links 2022-06-20 20:08:36 +02:00
34f1c80b7c Add and use ILinkHandler interface 2022-06-20 20:04:21 +02:00
43ead5820a deal with test 2022-06-21 00:54:50 +09:00
5a5cc523ce Let F to -1 temporary 2022-06-20 23:43:33 +08:00
3f288c69a3 Merge pull request #18780 from peppy/importer-post-import-rename
Rename importer `PostImport` to `PresentImport` and add proper `PostImport`
2022-06-20 17:34:49 +02:00
6c8042642a Reduce code duplication 2022-06-20 17:22:41 +02:00
58d6fa4645 Reduce NoFail pp multiplier 2022-06-20 19:55:26 +08:00
577a87bcad Merge branch 'master' into importer-post-import-rename 2022-06-20 13:37:16 +02:00
ba394f2831 Remove IPostsImports interface (and move to IModelImporter) 2022-06-20 18:53:48 +09:00
bc5e4fd6ca Merge pull request #18779 from peppy/fix-function-diff-cache
Remove necessity to provide `BeatmapDifficultyCache` as a function to `ScoreManager`
2022-06-20 18:46:21 +09:00
a294b26f45 Merge branch 'master' into fix-function-diff-cache 2022-06-20 11:44:42 +02:00
e732c5a2d7 Add PostImport method matching PreImport 2022-06-20 18:40:23 +09:00
45c5013f09 Remove default value of RealmArchiveModelImporter.HandledExtensions
Not used anywhere and probably not wanted ever.
2022-06-20 18:40:23 +09:00
dbae4c6f5a PostImport -> PresentImport 2022-06-20 18:36:29 +09:00
ef71886e1b Merge pull request #18778 from bdach/import-skin-test-cleanup
Remove null default value in `ImportSkinTest` helper method
2022-06-20 18:26:00 +09:00
ebcee21f6f Remove necessity to provide BeatmapDifficultyCache as a function to ScoreManager 2022-06-20 17:52:42 +09:00
b0b3ea42cc Remove null default value in ImportSkinTest helper method 2022-06-20 10:44:14 +02:00
c402e90598 Merge pull request #18777 from peppy/output-directory-on-import-failure
Silence exception and provide more log output when import fails due to empty `.osu` files
2022-06-20 17:36:21 +09:00
c00c2e8f22 Merge pull request #18776 from peppy/less-import-methods
Remove one more `RealmArchiveModelImporter` `Import` method
2022-06-20 17:35:41 +09:00
e0c82d11ab Convert == usages to ReferenceEquals 2022-06-20 16:56:19 +09:00
16281f4a48 Properly annotate method to allow null 2022-06-20 16:56:19 +09:00
ca287d0936 Fix group deselected when table is recreated 2022-06-20 16:56:19 +09:00
d38defada4 Silence exception and provide more log output when import fails due to empty .osu files 2022-06-20 16:07:10 +09:00
e82d948acc Add test coverage of import throwing when no valid .osu files are found 2022-06-20 16:06:22 +09:00
4aa32038c3 Add note about stream provided to ImportTask being disposed implicitly 2022-06-20 15:38:44 +09:00
882e1c69e5 Move nested task back outside try-catch to avoid double-error 2022-06-20 15:36:44 +09:00
678b18dde6 Ensure any non-MemoryStream streams are closed as part of ImportTask 2022-06-20 15:29:56 +09:00
a922ea9b01 Fix selection by directly comparing control points
Previously, all control points would get replaced, which led to
performance issues that was worked around in this PR. By comparing
control points, we're able to get good performance without requiring the
workaround.
2022-06-20 15:29:29 +09:00
03ab6fc141 Implement IEquatable on ControlPoint 2022-06-20 15:27:43 +09:00
dd93c7359e Update xmldoc for importFromArchive method 2022-06-20 15:25:43 +09:00
92f1a2958c Rename Import(TModel) to ImportModel to differentiate from other import methods 2022-06-20 15:18:07 +09:00
a6c8a832aa Remove Import(ArchiveReader) and redirect existing usages to Import(ImportTask) 2022-06-20 15:14:57 +09:00
2edd56ad17 Merge pull request #18747 from ggliv/skin-editor-transform-fix
Clear selected components on SkinEditor hide
2022-06-20 14:47:28 +09:00
7daab2d45b Merge branch 'master' into skin-editor-transform-fix 2022-06-20 14:10:01 +09:00
e4d0c7a0fb Move beatmap import step to only be required when entering gameplay 2022-06-20 14:08:05 +09:00
329f1a0822 Add test coverage of original fail case and improve test reliability and code quality 2022-06-20 14:08:05 +09:00
468e5fcbed Merge branch 'master' into editor-controlpoint-undo-redo 2022-06-20 13:47:01 +09:00
a3fb6fb473 Merge pull request #18774 from frenzibyte/fix-ios-ci
Work around macOS agent regression affecting iOS CI builds
2022-06-20 13:40:04 +09:00
243806e810 Move common step of toggling skin editor to own method 2022-06-20 13:32:44 +09:00
9568525486 Merge pull request #18771 from bdach/editor-playtest-correct-ruleset
Always use beatmap ruleset in editor gameplay test mode
2022-06-20 13:07:39 +09:00
5e594e4de0 Work around macOS agent regression affecting iOS CI builds 2022-06-20 06:54:15 +03:00
26b0815fc8 fixed casting the wrong skill 2022-06-20 04:19:07 +02:00
ecbbd29c9b Merge branch 'master' into speed-acc-scaling
# Conflicts:
#	osu.Game.Rulesets.Osu/Difficulty/OsuDifficultyAttributes.cs
#	osu.Game.Rulesets.Osu/Difficulty/OsuDifficultyCalculator.cs
#	osu.Game.Rulesets.Osu/Difficulty/OsuPerformanceCalculator.cs
#	osu.Game.Rulesets.Osu/Difficulty/Skills/Speed.cs
2022-06-20 04:15:35 +02:00
a912bcadf8 Fix possible exception caused by log(0) 2022-06-20 00:19:29 +02:00