35b7653290
Revert mod flow changes and add visual test coverage showing an overflow case
2022-02-02 09:13:19 +09:00
eee020f8e4
Cleanup tooltip layout
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com >
2022-02-01 20:26:52 +01:00
f87920cd83
Remove unnecessary GridContainer and list mods verticall to give more space
2022-02-01 16:43:26 +09:00
8eace12fe3
Synchronise (roughly) backgrounds of all custom tooltips
2022-02-01 16:35:25 +09:00
3ca2c90684
Add test scores in BeatmapLeaderboard test scene with more mods
2022-02-01 16:35:25 +09:00
fdb52a8fd7
Remove gap in tooltip display between statistics
2022-02-01 16:35:25 +09:00
855135c51e
Fix potential nullref during display due to incorrect equality check
2022-02-01 16:13:27 +09:00
e1b57c4bf6
Fix inspections
2022-02-01 16:07:57 +09:00
d7b939277e
Code quality improvements
2022-02-01 07:10:00 +01:00
fd287e06f2
Add missing license header
2022-02-01 06:51:00 +01:00
c2b775c0a3
Minor alignment adjustments
2022-02-01 06:45:59 +01:00
db973fb348
Add basic tooltip for leaderboard scores
2022-02-01 06:28:18 +01:00
f3d4756c7f
Merge pull request #16713 from frenzibyte/fix-spectator-gcc-state-2
...
Fix multiplayer spectator occasionally rewinding time unexpectedly
2022-01-31 18:33:08 +09:00
62603e78fd
Merge pull request #16714 from frenzibyte/rewrite-hardware-correction-clock
...
Rewrite `HardwareCorrectionOffsetClock` to handle seeking on different gameplay rates
2022-01-31 17:32:22 +09:00
a49a9ed0a0
Fix incorrect invoke
2022-01-31 17:19:04 +09:00
6956146cce
Merge pull request #16718 from peppy/add-key-counter-keyword
...
Add "counter" keyword for key overlay setting
2022-01-31 17:10:12 +09:00
575d9671bf
Merge pull request #16717 from peppy/fix-dialog-overlay-missing-test-failures
...
Fix test failures if `DialogOverlay` is not loaded in time
2022-01-31 17:06:24 +09:00
9005bce0fa
Add "counter" keyword for key overlay setting
2022-01-31 16:37:51 +09:00
cec16d17ab
Merge pull request #16696 from peppy/fix-migration-crash-case-sensitivity
...
Fix stable import not working when multiple configuration files exist with different file case
2022-01-31 15:52:29 +09:00
8d13e0514b
Merge pull request #16716 from peppy/carousel-less-invalidations
...
Refactor carousel drawables to reduce invalidations
2022-01-31 15:52:08 +09:00
95582a9023
Merge pull request #16690 from smoogipoo/flush-frames-end-play
...
Purge final spectator frames before ending play
2022-01-31 15:40:41 +09:00
25cbe5a0de
Remove acronym shortening of GameplayClockContainer
2022-01-31 15:23:31 +09:00
9001c3a396
Fix test failures if DialogOverlay is not loaded in time
...
As seen at https://github.com/ppy/osu/runs/4999391205?check_suite_focus=true , where `DialogOverlay` hasn't loaded in single file yet.
2022-01-31 15:17:07 +09:00
c8c0ae5658
Merge branch 'master' into flush-frames-end-play
2022-01-31 15:12:41 +09:00
57f793aff0
Rename dictionary and make private for added safety
2022-01-31 15:12:08 +09:00
6bc6675fa1
Adjust fade in times slightly
2022-01-31 14:46:20 +09:00
8917ab78f4
Reduce unnecessary container nesting and adjust empty state opacity slightly
2022-01-31 14:46:20 +09:00
2ee0db0ebf
Move fade in function local
2022-01-31 14:46:20 +09:00
c3e3b2019d
Reduce overhead of ApplyState by tracking previous values
...
Even with pooling applied, there are overheads involved with transforms
when quickly cycling through the carousel.
The main goal here is to reduce the transforms in cases the reuse is
still in the same state. Avoiding firing `FadeIn` and `FadeOut` are the
main areas of saving.
2022-01-31 14:46:20 +09:00
a06287e76a
Remove DrawableCarouselItem.Update updating of height
...
Marginal from a performance aspect, but reads better.
2022-01-31 14:46:20 +09:00
e9f3e7f5cb
Merge pull request #16703 from peppy/leaderboard-component-fixes
...
Rewrite `Leaderboard` component to bring up to current code standards
2022-01-31 14:33:04 +09:00
9c9fda84f3
Add schedule and cancellation check to score ordering step
2022-01-31 13:50:53 +09:00
610eb9f6a4
Remove unnecessary container level
2022-01-31 13:45:49 +09:00
e5ffa45ab8
Merge pull request #16710 from peppy/add-intro-playback-safety
...
Add failsafe to `IntroScreen` to stop users with incorrect audio configuration getting stuck
2022-01-31 13:40:40 +09:00
6556a7e3c3
Handle different gameplay rates when seeking on master clock
2022-01-31 01:40:07 +03:00
2b999f9780
Add failing test case
2022-01-31 01:40:07 +03:00
f8939af5e6
Track loading via state as well
2022-01-31 01:12:03 +09:00
1cec76df74
Fix weird reading xmldoc
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com >
2022-01-30 23:18:40 +09:00
82806d7aeb
Ensure the background is eventually displayed when IntroTriangles suspends
2022-01-30 21:32:39 +09:00
6a21d58325
Avoid test failures on non-triangle intro tests
2022-01-30 18:59:18 +09:00
52f1c2bfdb
Add failsafe to IntroScreen to stop users with incorrect audio configuration getting stuck
...
The most common case of this seems to be linux users with incorrect or
unsupported audio driver configurations. It continues to be brought up
in discussions as people are unsure of why their game freezes on
startup, and unable to easily recover.
2022-01-30 18:51:16 +09:00
1dbcb5ab63
Add test coverage of intro fail scenario
2022-01-30 18:51:16 +09:00
04dbb5d3c6
Disallow setting "NoScores" externally as it is handled internally
2022-01-30 16:18:19 +09:00
acc1199add
Consolidate flows of Set operations, either result or error
2022-01-30 16:16:00 +09:00
c401629dd8
Also refactor placeholder logic to make more sense
2022-01-30 10:50:32 +09:00
3ec193d47e
Fix spectator clock container incorrectly starting catch-up clock
2022-01-30 01:46:10 +03:00
4f4f60248f
Add failing test case
2022-01-30 01:46:10 +03:00
b434e29a7c
Move loading hide operation inside early return to ensure not hidden too early
...
It should only be hidden after the async load completes.
2022-01-30 03:10:15 +09:00
dad9cc9315
Ensure Reset/Scores_Set run inline where possible
2022-01-30 03:06:29 +09:00
06660ff960
Fix null beatmap in test scene
2022-01-30 03:02:56 +09:00
