Commit Graph

26654 Commits

Author SHA1 Message Date
3a5912e35e Add new checks to verifiers 2021-07-13 10:53:25 +02:00
6da2a3d51f Add zero-length objects check and tests 2021-07-13 10:50:11 +02:00
351a46b379 Merge pull request #13823 from ekrctb/catch-editor-tests
Add some tests for catch editor blueprints
2021-07-13 08:27:41 +09:00
36dd2c36de Merge pull request #13859 from peppy/update-realm-win-81-fix
Update realm libraries to fix windows 8.1 incompatibility
2021-07-12 16:40:35 +09:00
d5d7dd0e74 Merge pull request #13701 from frenzibyte/consume-bindable-current-factory
Fix `RestoreDefaultValueButton` not behaving correctly on number types
2021-07-12 14:49:00 +09:00
f548ba4f69 Update realm libraries to fix windows 8.1 incompatibility 2021-07-12 14:07:17 +09:00
0c52b26d23 Merge pull request #13824 from peppy/da-mod-refactor
Refactor `ModDifficultyAdjust` to more elegantly track user override status
2021-07-12 12:03:45 +09:00
a6258d705e Make CurrentNumber internal 2021-07-12 11:26:30 +09:00
32b4f5fbd6 Do not store direct references to original bindable
`DifficultyAdjustSettingsControl` and its inner `SliderControl` were
holding different references to `DifficultyBindable`s from the
difficulty adjust mod, therefore leading to bindings being lost to the
framework-side automatic unbind logic if the mod was toggled off and
back on in rapid succession.

Resolve by adding a shadowed implementation of `GetBoundCopy()` and
using it to isolate the controls from the mod bindable.
2021-07-11 15:28:13 +02:00
f21ea3b790 Update player test scene Ruleset bindable from creation method 2021-07-11 03:46:19 +03:00
07ede7a147 Disallow custom rulesets from score submission 2021-07-11 03:34:57 +03:00
c44558e3c8 Add back LoadComplete override 2021-07-10 17:57:52 +03:00
1bd5b1a8b9 Merge branch 'master' into fix-access-denied-test-failures 2021-07-10 13:00:27 +02:00
6f89f8e572 Merge branch 'master' into da-mod-refactor 2021-07-10 11:41:54 +02:00
6a5f0e8237 Move handling of replay seek operations out of progress bar
This is in order to avoid using the now obsoleted property
`SliderBar.AllowKeyboardInputWhenNotHovered`
(see https://github.com/ppy/osu-framework/pull/4579).
2021-07-09 14:28:59 +09:00
741062a6da Simplify bindable update methods 2021-07-09 13:58:44 +09:00
e0277763d0 Refactor DifficultyAdjustSettingsControl to help with readability 2021-07-09 13:50:07 +09:00
f9cd7f10d8 Allow null values for ReadCurrentFromDifficulty
As long as this isn't a constructor parameter it feels best to
gracefully handle omission. Realistically having it in the ctor is the
best move, but it doesn't feel great in line with the other parameters
passed in via object initalisers.
2021-07-09 13:26:01 +09:00
90326f8864 Standardise variables 2021-07-09 13:24:26 +09:00
df4bd86cfc Fix storage wrapping logic setting logger too early in startup sequence 2021-07-09 13:18:49 +09:00
f3b68a4fbf Fix storage wrapping logic setting logger too early in startup sequence 2021-07-09 13:17:25 +09:00
9f7c6adb58 Fix test failures due to logger pollution
As seen at
https://github.com/ppy/osu/pull/13831/checks?check_run_id=3025050307. I
can't confirm that this will fix the issue but it looks like the only
plausible reason. I have confirmed that the logging is not coming from
the local (first logging is guaranteed to be after `SetupForRun`).
2021-07-09 12:15:30 +09:00
dbfeea9880 Merge pull request #13831 from nekodex/add-dropdown-sound-to-profile
Change profile section expansion button to use dropdown sounds
2021-07-09 11:58:48 +09:00
2eb12a59b7 Rename function to be more accurate 2021-07-09 11:16:47 +09:00
0223c569df Remove no longer necessary method definitions 2021-07-09 00:49:05 +03:00
a7be632770 Improve documentation
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-07-09 00:39:09 +03:00
3e21eeb7c2 Merge branch 'master' into fix-mod-select-cross-talk 2021-07-08 19:53:50 +02:00
f5166d8dd5 Merge branch 'master' into consume-bindable-current-factory 2021-07-08 18:13:48 +03:00
b7803b889e Rename control class to be more descriptive 2021-07-08 20:37:38 +09:00
8746ef0ba9 Avoid double playback of sample 2021-07-08 20:36:25 +09:00
546f55d341 Change profile section expansion to use dropdown sounds 2021-07-08 20:23:11 +09:00
93eb385dd4 Add sound for switching between volume controls 2021-07-08 20:01:39 +09:00
af270cccc4 Fix cross talk between ModSelectOverlays 2021-07-08 17:59:04 +09:00
ba939c0b65 Simplify serialisation edge case by moving to Value override 2021-07-08 17:49:00 +09:00
52ea62e3b2 Add more comments and xmldoc 2021-07-08 17:49:00 +09:00
88b00123f6 Use existing reflection methods to avoid manual binding of ExtendedLimits 2021-07-08 17:49:00 +09:00
bd7c334588 Avoid the need for per-settings control classes 2021-07-08 17:49:00 +09:00
a6e94dd491 Add back extended limits support 2021-07-08 17:49:00 +09:00
c4313d6e96 Initial implementation of new flow (only working for approach rate) 2021-07-08 17:48:08 +09:00
fcee69ffe6 Fix ShowsDefaultIndicator not actually being consumed 2021-07-08 17:48:08 +09:00
4ac7d629d7 Expose current placement blueprint 2021-07-08 16:36:41 +09:00
8da1335e5f Add catch placement blueprint visual test scenes (without tests) 2021-07-08 15:51:46 +09:00
bd4b3f5268 Add catch selection blueprint visual test scene (without tests) 2021-07-08 15:42:29 +09:00
0e4f4a6fde Initial storage changes 2021-07-08 14:28:13 +09:00
663ffae42f Fix hit object selection blueprint potential null reference 2021-07-08 14:19:00 +09:00
e612d7568c Merge pull request #13771 from LumpBloom7/volume-meter-switch
Add ability to navigate between volume meters via Alt+Left/Right arrows
2021-07-07 21:50:44 +09:00
7d405f04fb Fix selected volume control not updating correctly on mouse move 2021-07-07 21:17:31 +09:00
cbe4114e90 Adjust visuals and make base opacity 100% 2021-07-07 21:07:00 +09:00
e42609f092 Merge pull request #8038 from thewildtree/adjust-rankings-overlay
Adjust rankings overlay elements to better match osu-web
2021-07-07 20:24:11 +09:00
f7dc689832 Merge pull request #13804 from bdach/migrate-directory-selector
Migrate file/directory selectors to use framework component instead of local implementation
2021-07-07 20:10:26 +09:00