Commit Graph

34485 Commits

Author SHA1 Message Date
905bbdc8ee Remove caching of GameplayClockContainer in favour of GameplayClock
Also fixes `SongProgress` being displayed in skin editor on non-gameplay
screens, due to `GameplayClock` not marked as a required dependency.
2022-07-29 16:45:29 +03:00
3f72e76348 Expose StartTime from gameplay clock 2022-07-29 16:18:05 +03:00
3005ff1b9f Merge branch 'master' into pie-chart-progress 2022-07-28 22:19:27 +09:00
aa03df905f Merge pull request #19441 from peppy/test-working-beatmap-unfuck
Reduce calls to `LoadTrack` by implicitly running on test/dummy classes
2022-07-28 22:05:25 +09:00
11e0022fad Merge branch 'master' into realm-collections 2022-07-28 21:00:08 +09:00
4b140e1f5a Adjust metrics 2022-07-28 18:50:46 +09:00
86c2b7e449 Apply nullability to DefaultSongProgress and clean up more stuff 2022-07-28 18:37:17 +09:00
ea027eda46 Move initial show to base implementation and add transition for legacy version 2022-07-28 18:29:49 +09:00
bfa026879c Remove pointless null check 2022-07-28 18:28:03 +09:00
d5e5761892 Fix DefaultSongProgress graph not resetting if time is in intro 2022-07-28 18:25:24 +09:00
7108553883 Tidy up various things everywhere 2022-07-28 18:25:14 +09:00
a21aee4e9c Reduce calls to LoadTrack by implicitly running on test/dummy classes 2022-07-28 18:11:40 +09:00
628a30193f Remove incorrect TrackLoaded override from TestWorkingBeatmap 2022-07-28 17:49:17 +09:00
1da9830145 Merge pull request #19435 from peppy/remove-beatmap-manager-ruleset-store
Remove unused `RulesetStore` from `BeatmapManager` constructor
2022-07-28 17:46:12 +09:00
0d36907cad apply code quality fixes 2022-07-28 15:30:45 +08:00
bca3994d91 set FirstHitTime and LastHitTime once 2022-07-28 15:25:12 +08:00
2b9d46d803 Remove unused RulesetStore from BeatmapManager constructor 2022-07-28 16:19:05 +09:00
db62d4be3a apply suggestions
- refactor `SongProgress`
- make`UpdateProgress` more readable
- enable NRT on new classes
- refactor `TestSceneSongProgress` to use `GameplayClockContainer`
2022-07-28 15:15:41 +08:00
c1aaf27c54 Link to correct model in xmldoc 2022-07-28 16:02:19 +09:00
525e4a2019 Fix crash in DrawableRoomPlaylistItem context menu creation due to incorrect enumeration casting 2022-07-28 15:51:18 +09:00
452d82f292 Add more comprehensive xmldoc for beatmap model classes 2022-07-28 15:41:28 +09:00
ca68574473 Make NotificationOverlay dependency optional in CollectionSettings 2022-07-28 14:35:27 +09:00
392cb352cc Force alphabetical ordering for now 2022-07-28 14:07:42 +09:00
da06467891 Add missing realm subscription cleanup 2022-07-28 13:57:21 +09:00
ad482b8afc Tidy up naming of collection dropdowns 2022-07-28 13:57:21 +09:00
226eefcc5c Add note about hash storage 2022-07-28 13:57:21 +09:00
1669208a54 Add migration of existing collections database 2022-07-28 13:57:21 +09:00
34a2d1a6e1 Fix ManageCollectionsDialog and remove weird placeholder logic 2022-07-28 13:57:21 +09:00
67c7f324ee Simplify CollectionFilterDropdown filter flow weirdness 2022-07-28 13:57:21 +09:00
aa65b73f19 Merge branch 'master' into add-notif-externalbutton 2022-07-28 12:17:36 +09:00
f44a4c8652 Reorder file content to match expectations 2022-07-28 12:13:47 +09:00
f01c397220 Apply nullability 2022-07-28 12:12:46 +09:00
f097064eea Adjust to reviews 2022-07-27 21:52:38 -04:00
ac39d3a142 "Copied URL" -> "URL copied" 2022-07-27 21:52:28 -04:00
9088caa377 move LegacyComboCounter to osu.Game.Skinning 2022-07-28 08:36:26 +08:00
45c11f2b7b account for gameplay start time 2022-07-28 08:01:38 +08:00
804bb33aed Hook up remaining data flows 2022-07-27 19:35:09 +09:00
438067a18b Convert realm data propagation to more correctly use Live<T>
wip
2022-07-27 19:35:09 +09:00
41393616d8 Replace BeatmapCollection with RealmBeatmapCollection 2022-07-27 19:35:09 +09:00
9c543fef48 Remove CollectionManager 2022-07-27 18:45:33 +09:00
a222278710 remove unused using 2022-07-27 16:01:35 +08:00
37e642b0bd make SongProgress abstract
- move unrelated logic to `DefaultSongProgress`
- make `LegacySongProgress` inherit `SongProgress`
2022-07-27 15:19:21 +08:00
a12676c25d scale down graph from bleeding through border 2022-07-27 14:35:18 +08:00
2d4655f61e Add Toast Notification to Copy URL 2022-07-27 02:25:40 -04:00
6b73f7c7ec Split out legacy import path from realm manager 2022-07-27 15:04:09 +09:00
d8e605d8aa Fix broken tests due to badly reimplemented copy-pasted code 2022-07-27 13:58:01 +09:00
62ca3aada6 Transfer TODO comment across to copy-pasted implmentation 2022-07-27 13:53:27 +09:00
b803ec543f Remove unused combo DI retrieval 2022-07-27 13:50:03 +09:00
842ab3c5c1 remove unused using 2022-07-27 09:41:58 +08:00
3abf44da91 Merge branch 'master' into pie-chart-progress 2022-07-27 08:53:23 +08:00