Commit Graph

1905 Commits

Author SHA1 Message Date
c5b684bd2e Fix typo in log when beatmap fails to load 2020-09-23 00:30:20 -07:00
3276b9ae9c Fix fail animation breaking on post-fail judgements 2020-09-22 15:08:53 +09:00
06c49070b1 Remove player collection settings 2020-09-11 16:04:09 +09:00
d3957e6155 Move title specification for settings groups to constructor
Using an abstract property was awkward for this as it is being consumed
in the underlying constructor but could not be dynamically set in time from a
derived class.
2020-09-09 18:50:31 +09:00
82e314da59 Fix merge conflicts. 2020-09-03 21:56:47 +02:00
84b3604192 Merge branch 'master' into game-overlay-activation-mode 2020-09-03 13:34:22 +09:00
7e1844ed77 Fix track adjusments being reset incorrectly 2020-09-01 18:07:19 +09:00
26b4226b55 Fix ModTimeRamp not working 2020-09-01 16:55:10 +09:00
f08e7828da Merge branch 'master' into beatmap-track-rework 2020-09-01 16:06:38 +09:00
dd093f44d8 Cast base immutable bindable to mutable for testing purposes and make InitialOverlayActivationMode property protected 2020-08-31 11:26:55 +02:00
a171d0e292 Remove unused methods and classes 2020-08-31 18:14:22 +09:00
3b03116179 Remove unnecessary using statement 2020-08-21 16:45:59 +09:00
f7e4feee34 Update remaining Player components to use WorkingBeatmap again 2020-08-21 15:25:57 +09:00
357fb3a10e Merge branch 'master' into beatmap-track-rework 2020-08-21 12:53:09 +09:00
5714c761eb Merge pull request #9768 from frenzibyte/allow-counter-customize-sprite-text
Allow providing custom sprite text for RollingCounter<T>
2020-08-20 00:14:48 +09:00
8f1a71c6b1 Remove counter sprite attributes for not being of any reasonable use 2020-08-19 07:44:45 +03:00
93a8bc3d5a Remove local reset method in GameplayClockContainer 2020-08-17 22:36:09 +09:00
d9debef156 Add explicit LoadTrack method 2020-08-17 15:38:16 +09:00
589d4eeb52 Remove setting. 2020-08-16 17:18:40 +02:00
71f4e753f0 Merge branch 'master' into beatmap-track-rework 2020-08-16 22:35:32 +09:00
a426ff1d5b Refactor gameplay menu overlay to fix regression 2020-08-15 14:18:50 +02:00
e465afa280 Merge branch 'master' into beatmap-track-rework 2020-08-14 20:02:43 +09:00
b7ae70ff96 Merge branch 'master' into fix-skinnable-sound-mute 2020-08-14 19:01:32 +09:00
84cb36b6a8 Defer subscriptions for updateOverlayActivationMode() to OnEntering() 2020-08-13 10:57:18 +02:00
99bea6b8e9 Add missing null check (player construction is potentially delayed now) 2020-08-13 12:52:35 +09:00
27cd9e119a Delay beatmap load until after transition has finished
Previously the beatmap would begin loading at the same time the
`PlayerLoader` class was. This can cause a horribly visible series of
stutters, especially when a storyboard is involved.

Obviously we should be aiming to reduce the stutters via changes to the
beatmap load process (such as incremental storyboard loading,
`DrawableHitObject` pooling, etc.) but this improves user experience
tenfold in the mean time.
2020-08-13 12:04:32 +09:00
c0031955c9 Update with further framework changes 2020-08-12 01:50:18 +09:00
e47a1eb313 Use adjustable ITrack 2020-08-12 01:41:21 +09:00
eec94e1f53 Make track not-null in GameplayClockContainer/FailAnimation 2020-08-12 00:51:43 +09:00
c66a14e9c5 Remove beatmap from FailAnimation 2020-08-11 12:37:48 +09:00
f74e162bbc Fix overlay activation mode being updated when player is not current screen. 2020-08-10 20:27:42 +02:00
052bb06c91 Add ability to open overlays during gameplay breaks. 2020-08-10 20:13:50 +02:00
365aae799e Merge branch 'master' into fix-skinnable-sound-mute 2020-08-10 23:55:51 +09:00
9a09f97478 Extract constant to avoid double initial value spec 2020-08-08 21:21:30 +02:00
e3105fd4c8 Add more resilient logic for whether to avoid playing SkinnableSound on no volume 2020-08-06 19:16:26 +09:00
2e3ecf71c7 Pass track from Player to components 2020-08-06 18:31:08 +09:00
5c05fe3988 Expose track from MusicController 2020-08-06 16:24:14 +09:00
6e42b8219c Move track to MusicController, compiles 2020-08-06 16:24:14 +09:00
9a00ad48c6 Update components to use extension methods 2020-08-06 14:43:39 +09:00
71895964f4 Refactor overlay activation logic and reword tip. 2020-08-05 11:21:09 +02:00
30c7a6f6a7 Fix CI issue and use method instead of triggering change on bindable. 2020-08-03 21:33:18 +02:00
242a035f7e Apply review suggestions. 2020-08-03 21:25:45 +02:00
25ebb8619d Add tests. 2020-08-03 16:04:11 +02:00
fe97d472df Enable back overlays when a replay is loaded. 2020-08-02 21:53:13 +02:00
f1ba576438 Disable overlay activation when in gameplay. 2020-08-02 21:34:35 +02:00
e795b1ea31 Failing effect displays vertically 2020-07-28 00:42:48 -07:00
ee05d5cb14 Remove no-longer-necessary play trigger on skin change 2020-07-23 09:06:15 +09:00
a39c4236c7 Fix multiple issues and standardise transforms 2020-07-17 19:08:50 +09:00
aa992f2e34 Merge branch 'master' into Issue#9170 2020-07-17 18:29:40 +09:00
ecbd8067e9 Add ability to seek replays/auto with arrow keys 2020-07-14 20:18:47 -07:00