3e366b1f15
Ensure the main realm context is closed when the factory is disposed
2021-01-15 14:26:06 +09:00
693602513e
Update test to use GetForWrite
2021-01-15 14:22:48 +09:00
2988700bea
Merge branch 'master' into realm-key-binding-store
2021-01-14 16:37:09 +09:00
f26c6210f3
Remove unnecessary Take() call and refactor default group logic naming
2021-01-14 16:36:24 +09:00
fd582f521c
Reduce lifetime of realm context usage in detach scenario
2021-01-14 16:33:55 +09:00
8d071f97fb
Early return
2021-01-14 16:33:03 +09:00
df08d964a5
Mark the types which have been migrated in OsuDbContext
2021-01-14 16:31:18 +09:00
e3c5a909e4
Fix known non-null variable
2021-01-14 16:30:57 +09:00
8a08d3f4ef
Fix transactions not actually being committed
2021-01-14 16:13:10 +09:00
af1509d892
Remove unused variable (but add back pending writes counter)
2021-01-14 15:51:19 +09:00
4759797d15
Update framework
2021-01-14 15:51:07 +09:00
6eca8eac65
Merge pull request #11479 from smoogipoo/fix-judgement-1-frame-issue
...
Fix default judgement text mispositioned for one frame
2021-01-14 13:14:50 +09:00
d5878db615
Fix default judgement text mispositioned for one frame
2021-01-14 12:33:33 +09:00
98858d2a9a
Merge pull request #11476 from bdach/revert-low-ar-buff
...
Revert overlooked AR<8 speed buff
2021-01-14 11:13:37 +09:00
398f8762b1
Merge pull request #11474 from frenzibyte/rename-downloaded-state
...
Rename download state `Downloaded` to `Importing`
2021-01-13 20:31:03 +01:00
1ba586a683
Revert overlooked AR<8 speed buff
...
Pull request #11107 introduced changes in osu! performance calculation,
related to a scaling coefficient applied to the speed and aim skills.
The coefficient in question was dependent on the approach rate of
a map. During a post-merge review of that PR, it was spotted that
the scaling coefficient for speed also had a 10x buff applied for AR<8,
which could reach magnitudes as large as 80% on AR0, which seems quite
exorbitant. This change was not discussed or mentioned anywhere in the
review process.
Revert back to the old multiplier of 0.01 rather than 0.1 for AR<8. The
negative slope through AR0 to 8 is retained in its previous form.
2021-01-13 17:59:29 +01:00
1f12b2bd09
Rename download state Downloaded to Importing
2021-01-13 18:04:53 +03:00
674e78fd93
Fix broken xmldoc
2021-01-13 18:38:30 +09:00
9bf9a8c351
Remove Live<> wrapper until it is needed
2021-01-13 18:36:37 +09:00
8442b34e84
Tidy up write usage class
2021-01-13 18:36:37 +09:00
5fa3a22f28
Remove unused RealmBackedStore base class
2021-01-13 18:36:37 +09:00
fcb4a53f37
Rename realm persisted properties to avoid casting necessity
2021-01-13 18:36:37 +09:00
9086d75542
Update write usages
2021-01-13 18:36:37 +09:00
9d744d629f
Update existing usages to use the main realm context where applicable
2021-01-13 18:36:37 +09:00
542f535247
Pull out thread local contexts and have main realm refresh in update loop
2021-01-13 18:36:37 +09:00
78707c3b06
Remove unused event
2021-01-13 18:36:37 +09:00
192e58e0c6
Update all read queries to use direct realm subscriptions/queries
2021-01-13 18:36:37 +09:00
10fd4cf7c9
Merge pull request #11467 from bdach/fix-multiplayer-non-host-crash
...
Fix non-hosts crashing on load requested
2021-01-13 11:38:59 +09:00
2d3cacca11
Fix non-hosts crashing on load requested
...
`onLoadRequested()` always released the `readyClickOperation` ongoing
operation, without checking whether it actually needs to/should (it
should only do so if the action initiating the operation was starting
the game by the host). This would crash all other consumers, who already
released the operation when their ready-up operation completed server
side.
To resolve, relax the constraint such that the operation can be ended
multiple times in any order. At the end of the day the thing that
matters is that the operation is done and the ready button is unblocked.
2021-01-13 00:58:53 +01:00
becd52b5d2
Merge pull request #11465 from smoogipoo/fix-taiko-conversion-2
2021-01-12 20:43:37 +01:00
9a22df2b88
Fix BPM multiplier not working in all cases
2021-01-12 17:50:22 +09:00
22a0f99f35
Add failing test
2021-01-12 17:49:21 +09:00
765d9cfae1
Use direct access for query pattern
2021-01-12 17:01:40 +09:00
46a1d99c74
Allow detach to be run against an IQueryable directly
2021-01-12 17:01:16 +09:00
f0a9688baa
Remove unnecessary mapped type
2021-01-12 15:50:09 +09:00
7769d95e7b
Add xmldoc for extension methods
2021-01-12 15:48:26 +09:00
9a5410e5d2
Add basic test coverage
2021-01-12 15:21:02 +09:00
a6997a6fc6
Move ruleset key binding registration to an explicit method rather than the constructor
2021-01-12 15:21:02 +09:00
ff16d2f490
Mark classes nullable
2021-01-12 15:21:02 +09:00
2e4c3c8e39
Avoid closing initial context after migrations (unnecessary)
2021-01-12 14:45:36 +09:00
0dca9c8c46
Tidy up RealmContextFactory; remove delete/dispose method which wouldn't work due to threading
2021-01-12 14:45:36 +09:00
8cbad1dc1c
Add logging of opened and created contexts
2021-01-12 14:45:36 +09:00
ffb42c37df
Move schema version to const
2021-01-12 14:45:36 +09:00
0789621b85
Elaborate on comment mentioning migrations
2021-01-12 14:45:36 +09:00
8f9b19a76e
Detach at point of usage, rather than point of retrieval
2021-01-12 14:45:36 +09:00
536e7229d0
Remove unused EF class and unnecessary interface
2021-01-12 14:45:36 +09:00
fc55d67c66
Add helper method for detaching lists from realm
2021-01-12 14:45:36 +09:00
d810af82ec
Expose Live.Detach() method for ease of use
2021-01-12 14:45:36 +09:00
dd50b5870e
Move extensions methods into own class
2021-01-12 14:45:36 +09:00
6736db327a
Remove scheduler being passed in for now
2021-01-12 14:45:36 +09:00
