40d1b97af1
Avoid attempting to fetch a non-managed RealmLive instance from the realm backing
...
For compatibility reasons, we quite often convert completely unmanaged
instances to `ILive`s so they fit the required parameters of a property
or method call. This ensures such cases will not cause any issues when
trying to interact with the underlying data.
Originally I had this allowing write operations, but that seems a bit
unsafe (when performing a write one would assume that the underlying
data is being persisted, whereas in this case it is not). We can change
this if the requirements change in the future, but I think throwing is
the safest bet for now.
2021-11-26 15:06:14 +09:00
3bc8f21935
Merge pull request #15810 from peppy/fix-incorrect-await
...
Fix incorrect `ConfigureAwait` specification causing test stalls
2021-11-26 13:19:07 +09:00
1d96542a2a
Fix incorrect ConfigureAwait specification causing stalled test
...
This only occurs on upcoming changes I have (occurred when switching
existing skin import tests across to realm). Unsure why it was set to
`true`, seems like a weird oversight.
2021-11-26 12:47:43 +09:00
7a3c69544b
Merge pull request #15799 from smoogipoo/fix-songselect-test-failures-2
...
Fix SongSelect-related test failures
2021-11-25 23:01:06 +09:00
837eaebdc6
Merge pull request #15800 from smoogipoo/fix-beatmap-thumbnail-test
...
Fix intermittent beatmap thumbnail test
2021-11-25 23:00:26 +09:00
d0c0b7ce47
Fix intermittent beatmap thumbnail test
2021-11-25 22:05:39 +09:00
09dd054283
Fix SongSelect-related test failures
2021-11-25 21:11:13 +09:00
f712aeee01
Merge pull request #15795 from peppy/realm-integration/separate-download-flow
...
Split out download logic from main manager classes
2021-11-25 20:59:23 +09:00
d7a960212f
Merge pull request #15794 from peppy/realm-integration/stable-export-flow
...
Split out legacy model export logic into `LegacyModelExporter` classes
2021-11-25 20:20:18 +09:00
8baf00c023
Remove unused using
2021-11-25 19:36:06 +09:00
2b85738384
Merge pull request #15797 from peppy/remove-pointless-i-beatmap-model-manager
...
Remove pointless interface class for `IBeatmapModelManager`
2021-11-25 19:07:19 +09:00
d3a4890c31
Merge branch 'master' into realm-integration/stable-export-flow
2021-11-25 19:06:18 +09:00
57cbce8f22
Merge pull request #15792 from peppy/realm-integration/stable-import-flow
...
Move stable import handling out of `IModelManager<T>` into its own class
2021-11-25 19:06:02 +09:00
e2ebcf7a26
Remove unnecessary manager parameter
...
Confused why I added this in the first place..
2021-11-25 18:36:03 +09:00
a6ee0eec0d
Remove pointless interface class for IBeatmapModelManager
...
Was originally going to be used but serves no purpose any more.
2021-11-25 18:15:10 +09:00
eeccf836ec
Remove unnecessary GameHost parameter
2021-11-25 17:42:41 +09:00
a2ab9f457d
Move score download logic out of ScoreManager
2021-11-25 17:33:04 +09:00
716543b5b3
Move beatmap download logic out of BeatmapManager
2021-11-25 17:29:41 +09:00
79459c1aeb
Fix typo in class and variable names
2021-11-25 17:12:15 +09:00
a0cc7bbdc8
Merge pull request #15793 from peppy/fix-beatmap-carousel-test-oversight
...
Fix occasional test failure due to default value oversight in `TestSceneBeatmapCarousel`
2021-11-25 17:10:57 +09:00
ec9a09d5a4
Add missing licence headers
2021-11-25 16:56:19 +09:00
cc1b91e4bd
Split out legacy model export logic into LegacyModelExporter classes
2021-11-25 16:41:12 +09:00
7488ccd5fe
Update all models to implement IHasNamedFiles
2021-11-25 16:41:12 +09:00
6d60725b31
Merge branch 'master' into realm-integration/stable-import-flow
2021-11-25 16:36:02 +09:00
416ee2447a
Move archive filename helper method to extension method
2021-11-25 16:35:54 +09:00
d8a23aad4d
Merge pull request #15791 from peppy/realm-integration/skin-model-manager
...
Split out `SkinModelManager` from `SkinManager`
2021-11-25 16:35:05 +09:00
a0fa030f55
Rename base class to LegacyModelImporter
2021-11-25 16:33:04 +09:00
e6cfe44652
Fix occasional test failure due to default value oversight in TestSceneBeatmapCarousel
2021-11-25 16:29:06 +09:00
210dfab392
Merge pull request #15790 from peppy/realm-integration/score-manager-interface-reduction
...
Reduce interface exposure of `ScoreManager`
2021-11-25 15:46:38 +09:00
2df793ca22
Inline individual importers to avoid unnecessary construction for singular import types
2021-11-25 15:44:04 +09:00
9dcb20a821
Rename Stable to Legacy and add xmldoc
2021-11-25 15:39:05 +09:00
6cab7b877d
Move stable import handling into its own class
2021-11-25 15:36:58 +09:00
2bfc473689
Split out SkinModelManager from SkinManager
2021-11-25 15:14:43 +09:00
546785b905
Merge pull request #15789 from peppy/realm-integration/file-store
...
Add automatic clean-up call for `RealmFileStore`
2021-11-25 15:10:41 +09:00
60b207f20a
Reduce interface exposure of ScoreManager
2021-11-25 14:34:13 +09:00
bcdb73e1e8
Clean up files last
2021-11-25 14:28:27 +09:00
315e126497
Add automatic clean-up call for RealmFileStore
2021-11-25 14:17:44 +09:00
204bd2b604
Ensure Cleanup can run from non-update thread and add basic log output
2021-11-25 14:17:44 +09:00
fd321109da
Remove unnecessary virtual specification on Refresh
2021-11-25 14:06:12 +09:00
306e13fa7b
Remove all usages of FileStore.QueryFiles
2021-11-25 14:06:02 +09:00
1533e245de
Merge pull request #15767 from bdach/beatmap-card/track-preview
...
Add preview track playback function to beatmap card
2021-11-25 12:08:03 +09:00
53dea8c606
Merge pull request #15784 from smoogipoo/fix-mp-resuming
...
Fix multiplayer starting with own latest picked playlist item rather than the current playlist item
2021-11-24 20:45:44 +01:00
1907b42f82
Use constant online IDs in tests to avoid preview not working randomly
2021-11-24 20:34:33 +01:00
20f71da2c4
Merge branch 'master' into fix-mp-resuming
2021-11-24 20:17:58 +01:00
1865227e08
Merge pull request #15773 from peppy/remove-model-file-list-inits
...
Initialise `IHasFiles<TFile>.Files` lists at construction time
2021-11-24 21:05:36 +09:00
016684b52d
Remove unreachable code
2021-11-24 20:29:47 +09:00
593f11d0ff
Merge pull request #15782 from peppy/realm-beatmap-set-status
...
Add online status to `RealmBeatmapSet`
2021-11-24 20:28:45 +09:00
132bb59203
Update working beatmap when returning to match
2021-11-24 19:56:02 +09:00
b7308283e4
Merge branch 'master' into realm-beatmap-set-status
2021-11-24 19:47:10 +09:00
ce8500a732
Merge branch 'master' into remove-model-file-list-inits
2021-11-24 19:46:42 +09:00
