Commit Graph

47140 Commits

Author SHA1 Message Date
419fee1380 Move mapper link to bottom content 2021-12-08 22:54:11 +01:00
61e04f75cc Resize extra card to design size 2021-12-08 22:54:10 +01:00
a32492cdd5 Duplicate BeatmapCard{-> Extra} as blueprint for extra card size 2021-12-08 22:53:51 +01:00
69fc7782ec Merge pull request #15682 from peppy/primary-key-consistency
Add `IsManaged` helper method to EF classes to match realm implementation
2021-12-08 19:17:39 +01:00
8d9c37a825 Merge branch 'master' into primary-key-consistency 2021-12-08 21:34:38 +09:00
b1d78c4284 Merge pull request #16005 from Susko3/add-ime-sounds
Add sounds for IME composition
2021-12-08 19:02:02 +09:00
8fa73fcbf6 Move helper method to end of class 2021-12-08 18:30:08 +09:00
de89e321c8 Add sounds for IME composition 2021-12-08 09:57:53 +01:00
af1e97b7c7 Move playing text added samples to private helper and fix it never playing the last sample
`RNG.Next` is exclusive of the upper bound, meaning that the last sample would never be played.
2021-12-08 09:49:36 +01:00
f2318d7e26 Merge pull request #15992 from frenzibyte/ios-high-frame-rate
Disable minimum frame durations on osu! for iOS
2021-12-08 16:36:15 +09:00
65a09692da Merge pull request #16001 from peppy/fix-own-rank-results-panel-in-multiplayer
Fix the local user's rank not showing on multiplayer/playlist results screen
2021-12-08 16:34:36 +09:00
9e3a1c75d2 Merge pull request #16000 from peppy/fix-legacy-combo-counter-anchor
Fix `LegacyComboCounter` not handling non-default anchor/origin specifications correctly
2021-12-08 16:00:06 +09:00
872e0884c0 Fix the local user's rank not showing on multiplayer/playlist results screen
Applying the simple solution for now. Not sure how this will evolve over
time, but seems sane enough.
2021-12-08 15:22:10 +09:00
6ec3f41839 Fix LegacyComboCounter not handling non-default anchor/origin specifications correctly 2021-12-08 15:07:15 +09:00
724d72b975 Merge pull request #15988 from bdach/fix-team-versus-test-failure
Fix test failures in team versus test
2021-12-08 11:54:00 +09:00
2e640ff2ad Merge pull request #15989 from bdach/fix-editor-clipboard-test-failure
Fix editor crashing if paste is performed while composer is loading
2021-12-08 11:18:59 +09:00
f86931b66f Merge pull request #15978 from peppy/beatmap-card/scale-on-hover
Scale card when expanding to better distinguish hovered card from other cards in listing
2021-12-08 11:18:07 +09:00
fea3b9d7a9 Disable minimum frame durations on osu! for iOS 2021-12-08 04:43:02 +03:00
7720a1b69b Fix test to wait for drawable ruleset load before attempting paste 2021-12-07 21:10:45 +01:00
10dd64e07c Fix being able to paste objects while composer is loading
Would lead to exceptions due to modification of `Beatmap.HitObjects`
during its enumeration by `DrawableRuleset`, which was happening as an
async load via `EditorScreenWithTimeline.CreateMainContent()`.
2021-12-07 21:00:25 +01:00
e9694dc74e Wait for match type changes in team versus test 2021-12-07 20:40:10 +01:00
8b7ed759e3 Merge branch 'master' into beatmap-card/scale-on-hover 2021-12-07 19:11:01 +01:00
74db8da11b Merge pull request #15758 from GoldenMine0502/speedbug
Make speed skill consider only the shortest movement distance
2021-12-08 01:31:07 +09:00
86eacfdbd8 Merge pull request #15879 from peppy/multiplayer-delayed-playlist-load-broken
Load playlist panels on demand to reduce initial load time when joining a room
2021-12-08 00:42:20 +09:00
25a0505c97 Scale card when expanding to better distinguish hovered card from other cards in listing 2021-12-07 23:48:14 +09:00
bcda777071 Merge branch 'master' into speedbug 2021-12-07 23:43:17 +09:00
d6e68feadc Merge pull request #15948 from bdach/beatmap-card/difficulty-dropdown
Add difficulty dropdown to beatmap card
2021-12-07 23:40:06 +09:00
7e236c3a41 Remove unused dependency 2021-12-07 23:36:48 +09:00
52230a6f00 Merge branch 'master' into multiplayer-delayed-playlist-load-broken 2021-12-07 22:45:05 +09:00
a8c20368c0 Merge pull request #15976 from smoogipoo/add-modes-to-room-panels
Add match type and queue mode to multiplayer room panels
2021-12-07 22:08:30 +09:00
4683193f09 Move implementation to base class 2021-12-07 20:36:39 +09:00
4078372480 Merge pull request #15975 from peppy/update-framework
Update framework
2021-12-07 19:23:16 +09:00
5ffe702dd6 Add match type and queue mode to multiplayer room panels 2021-12-07 18:57:13 +09:00
9978caab12 Update framework 2021-12-07 18:37:30 +09:00
08dac3fcda Merge pull request #15974 from peppy/fix-participant-list-state-desync
Fix multiplayer user panels potentially getting out of sync with player's state
2021-12-07 18:01:11 +09:00
dea7f2308c Fix participant panels potentially keeping a reference to an old user
If a user leave and then rejoins a multiplayer match while another user
is not at the lobby screen, there is a potential the `ParticipantPanel`
tracking the user will not correctly be recreated to reference the new
instance of the `MultiplayerUser`.

This happens because the `OnRoomUpdated` call is scheduled, which means
it is not running in the background, coupled with the local logic that
relies on `IEquatable(MultiplayerRoomUser)` (which in turn falls back to
a UserID comparison).

Changing this to a reference comparison is the easiest way to resolve
this. Whether we change the `IEquatable` implementation is up for
discussion.

Closes https://github.com/ppy/osu/issues/15970.
2021-12-07 17:24:04 +09:00
9f77529e35 Merge pull request #15972 from peppy/cancellation-woes
Fix `GetPlayableBeatmap` timeout not being applied when no `CancellationToken` is provided to difficulty calculations
2021-12-07 14:31:56 +09:00
cfa712473d Use default timeout in GetPlayableBeatmap when provided CancellationToken is default 2021-12-07 13:33:41 +09:00
f3e9fb76fc Add the ability to pass a CancellationToken through DifficultyCalculator.CalculateAll
Was weirdly missing from this one method.
2021-12-07 13:32:47 +09:00
a62beb3c59 Merge pull request #15968 from frenzibyte/move-log-to-network
Move API request response size log to correct logging target
2021-12-07 10:32:53 +09:00
974987550f Move API request response size log to correct logging target 2021-12-07 04:01:56 +03:00
8dc76964a3 Merge pull request #15959 from bdach/fix-skins-resetting
Fix skin setting resetting every launch
2021-12-07 09:34:17 +09:00
999bba439f Clarify usages of reverse child ID flow with inline comments 2021-12-06 21:02:40 +01:00
82ed8eae6b Ensure hover handling container always calls base on hover events 2021-12-06 21:02:40 +01:00
ccfc361626 Apply naming suggestions 2021-12-06 21:02:38 +01:00
4278a320e4 Fix skin setting resetting every launch
The reason this was happening was an unfortunate oversight in the
migration logic. The code that was attempting to parse the skin settings
as `int` was firing regardless of whether a skin migration from EF to
realm had already occurred. If it had occurred, the skin setting would
contain a GUID rather than an integer, and therefore fail to parse, and
therefore implicitly fallback to a EF skin ID of 0 which would be the
default skin.

Fix by not running the setting migrating logic at all when there are no
EF skins to migrate.
2021-12-06 20:12:02 +01:00
79b8cb41f2 Merge pull request #15953 from smoogipoo/update-test-multiplayer-client
Update test multiplayer client implementation
2021-12-07 01:15:28 +09:00
d5cdb1bb87 Update test multiplayer client implementation 2021-12-07 00:01:07 +09:00
91ff20a610 Merge pull request #15952 from peppy/update-framework
Update framework
2021-12-06 23:37:12 +09:00
3e27859e4f Update framework 2021-12-06 22:47:07 +09:00