Commit Graph

38772 Commits

Author SHA1 Message Date
45c0b74151 Use LINQ select for data assigning for simplicity
To avoid having to read through all of frames and ensure nothing is failing there
2021-05-04 23:41:50 +03:00
4ceb9b1562 Avoid randomizing and overestimating logic with simple hardcoding
Not sure what was in my mind while I was pushing that..
2021-05-04 23:36:50 +03:00
e00af3e71d Add test coverage 2021-05-04 09:45:59 +03:00
943c497397 Return back removed using 2021-05-03 02:02:14 +03:00
b2130fc600 Fix replay frames sort instability 2021-05-03 01:58:44 +03:00
a8db63498a Merge pull request #12650 from frenzibyte/selection-box-use-aabb
Compute selection box area using the bounding box of the blueprints instead
2021-05-02 13:30:01 +09:00
2e24b69d62 Merge pull request #12617 from Joehuu/fix-pp-column-approved-maps
Fix approved maps not displaying pp column on score table
2021-05-02 13:27:39 +09:00
b83aa0bd76 Avoid LINQ in update 2021-05-02 06:21:14 +03:00
0aa17e7c95 Rewrite selection box computation logic with RectangleF's helper methods 2021-05-02 02:51:06 +03:00
07fe99025f Use bounding box of blueprint for computing selection box area 2021-05-02 02:36:40 +03:00
137be5dc97 Use equality operator instead of null coalescing
Co-Authored-By: Salman Ahmed <frenzibyte@gmail.com>
2021-05-01 14:14:07 -07:00
05e18e3ee3 Merge pull request #12558 from JustusFT/justusft/mania-color-snap
Add snap color option for osu!mania
2021-05-01 23:52:54 +09:00
a551958eeb Move caching of IBeatmap to base DrawableRuleset 2021-05-01 21:32:45 +09:00
db815f7930 Tidy up implementation in DrawableNote 2021-05-01 20:39:10 +09:00
0b06c5bcb1 Remove unneeded test data 2021-05-01 15:00:18 +08:00
0d077b7a5d Fix GetClosestBeatDivisor returning the wrong divisor 2021-05-01 14:13:42 +08:00
fdf8c12947 Replace BeatDivisorFinder with GetClosestBeatDivisor 2021-05-01 11:57:47 +08:00
ecb053b0de Merge branch 'master' of https://github.com/ppy/osu into justusft/mania-color-snap 2021-05-01 11:20:28 +08:00
cbc7753f23 Merge pull request #12564 from Joehuu/fix-beatmap-info-download-button-content-scaling
Fix beatmap info download button content not scaling on mouse down
2021-05-01 10:43:59 +09:00
bb6f28d76b Merge pull request #12632 from EVAST9919/barrel-roll 2021-04-30 23:03:56 +02:00
9cb55ca245 Merge branch 'master' into barrel-roll 2021-04-30 22:27:27 +02:00
0d1a89cb60 Merge pull request #12634 from peppy/remove-unused-triangles 2021-04-30 22:26:29 +02:00
eef135f8dc Merge branch 'master' into remove-unused-triangles 2021-04-30 21:51:23 +02:00
786ab163f6 Rename extension and move to bottom of file 2021-04-30 12:40:16 -07:00
34a8a75f07 Merge pull request #12588 from Naxesss/basic-compose-checks
Add unsnapped and concurrent object checks
2021-05-01 00:20:02 +09:00
e6eea73b8b Merge branch 'master' into basic-compose-checks 2021-04-30 23:41:46 +09:00
872c52b35f Merge pull request #12625 from peppy/simpler-editor-move-events
Refactor `SelectionBlueprint` and `MoveSelectionEvent` to work in screen-space coordinates
2021-04-30 19:37:31 +09:00
c303043841 Merge branch 'master' into simpler-editor-move-events 2021-04-30 18:55:39 +09:00
5285b71ecb Merge pull request #12596 from peppy/abstract-blueprint-handling
Make editor blueprint/selection components abstract
2021-04-30 18:55:20 +09:00
e4f895b490 Fix editor buttons inheriting from TriangleButton when they have no need to 2021-04-30 14:48:37 +09:00
e69ec91c07 Add xmldoc for CurrentRotation 2021-04-30 11:25:39 +09:00
3b2243fa24 Merge pull request #12610 from PercyDan54/export-precision-loss
Fix possible precision loss on exporting legacy replays
2021-04-30 11:19:27 +09:00
7bf3498e2a Calculate playfield scale locally 2021-04-30 02:49:19 +03:00
25e0fb1cf9 Refactor OsuModBarrelRoll to allow it's usage by other rulesets 2021-04-30 01:59:59 +03:00
9952a5bfdb Revert "Fix button being recreated on importing state"
This reverts commit c9967f7b74.
2021-04-29 14:24:29 -07:00
cfbf95b433 Add HasPerformancePoints extension method 2021-04-29 14:11:35 -07:00
e716162ac2 Fix formatting 2021-04-29 17:19:25 +08:00
9c62c90cfc Refactor SelectionBlueprint and MoveSelectionEvent to work in screen-space coordinates
Until now, the implementation of the overrides in `SelectionBlueprint`
have been confusing to the point where I would just implement by
trial-and-error (or copying from an existing implementation). This was
due to a combination of using "object" space coordinates
(ie. the thing the `Blueprint` is operating on) and screen-space coordinates.

This change switches all event related coordinates to screen-space,
which is how we already handle rotation/scale operations. With the
introduction of other editor types where the related objects are
drawables, this also makes a lot more sense.
2021-04-29 16:10:42 +09:00
5b009c21bb Merge branch 'master' into abstract-blueprint-handling 2021-04-29 16:10:22 +09:00
d845f82876 Merge remote-tracking branch 'upstream/dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson-5.0.5' 2021-04-29 14:22:39 +09:00
721e7f22da Merge remote-tracking branch 'upstream/dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.MessagePack-5.0.5' 2021-04-29 14:22:17 +09:00
73e029da13 Merge remote-tracking branch 'upstream/dependabot/nuget/Microsoft.AspNetCore.SignalR.Client-5.0.5' 2021-04-29 14:21:55 +09:00
f5435cd2d2 Merge remote-tracking branch 'upstream/dependabot/nuget/Humanizer-2.9.9' 2021-04-29 14:21:51 +09:00
20782e69b1 Merge remote-tracking branch 'upstream/dependabot/nuget/NUnit-3.13.2' 2021-04-29 14:21:46 +09:00
80fc7ae89d Merge remote-tracking branch 'upstream/dependabot/nuget/Sentry-3.3.4' 2021-04-29 14:20:38 +09:00
1b3b07d6a9 Bump NUnit from 3.13.1 to 3.13.2
Bumps [NUnit](https://github.com/nunit/nunit) from 3.13.1 to 3.13.2.
- [Release notes](https://github.com/nunit/nunit/releases)
- [Changelog](https://github.com/nunit/nunit/blob/v3.13.2/CHANGES.md)
- [Commits](https://github.com/nunit/nunit/compare/v3.13.1...v3.13.2)

Signed-off-by: dependabot[bot] <support@github.com>
2021-04-29 03:51:12 +00:00
1e7feff49d Bump Humanizer from 2.8.26 to 2.9.9
Bumps [Humanizer](https://github.com/Humanizr/Humanizer) from 2.8.26 to 2.9.9.
- [Release notes](https://github.com/Humanizr/Humanizer/releases)
- [Changelog](https://github.com/Humanizr/Humanizer/blob/main/release_notes.md)
- [Commits](https://github.com/Humanizr/Humanizer/compare/v2.8.26...v2.9.9)

Signed-off-by: dependabot[bot] <support@github.com>
2021-04-29 03:51:08 +00:00
5b071c68e7 Bump Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson
Bumps [Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson](https://github.com/dotnet/aspnetcore) from 5.0.4 to 5.0.5.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.4...v5.0.5)

Signed-off-by: dependabot[bot] <support@github.com>
2021-04-29 03:51:04 +00:00
437e9201ba Bump Microsoft.AspNetCore.SignalR.Protocols.MessagePack
Bumps [Microsoft.AspNetCore.SignalR.Protocols.MessagePack](https://github.com/dotnet/aspnetcore) from 5.0.4 to 5.0.5.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.4...v5.0.5)

Signed-off-by: dependabot[bot] <support@github.com>
2021-04-29 03:51:00 +00:00
6c51bf523c Bump SharpCompress from 0.28.1 to 0.28.2
Bumps [SharpCompress](https://github.com/adamhathcock/sharpcompress) from 0.28.1 to 0.28.2.
- [Release notes](https://github.com/adamhathcock/sharpcompress/releases)
- [Commits](https://github.com/adamhathcock/sharpcompress/compare/0.28.1...0.28.2)

Signed-off-by: dependabot[bot] <support@github.com>
2021-04-29 03:50:56 +00:00