51acf79935
Change test exposure to property instead of method
2022-01-30 02:29:51 +09:00
9861c50b33
Remove pointless tests that no longer show anything valid
2022-01-30 00:03:22 +09:00
a915b9cd30
Fix occasional failures in TestSceneDeleteLocalScore
2022-01-29 23:58:57 +09:00
6f54f8ad78
Add more safety around CancellationToken usage
2022-01-29 23:58:57 +09:00
d0b74a91fb
Fix edge cases with score drawable loading
2022-01-29 23:58:57 +09:00
0293d95f82
Simplify IsOnlineScope usage
2022-01-29 23:58:57 +09:00
daea13f491
Simplify flow of cancellation token
2022-01-29 23:58:57 +09:00
3d59bab7c6
Remove fetch callback logic completely
2022-01-29 23:58:57 +09:00
13f445ddd5
Move score update code into own method
2022-01-29 23:58:57 +09:00
c48e9f2bbd
Remove more unnecessary schedule/cancel logic
2022-01-29 23:58:57 +09:00
a700ad3849
Remove scoresLoadedOnce weirdness
2022-01-29 23:58:57 +09:00
661fec7c8a
Make score setter private
2022-01-29 23:58:57 +09:00
b85b2c01fb
Reorder based on accessibility and add regions
2022-01-29 23:58:57 +09:00
c548658662
Remove move unused pieces
2022-01-29 23:58:57 +09:00
17aa9f3040
Remove pointless level of schedule/cancel logic
2022-01-29 23:58:57 +09:00
64925b3fea
Remove unused Content override
2022-01-29 23:58:57 +09:00
b9dac6c3b2
Reorder and tidy up bindable flows
2022-01-29 23:58:57 +09:00
aee93934d5
Rename methods to make more sense (and always run through AddOnce)
2022-01-29 23:58:57 +09:00
c6d303a5b4
Add xmldoc to Leaderboard class
2022-01-29 23:58:57 +09:00
4132f67629
Merge pull request #16702 from peppy/fix-ef-migrations
...
Run EF migrations before migrating to realm
2022-01-29 15:40:26 +01:00
1a14ccc7ee
Run EF migrations before migrating to realm
...
Turns out that there are more than zero users that are upgrading from
old databases. I think we probably want to support this for now.
Tested against database in https://github.com/ppy/osu/discussions/16700
and one other I had locally, both work correctly.
2022-01-29 23:13:23 +09:00
d48fae1100
Revert "Remove all EF migrations"
...
This reverts commit bb5b9458e8
2022-01-29 23:13:23 +09:00
0fc29c0e08
Merge pull request #16697 from peppy/fix-score-import-wrong-ruleset
...
Fix `SongSelect` incorrectly exposing decoupled ruleset to child screens
2022-01-29 13:31:35 +01:00
e7823982d8
Fix ruleset value not being transferred when FinaliseSelection is not called
2022-01-29 18:44:48 +09:00
4c97ed676f
Fix score presentation tests not correctly entering song select before running
2022-01-29 14:46:24 +09:00
8883505eed
Merge pull request #16686 from peppy/fix-ar-on-old-maps
...
Fix approach rate not being transferred from OD on older beatmaps
2022-01-28 20:17:37 +09:00
261cc6d031
Merge pull request #16687 from peppy/update-framework
...
Update framework
2022-01-28 20:17:23 +09:00
bda3cdc9a7
Add tests
2022-01-28 19:29:30 +09:00
4f2e98f3ef
Merge pull request #16683 from peppy/no-scope-test-lenience
...
Increase lenience of alpha check in `TestSceneOsuModNoScope`
2022-01-28 19:13:00 +09:00
53ca597e2b
Update framework
2022-01-28 19:12:32 +09:00
142a67e163
Fix approach rate not being transferred from OD on older beatmaps
2022-01-28 18:53:28 +09:00
17f0d7897b
Increase lenience of alpha check in TestSceneOsuModNoScope
...
I believe the [test
failures](https://github.com/ppy/osu/runs/4977283066?check_suite_focus=true )
we're seeing here are due to the implementation of interpolation of the
alpha being frame dependent (in a way that doesn't interact well with
tests). The reason for never hitting the expected value is that the
beatmap ends, causing the cursor to become fully visible again.
It's probably already good-enough for most cases, so let's attempt to
silence these test failures by not checking so precisely for the alpha
value.
We're checking for either 1 or 0 so it's not too important how close it
is to either.
2022-01-28 18:36:00 +09:00
f021a274d2
Merge pull request #16681 from peppy/fix-delete-local-scores
...
Fix delete local scores via "Clear all scores" button crashing the game
2022-01-28 17:01:31 +09:00
bdc9ca40f2
Merge pull request #16676 from peppy/fix-editor-custom-ruleset
...
Fix editor crashing on custom rulesets due to `ChangeHandler` not being supported
2022-01-28 16:26:56 +09:00
c7f8528d63
Merge pull request #16673 from peppy/fix-polling-component-thread-safety
...
Fix occasional non-fatal errors from polling API requests incorrectly getting queued twice
2022-01-28 16:26:47 +09:00
b94984bd2d
Merge pull request #16678 from peppy/hold-for-menu-always-fade
...
Ensure hold for menu button fades out if the cursor is never moved
2022-01-28 15:55:41 +09:00
0d3ac4fd9c
Fix delete local scores crashing the game
2022-01-28 15:54:53 +09:00
2453bf5ed0
Add test coverage of the same thing but via "clear all scores" button
2022-01-28 15:54:53 +09:00
778eebc94d
Add test coverage of local score import and deletion
2022-01-28 15:50:36 +09:00
cb7ae413fe
Ensure test game is always active
2022-01-28 15:50:35 +09:00
0bba8a52c6
Merge pull request #16663 from bdach/beatmap-info-defaults
...
Change some beatmap info/metadata defaults in a backwards compatible manner
2022-01-28 15:41:20 +09:00
ea716194e9
Merge pull request #16677 from peppy/fix-incorrect-null-null-equality
...
Fix a couple of cases of incorrect equality checks in the case both values are null
2022-01-28 15:41:09 +09:00
32f9299fe0
Remove unused using
2022-01-28 15:26:29 +09:00
28c8e07e3f
Ensure hold for menu button fades out if the cursor is never moved
...
Closes https://github.com/ppy/osu/discussions/16669 .
2022-01-28 14:48:35 +09:00
f32d56e213
Bring HoldForMenuButton tests up-to-date in code quality
2022-01-28 14:48:17 +09:00
b7d8c9bf06
Fix a couple of cases of incorrect equality checks in the case both values are null
2022-01-28 14:29:56 +09:00
b3856c9005
Fix editor crashing on custom rulesets due to ChangeHandler not being supported
...
As per https://github.com/ppy/osu/discussions/16668 , even without proper
saving support some ruleset developers do want to work on the editor.
This brings things back into a workable state.
2022-01-28 14:03:31 +09:00
91be77ad3d
Fix null ref in ComposeScreen when ruleset doesn't provide a composer
2022-01-28 14:01:10 +09:00
c953a5d503
Ensure PollingComponent.Poll is always called from the update thread
...
Not strictly required since all `Poll` implementations are now
threadsafe, but extra safety is never a bad thing?
2022-01-28 13:44:11 +09:00
c44af4853d
Add thread safety to PollingComponent.Poll implementations
2022-01-28 13:43:53 +09:00
