Commit Graph

51474 Commits

Author SHA1 Message Date
2c8fcadb97 Merge pull request #17679 from peppy/ensure-intro-is-protected
Ensure intro beatmap has protected flag set
2022-04-06 19:06:41 +09:00
c42ef43faa Ensure intro beatmap has protected flag set
In cases this isn't set, the beatmap has likely entered a bad state.

Closes https://github.com/ppy/osu/issues/17659.
2022-04-06 16:46:53 +09:00
065bb60324 Remove unused using statements 2022-04-06 16:05:11 +09:00
c2b2d443ed Add more comprehensive assert output to try and discern CI issues 2022-04-06 15:31:12 +09:00
2b8a5833dd Fix back-to-front conditional check 2022-04-06 15:13:02 +09:00
d17890ca9a Replace a couple more local test beatmap cases which can instead use TestResources methods 2022-04-06 15:04:15 +09:00
552ec5282f Change WorkingBeatmap.GetVirtualTrack to use length provided by BeatmapInfo
A lot of tests are using test resources that populate the length field,
but do not populate hitobjects. The general expectation is that
components should be using the cached length in cases where hitobjects
are not relevant, but `GetVirtualTrack` was doing its own local
calculation.

This could cause tests to fail due to `MusicController` changing track
in the background.
2022-04-06 14:51:15 +09:00
220d7bc6db Fix dangerous realm operation in TestSceneMultiplayerMatchSongSelect
The import process was running on the async load thread, but then
accessed from the access thread later on. This seemed to somehow pass
fine in headless runs, but would fail on visual test execution
(specifically on `TestBeatmapConfirmed()`).
2022-04-06 14:01:41 +09:00
f795f77cf9 Add missing newline 2022-04-06 14:00:54 +09:00
a3695c7e97 Merge branch 'master' into fix-spectator-seeks 2022-04-06 12:58:43 +09:00
c540810943 Merge branch 'master' into fix-multiplayer-unobserved 2022-04-06 11:33:10 +09:00
01da3924cc Simplify IsCurrentScreen check to only apply to relevant call 2022-04-06 11:32:35 +09:00
2525ec0d18 Switch 24H toggle from UI settings to language settings 2022-04-05 17:07:58 -04:00
9d475f7b33 Add config in settings for forcing 24H time, determines default off CurrentCulture 2022-04-05 16:21:28 -04:00
9c91e6d8f5 Merge branch 'master' into mod-overlay/full-screen 2022-04-05 21:29:40 +02:00
74706f72e6 Add 12-hour display setting (TODO add toggle) 2022-04-05 15:10:55 -04:00
ac799aaf7a Add missing newline 2022-04-05 19:25:47 +09:00
32daf64a31 Use newly exposed framework helper function to find closest parent 2022-04-05 19:24:34 +09:00
631aa2a6ec Remove left padding to allow left-most column to exist further to the.. left 2022-04-05 18:44:25 +09:00
54715885af Adjust animation metrics slightly 2022-04-05 18:41:01 +09:00
7a1820e6bb Fix multiplier display resetting transformations 2022-04-05 18:40:48 +09:00
9fdeb20537 Animate individual ModColumns during togle of oerlay 2022-04-05 18:27:34 +09:00
901032bfa2 Animate multiplier display 2022-04-05 18:25:27 +09:00
6b0392f990 Merge pull request #17597 from peppy/skin-editor-import-at-cursor
Import new skin editor sprites to the cursor location
2022-04-05 18:09:00 +09:00
7623f3b90b Merge branch 'master' into skin-editor-import-at-cursor 2022-04-05 17:39:11 +09:00
2b59f76b2d Merge pull request #17596 from peppy/skin-editor-sprites
Allow importing sprites into a skin via drag-and-drop
2022-04-05 17:38:58 +09:00
497e5e3a36 Slightly adjust scroll handling and also apply to ModSettingsContainer 2022-04-05 17:19:33 +09:00
a408776734 Limit FillFlow of columns to applicable direction 2022-04-05 17:15:05 +09:00
388322cd61 Speed up customisation panel toggle a bit 2022-04-05 16:56:24 +09:00
58e9147b12 Simplify and better comment nested scroll conditionals 2022-04-05 16:48:25 +09:00
2ec15a1ebe Fix lookup through transformers 2022-04-05 16:47:15 +09:00
f156cb797d Improve nested scroll behaviour 2022-04-05 16:46:09 +09:00
23dad7bdc4 Move scroll view padding to content level
Without doing this, there is a non-masked but also non-interactive area
to the left or right of the view.
2022-04-05 16:43:00 +09:00
c973d33bfd Merge pull request #17604 from nekodex/mp-countdown-sfx
Add SFX for multiplayer lobby countdown timer
2022-04-05 16:40:26 +09:00
3d8ae0465f Reword comment slightly 2022-04-05 15:51:04 +09:00
8e543204cd Remove debounce logic (not required after switching to Update clock time) 2022-04-05 15:49:47 +09:00
5f415cbe53 Full potential null reference and add better commentary on countdown scheduling 2022-04-05 15:48:18 +09:00
55752c2693 Merge pull request #17650 from CenTdemeern1/dangerous-delete-actions
Make several delete confirmation buttons dangerous buttons
2022-04-05 14:14:00 +09:00
d0f83885ce Appease the CI 2022-04-05 13:20:34 +09:00
31bf0c4a9b Disable "final" sample in countdown for the time being 2022-04-05 13:16:06 +09:00
2d020e756d Merge pull request #17621 from frenzibyte/taiko-target-size
Adjust osu!taiko legacy hit target size to match osu!(stable)
2022-04-05 12:37:40 +09:00
b415308a4e Merge pull request #17619 from frenzibyte/taiko-hitobject-size
Adjust osu!taiko hit size and strong scale to exactly match osu!(stable)
2022-04-05 12:36:57 +09:00
174dc1641c Fix multiple issues with timekeeping
- Using realtime (`DateTimeOffset.Now`) meant that values would be
  changing in the same frame, causing misfirings or incorrect displays
- No debounce on sample playback meant that scheduling edge cases could
  potentially cause samples to be played more than once.
2022-04-05 11:49:58 +09:00
3ca365ad7f Merge branch 'master' into dangerous-delete-actions 2022-04-05 10:55:01 +09:00
fe44c5ee8e Merge pull request #17651 from bdach/delete-local-score-breakage
Fix various breakage in delete local score test scene
2022-04-05 10:54:48 +09:00
cbc5b405af Merge pull request #17653 from ajiiisai/footer-button-repeat
Handle repeated `OnPressed()` on `FooterButton` (without `FooterButtonRandom`)
2022-04-05 10:46:52 +09:00
117d81d84f Use perfect osu!(stable) strong scale value
Co-authored-by: Dean Herbert <pe@ppy.sh>
2022-04-05 03:04:53 +03:00
Ame
32c89f8643 Handle repeated OnPressed() on FooterButton (without FooterButtonRandom) 2022-04-05 00:33:41 +02:00
b2c822a3b1 Release mouse button 2022-04-04 23:02:07 +02:00
da315f8a61 Make the test hold the button instead of pressing it 2022-04-04 22:44:35 +02:00