Commit Graph

52754 Commits

Author SHA1 Message Date
545c04aaf5 Fix dangerous File.Copy causing intermittent realm migration test failures
Resolves an issue I've been able to locally reproduce on windows.
Basically, the `File.Copy` would begin while realm was blocking. The
"restore" operation is posted to the `SynchronizationContext` to run on
next update call, but in the mean time the copy would begin, causing a
conflict of interest.

Very dangerous. Only really noticeable on windows.
2022-06-24 16:18:56 +09:00
2f86ad88ae Merge pull request #18826 from frenzibyte/ignore-rule-typo 2022-06-24 11:03:45 +09:00
eaae600a49 Fix typo in auto-import ignore rule 2022-06-24 04:58:27 +03:00
730228ec2a Merge pull request #18818 from nekodex/rearrangeable-list-feedback
Add audio feedback for rearranging list items
2022-06-23 23:30:55 +09:00
55f1702448 Merge pull request #18820 from peppy/beatmap-difficulty-cache-cleanup
Enable NRT and tidy up `BeatmapDifficultyCache`
2022-06-23 23:23:17 +09:00
aaf619b35c Don't play sample if there is no item being actively dragged 2022-06-23 20:13:01 +09:00
9c46592e0e Move collection change event binding to LoadComplete 2022-06-23 20:04:54 +09:00
ef258122d2 Move GetDifficultyRating helper method to StarDifficulty 2022-06-23 19:51:58 +09:00
b068df2149 Enable NRT on BeatmapDiffiultyCache 2022-06-23 19:51:58 +09:00
32652ace75 Update resources 2022-06-23 19:51:44 +09:00
777ac98599 Merge pull request #18817 from peppy/remove-room-null-check-more
Remove remaining `Room != null` checks in `TestMultiplayerClient` where possible
2022-06-23 18:27:05 +09:00
4a316fad2f Add audio feedback for rearranging list items 2022-06-23 17:45:42 +09:00
158f0a1f23 Remove remaining Room!=null checks in TestMultiplayerClient where possible 2022-06-23 17:38:34 +09:00
9ed37621a7 Merge pull request #18816 from peppy/avoid-waiting-forever
Ban usage of `ManualResetEventSlim.Wait()` without a timeout value
2022-06-23 17:26:26 +09:00
ac91c9de7d Merge pull request #18815 from peppy/remove-room-null-check-change-state
Remove room null assertion in `TestMultiplayerClient.ChangeState` to avoid assert
2022-06-23 16:55:58 +09:00
51268d0cc8 Throw on Wait failure in a few remaining cases 2022-06-23 15:28:21 +09:00
7ef8b7df5f Add timeout for all ManualResetEventSlim.Wait invocations
Timeout values were taken as best-guesses of upper values we'd expect
from sane execution.
2022-06-23 14:46:00 +09:00
ed9c55a776 Ban usage of ManualResetEventSlim.Wait() without a timeout value 2022-06-23 14:45:58 +09:00
bc557bacf0 Remove room null assertion in TestMultiplayerClient.ChangeState to avoid assert
This method is run from async contexts, but `get_Room` asserts update
thread which is not the case. Was causing silent test failures (showing
as pass but failing `dotnet-test` via return code):

TestSceneMultiplayer.TestGameplayFlow

```
[13:13:17] :         [dotnet test] [runtime] 2022-06-22 13:13:16 [error]: Score preparation failed!
[13:13:17] :         [dotnet test] [runtime] 2022-06-22 13:13:16 [error]: NUnit.Framework.AssertionException: :
[13:13:17] :         [dotnet test] [runtime] 2022-06-22 13:13:16 [error]: at osu.Framework.Logging.ThrowingTraceListener.Fail(String message1, String message2)
[13:13:17] :         [dotnet test] [runtime] 2022-06-22 13:13:16 [error]: at System.Diagnostics.TraceInternal.Fail(String message, String detailMessage)
[13:13:17] :         [dotnet test] [runtime] 2022-06-22 13:13:16 [error]: at System.Diagnostics.TraceInternal.TraceProvider.Fail(String message, String detailMessage)
[13:13:17] :         [dotnet test] [runtime] 2022-06-22 13:13:16 [error]: at System.Diagnostics.Debug.Fail(String message, String detailMessage)
[13:13:17] :         [dotnet test] [runtime] 2022-06-22 13:13:16 [error]: at osu.Game.Online.Multiplayer.MultiplayerClient.get_Room() in /opt/buildagent/work/ecd860037212ac52/osu.Game/Online/Multiplayer/MultiplayerClient.cs:line 98
[13:13:17] :         [dotnet test] [runtime] 2022-06-22 13:13:16 [error]: at osu.Game.Tests.Visual.Multiplayer.TestMultiplayerClient.ChangeState(MultiplayerUserState newState) in /opt/buildagent/work/ecd860037212ac52/osu.Game/Tests/Visual/Multiplayer/TestMultiplayerClient.cs:line 275
[13:13:17] :         [dotnet test] [runtime] 2022-06-22 13:13:16 [error]: at osu.Game.Screens.OnlinePlay.Multiplayer.MultiplayerPlayer.PrepareScoreForResultsAsync(Score score) in /opt/buildagent/work/ecd860037212ac52/osu.Game/Screens/OnlinePlay/Multiplayer/MultiplayerPlayer.cs:line 223
[13:13:17] :         [dotnet test] [runtime] 2022-06-22 13:13:16 [error]: at osu.Game.Screens.Play.Player.prepareScoreForResults() in /opt/buildagent/work/ecd860037212ac52/osu.Game/Screens/Play/Player.cs:line 747
```
2022-06-23 14:10:20 +09:00
97fcf8cec9 Merge pull request #18668 from smoogipoo/editor-controlpoint-undo-redo 2022-06-23 04:02:24 +09:00
e467751c95 Merge pull request #18811 from peppy/fix-realm-migration-fuck
Fix collection modified during `BlockAllOperations` if any subscriptions have been established
2022-06-22 21:32:25 +09:00
948c28f415 Fix collection modified during BlockAllOperations if any subscriptions have been established 2022-06-22 20:34:05 +09:00
b660119de7 Merge pull request #18796 from bdach/mod-overlay/legacy-key-bindings
Add setting option to toggle between mod overlay hotkey styles
2022-06-22 20:28:18 +09:00
77023d8179 Merge pull request #18808 from nekodex/fix-metronome-flash
Fix metronome arm being stuck white when paused 'close enough' to center
2022-06-22 16:15:59 +09:00
950551f4fd Fix metronome arm being stuck white when paused 'close enough' to center 2022-06-22 15:33:42 +09:00
465329a9bb Merge pull request #18806 from peppy/discarded-parameter-hint
Change always-discarded-parameter inspection to hint
2022-06-22 15:08:40 +09:00
b81c7c7951 Merge pull request #18804 from Joehuu/online-view-chat-overlay
Add back online view container to chat overlay
2022-06-22 14:41:06 +09:00
f561d5b4ad Change always-discarded-parameter inspection to hint
See

f8830c6850/osu.Game/Rulesets/Scoring/ScoreProcessor.cs (L518)

Coming up as a suggestion (the only one in the solution).
2022-06-22 14:32:44 +09:00
92e55602f8 Merge pull request #18802 from Supersonicboss1/reorganised-maintenance-section
Added subheadings to maintenance section in settings
2022-06-22 14:30:17 +09:00
e15b2afdd9 Merge branch 'master' into reorganised-maintenance-section 2022-06-22 13:45:57 +09:00
ff440fc1a4 Fix too many buttons inside condition 2022-06-22 13:44:41 +09:00
321920bc85 Remove one more nullable disable 2022-06-22 13:44:41 +09:00
1018c9852d Cleanup nullability 2022-06-22 13:44:41 +09:00
23254d2ff2 Fix broken files 2022-06-22 13:44:41 +09:00
07e0cd53a4 Add back online view container to chat overlay 2022-06-21 19:23:16 -07:00
cf0f32f928 Merge pull request #18790 from peppy/fix-realm-async-write-blocking-overhead
Fix blocking overhead when calling `WriteAsync`
2022-06-22 09:39:17 +09:00
4aa86b0a80 fixed duplicates and cleaned up code 2022-06-21 23:41:25 +01:00
e4931f977c improved UI of maintenance section in settings 2022-06-21 23:00:03 +01:00
7013909322 Remove unnecessary protected virtual 2022-06-21 16:43:04 +02:00
f564ed589f Alter sequential hotkey style to always use visible index
Previous behaviour was once mentioned off-hand as unintuitive.
2022-06-21 15:22:18 +02:00
a9f6eb0293 Add test coverage for new intended behaviour of sequential hotkey style 2022-06-21 15:18:37 +02:00
9e5cc89edb Fix classic hotkeys toggling filtered mods 2022-06-21 15:01:33 +02:00
a996325e19 Add test coverage for filter handling in classic style 2022-06-21 15:00:39 +02:00
da1814e7c3 Restructure everything to fix free mod overlay issue 2022-06-21 14:48:41 +02:00
7b7b8c1892 Implement behaviour for classic selection style 2022-06-21 14:24:30 +02:00
234120ff43 Forward entire event to IModHotkeyHandler
Required for shift handling in the classic implementation.
2022-06-21 13:37:17 +02:00
143c8e8da6 Add test scene for desired classic selection behaviour 2022-06-21 13:35:00 +02:00
658f5341c7 Set up flow for switching between hotkey styles 2022-06-21 13:34:58 +02:00
5abd8a07d2 Add setting for changing mod select hotkey style 2022-06-21 13:33:17 +02:00
816fd338cb Fix typo 2022-06-21 19:57:27 +09:00