Commit Graph

54090 Commits

Author SHA1 Message Date
571a93e1bc Merge branch 'master' into more-until-steps 2022-08-03 21:25:30 +03:00
8489963abc Merge pull request #19548 from peppy/more-beat-sync-dependence
Improve `IBeatSyncProvider` interface and reduce beatmap track dependence
2022-08-03 20:54:57 +03:00
7c45c571a0 Merge branch 'master' into more-beat-sync-dependence 2022-08-03 20:22:42 +03:00
844430502b Replace parantheses with nullable-bool equality operation 2022-08-03 20:11:08 +03:00
1eb8168a8d Merge pull request #19522 from frenzibyte/improve-download-limit-message
Display readable error message when reaching download limit
2022-08-03 23:32:04 +09:00
7022d9e5f8 Fix test step names being too long 2022-08-03 21:13:49 +09:00
87cc2db624 Merge branch 'master' into improve-download-limit-message 2022-08-03 20:17:02 +09:00
d3954fc583 Use existing localised error message 2022-08-03 20:15:46 +09:00
a32149fda1 Convert interface methods to extension methods 2022-08-03 20:07:55 +09:00
24d84890e4 Change all filter control button state test to until steps
There's multiple schedules at play which could be adding multi-frame
delays. let's play it safe and try and fix flaky tests.

Example of `Schedule` which could cause an issue:
392cb352cc/osu.Game/Collections/CollectionDropdown.cs (L77-L78)

Example of test failure:
https://github.com/ppy/osu/runs/7648118894?check_suite_focus=true
2022-08-03 20:03:07 +09:00
b822a6de9e Merge pull request #19564 from peppy/fix-legacy-song-progress-mouse-blocking
Fix `LegacySongProgress` incorrectly blocking mouse input from gameplay
2022-08-03 18:51:59 +09:00
4063f92381 Merge branch 'master' into fix-legacy-song-progress-mouse-blocking 2022-08-03 12:12:58 +03:00
dbdfa90012 Merge pull request #19563 from peppy/realm-migration-safety
Change migration logic to ignore realm pipe files regardless of database filename
2022-08-03 12:11:50 +03:00
16ff8d5c38 Use different variable source 2022-08-03 17:47:32 +09:00
6ad6561e1c Fix LegacySongProgress incorrectly blocking mouse input from gameplay
Closes #19555.
2022-08-03 17:42:29 +09:00
f743dc623f Change migration logic to ignore realm pipe files regardless of database filename 2022-08-03 17:37:30 +09:00
258ad7c6b9 Tidy up kiai time access 2022-08-02 18:18:40 +09:00
cc4cde2c79 Improve IBeatSyncProvider interface and reduce beatmap track dependence 2022-08-02 17:59:18 +09:00
227906e30e Merge pull request #19543 from peppy/dont-clear-chat-overlay
Avoid clearing chat overlay textbox when pressing "back" key binding
2022-08-02 14:34:17 +09:00
34ffc51c51 Avoid clearing chat overlay textbox when pressing "back" key binding
Generally this is expected behaviour for usages of focused text boxes
(ie. to clear search content), but not so much here.

Addresses https://github.com/ppy/osu/discussions/19403#discussioncomment-3230395.
2022-08-02 13:56:03 +09:00
fc0914bf77 Merge pull request #19536 from frenzibyte/playlists-settings-leak
Fix playlist settings reference leak due to unsafe binding
2022-08-02 13:30:55 +09:00
4295dc3cb9 Merge pull request #19535 from naipofo/overlay-filter-rank
Hide F rank from the beatmap overlay
2022-08-02 13:06:27 +09:00
9a468f85f7 Merge pull request #19534 from andy840119/fix-up-remaining-issue-in-the-mods
Update nullability specifications in osu!catch and osu!taiko mods
2022-08-02 12:09:44 +09:00
5501195ed7 Merge pull request #19538 from bdach/mod-overlay/sheared-button-broken-autosize
Fix broken sheared button autosizing logic
2022-08-02 11:51:14 +09:00
eb73f9e88c Remove un-need using. 2022-08-02 10:23:52 +08:00
298efa5391 Fix broken ShearedButton autosizing logic 2022-08-01 22:04:16 +02:00
923d9a4e5f Add failing assertions to demonstrate autosize failure 2022-08-01 22:04:14 +02:00
3356909026 Merge branch 'master' into overlay-filter-rank 2022-08-01 21:54:44 +02:00
7354f9e6ba Remove localisation for now 2022-08-01 22:05:52 +03:00
c0e5f11c90 Merge pull request #19532 from frenzibyte/fix-new-items-sort-stability
Fix newly imported beatmaps not using correct comparer for sorting
2022-08-02 02:20:51 +09:00
7e9d11ee24 Enable NRT on playlists settings overlay 2022-08-01 20:15:08 +03:00
c851e3d8f3 Fix playlist settings reference leak due to unsafe callback binding 2022-08-01 20:08:18 +03:00
6686b09549 Hide F rank from beatmap overlay 2022-08-01 18:54:00 +02:00
b1d320bf67 Use non-nullable instead in the taiko ruleset. 2022-08-02 00:48:23 +08:00
1fe7e4d19a Use non-nullable instead in the catch ruleset. 2022-08-02 00:45:47 +08:00
fc7fc3d673 Fix newly imported beatmaps not using correct comparer for sorting 2022-08-01 19:13:57 +03:00
01cc9bd7ef Merge pull request #19479 from frenzibyte/carousel-update-on-resume
Fix song select not updating selected beatmap card on editor resume
2022-08-02 00:48:18 +09:00
682192dbd7 Add failing test case 2022-08-01 18:43:01 +03:00
c53a4f1c45 Merge pull request #16589 from mk56-spn/Wiggle-strength-duration
Add strength setting for wiggle mod
2022-08-02 00:03:53 +09:00
a5fac70c3b Rename variable to not include mode name itself 2022-08-01 23:30:00 +09:00
d09976bb39 Merge branch 'master' into Wiggle-strength-duration 2022-08-01 23:29:03 +09:00
49ee78babb Merge pull request #19500 from andy840119/remove-nullable-disable-in-the-audio-namespace
Remove nullable disable annotation in audio namespace
2022-08-01 15:59:19 +03:00
7c9f8648a5 Merge branch 'master' into remove-nullable-disable-in-the-audio-namespace 2022-08-01 15:25:12 +03:00
8ef777405d Merge pull request #19262 from goodtrailer/stable-slider-tick-anims
Imitate stable's slider followcircle tick-based behavior
2022-08-01 21:11:33 +09:00
03eccc2f7e Merge branch 'master' into stable-slider-tick-anims 2022-08-01 15:01:09 +03:00
6cccb6b848 Remove canBeNull: true. 2022-08-01 19:45:15 +08:00
3ff0327d91 Display readable message when reaching download limit 2022-08-01 14:22:54 +03:00
2465e8ed68 Merge pull request #19508 from gutyina70/fix-tags-overflow
Prevent tags overflowing on beatmap info overlay
2022-08-01 13:16:04 +03:00
2a127c6ef8 Merge branch 'master' into fix-tags-overflow 2022-08-01 12:40:43 +03:00
d4eec9122f Merge pull request #19516 from peppy/fix-editor-track-disposal-crash
Fix editor potentially playing a track post-disposal
2022-08-01 18:12:21 +09:00