Commit Graph

53995 Commits

Author SHA1 Message Date
59210ecc9d Revert "Fix migration failing on single file copy failure"
This reverts commit fc8835d43a.
2022-08-01 16:57:50 +09:00
fc8835d43a Fix migration failing on single file copy failure
No longer throw if copying of single files fails during data migration.

Aiming to fix https://github.com/ppy/osu/runs/7601653833?check_suite_focus=true, which could also affect end users. I've left a limit before an exception is still thrown, to handle cases like the user running out of disk space (where we probably *do* want to bail, so they can continue to use their still-intact original storage location).

If this isn't seen as a good direction, an alternative will be to make the migration code aware of the structure of the temporary files created by `Storage` (but doesn't guarantee this will cover all cases of such temporary files – there could for isntance be metadata files created by the host operating system).

Another option would be to mark those temporary files as hidden and skip any hidden files during iteration.
2022-08-01 15:02:39 +09:00
5335d60748 Merge pull request #19407 from andy840119/remove-nullable-disable-in-the-mods-for-osu-ruleset
Remove nullable disable annotation in mods for osu ruleset.
2022-08-01 14:51:48 +09:00
8ee4f1e60b Merge pull request #19510 from bdach/mod-overlay/presets-persistence
Add persistence of mod presets to realm
2022-08-01 14:43:52 +09:00
415d6def2d Remove unnecessary AsNonNull() 2022-08-01 13:22:58 +09:00
195396309a Merge pull request #19507 from naipofo/playlist-capture-fix
Prevent capturing arrow keys on playlist creation.
2022-08-01 11:46:00 +09:00
85f77abee1 Fix code quality inspection about ambiguous equality 2022-07-31 23:53:46 +02:00
5a34122a85 Fix test breakage after realm migration 2022-07-31 23:53:46 +02:00
9d3cdae4bb Fix test scene to handle restarts properly 2022-07-31 23:53:46 +02:00
9dea8e3d12 Add test coverage of preset soft deletion 2022-07-31 23:53:46 +02:00
c837848238 Add extended test coverage of preset realm subscription 2022-07-31 23:53:45 +02:00
345f103119 Migrate mod preset column to use realm 2022-07-31 23:53:45 +02:00
fa3b9ee32f remove unneded guard 2022-07-31 23:42:20 +02:00
cbabc4886c Convert ModPreset to realm object 2022-07-31 22:10:15 +02:00
57b43e0065 Stop capturing arrow keys on Playlist 2022-07-31 19:12:29 +02:00
632577389d Mark the property as non-nullable. 2022-07-31 21:43:16 +08:00
998e3b74d6 Merge pull request #19481 from peppy/fix-skin-migration
Fix previous skins not loading due to namespace changes
2022-07-30 21:56:28 +03:00
93b783d9ea Fix previous skins not loading due to namespace changes 2022-07-31 03:25:38 +09:00
498c796c81 Merge pull request #19478 from peppy/fix-collection-migration
Fix collection migration potentially deleting the database before finishing migration
2022-07-30 19:44:22 +03:00
6ad86ce5b7 Run collection import process asynchronously
Actually required to avoid deadlocking..
2022-07-31 01:06:57 +09:00
80ffa2cf20 Move collection database rather than deleting post-migration for safety 2022-07-31 00:54:00 +09:00
8e06d55960 Fix collection migration incorrectly running asynchronously 2022-07-31 00:53:39 +09:00
471a06883a Merge pull request #19471 from Susko3/desktop-BatteryInfo
Add battery info / low battery warning for desktop platforms
2022-07-30 18:15:51 +03:00
e5118130db Add 'SDL' acronym 2022-07-30 16:05:35 +02:00
38a8b9cf0a Add battery info for desktop platforms 2022-07-30 14:26:19 +02:00
43e612f6d4 Merge pull request #19455 from peppy/confirm-playlist-discard
Add confirmation dialog when about to discard a playlist
2022-07-30 19:17:49 +09:00
8ca8484f0e Fix failing tests 2022-07-30 11:49:33 +03:00
369ab10212 Fix exit confirmation dialog not blocking all exit cases 2022-07-30 11:00:31 +03:00
ecf7cc77dd Merge pull request #19469 from frenzibyte/fix-dodgy-tests
Fix potential nullref in `TestSceneAutoplay` check steps method
2022-07-30 16:46:51 +09:00
ec1a7994cc Switch method to statement body for better readability
Almost thought the method was not wrapped in an `AddStep`.
2022-07-30 10:11:01 +03:00
0c125db197 Fix potential nullref on TestSceneAutoplay check steps 2022-07-30 10:11:01 +03:00
d590219779 Merge pull request #19466 from naipofo/taiko-flashlight-fix
Fix osu!taiko flashlight positioned incorrectly on gameplay restart
2022-07-29 22:05:52 +03:00
1e90ea9e77 Merge branch 'master' into taiko-flashlight-fix 2022-07-29 21:32:35 +03:00
8d1f7970a3 Merge pull request #19465 from peppy/update-framework
Update framework
2022-07-29 21:32:25 +03:00
e0107fc3dc Use RequiredParentSizeToFit to handle misc geometry changes 2022-07-29 21:11:43 +03:00
4e32d510c3 Invalidate flashlightProperties on DrawInfo 2022-07-29 20:08:32 +02:00
eea211eb45 Update framework 2022-07-30 02:46:39 +09:00
f79d749fea Merge pull request #19457 from peppy/fix-summary-kiai-ranges
Fix editor summary timeline not responding to kiai changes correctly
2022-07-29 20:09:45 +03:00
2500e5c533 Merge branch 'master' into fix-summary-kiai-ranges 2022-07-29 19:38:28 +03:00
f07a416c4d Merge pull request #19408 from LeNitrous/pie-chart-progress
Add osu!stable style circular song progress for legacy skins
2022-07-29 17:27:45 +03:00
acf9ad1429 Apply nullability to EffectPointVisualisation 2022-07-29 23:26:38 +09:00
3bc1774c87 Merge branch 'master' into pie-chart-progress 2022-07-29 16:54:59 +03:00
3b1a76b190 Remove redundant/overwritten specifications 2022-07-29 16:45:29 +03:00
905bbdc8ee Remove caching of GameplayClockContainer in favour of GameplayClock
Also fixes `SongProgress` being displayed in skin editor on non-gameplay
screens, due to `GameplayClock` not marked as a required dependency.
2022-07-29 16:45:29 +03:00
3f72e76348 Expose StartTime from gameplay clock 2022-07-29 16:18:05 +03:00
8f1e3b0154 Fix editor summary timeline not responding to kiai changes correctly 2022-07-29 19:31:49 +09:00
6703b8df02 Merge pull request #19454 from peppy/filter-control-tests-realm-refresh
Ensure realm is in a good state before asserts in `TestSceneFilterControl`
2022-07-29 17:57:38 +09:00
70420e6238 Merge pull request #19440 from peppy/bypass-local-metadata-cache
Fix beatmap updater potentially using outdated local metadata
2022-07-29 17:33:53 +09:00
07e3765b34 Ensure collection is added to dropdown before trying to click it 2022-07-29 17:25:30 +09:00
0a2265b0e8 Add test coverage of playlist exit confirmation 2022-07-29 17:11:37 +09:00