9c3dad9fbf
Add proof of concept flow to ensure RealmBackedResourceStore is invalidated on realm file changes
...
I'm not at all happy with this, but it does work so let's go with it for
now.
2022-04-01 16:01:33 +09:00
66f5eae530
Hook up a dropdown to show all available sprites for the current skin
2022-04-01 15:01:43 +09:00
fca9faac9b
Add SkinnableSprite for arbitrary sprite additions
2022-04-01 14:36:36 +09:00
3a16483214
Add prioritised user lookups for default skin
...
This allows user resources to be consumed before falling back to the
game bundled assets.
2022-04-01 14:36:36 +09:00
01829cf2d8
Move SkinnableInfo error handling to lower level
...
Handling was recently added to handle the usage in
`Skin.GetDrawableCompoent`, but it turns out this is also required for
`DrawableExtensions.ApplySkinnableInfo` which can throw in a similar
fashion.
Found while working on sprite support for the editor, where this becomes
an actual issue (ie. switching to a branch where the new sprite support
is not present can cause unexpected crashes).
2022-04-01 14:30:04 +09:00
88306a6180
Disable ability to select random skin from within the skin editor
...
Reasoning is explained in inline comment.
I knowingly only applied this to the shortcut key. It's still feasible a
user can choose the option from the skin dropdown while the editor is
open, but that's less of an issue (because a user won't get the same
compulsion that I get to mash the key, only to be greeted with 100 new
mutable skins created).
2022-04-01 14:22:32 +09:00
69d4f86122
Fix automatically created "(modified)" skins getting conflicting names
...
Applies the already tested and proven method that is used in the editor
to the mutable skin creation flow.
2022-04-01 14:11:55 +09:00
0a86bf6fb1
Merge pull request #17588 from peppy/aim-assist-rename
...
Rename "Aim Assist" to "Magnetised" to better suit the mod's behaviour
2022-04-01 14:04:30 +09:00
4c8f427ad3
Merge pull request #17589 from peppy/tournament-scene-manager-key-bindings
...
Add ability to switch between most common tournament scenes using key bindings
2022-04-01 14:04:21 +09:00
6b9f5812a5
Merge pull request #17579 from CenTdemeern1/clock-button
...
Make the toolbar clock feel more like a button
2022-04-01 13:12:48 +09:00
10f15f2bdb
Merge pull request #17559 from bdach/mod-overlay/sheared-toggle
...
Implement sheared toggle button
2022-04-01 13:06:22 +09:00
de625125d6
Rename magnetised mod attraction strength property to match new naming
2022-04-01 13:03:48 +09:00
3bebc88306
Consider spinners when calculating jump angles
...
Spinners are considered in `GeneratePositionInfos`, so they should also be considered in `RepositionHitObjects`
2022-04-01 11:59:24 +08:00
ee65677884
Use height of playfield instead of width when randomizing the first object
...
This is the change discussed in #17194 . The effect of this change is barely noticeable, but it makes more sense to generate the object within playfield from the start.
2022-04-01 11:57:45 +08:00
031a977009
Calculate slider rotation using end point of path instead of EndPosition
2022-04-01 11:50:30 +08:00
0015f627b0
Add xmldoc
2022-04-01 11:49:27 +08:00
c0a78924aa
Fix generation for zero-length sliders
2022-04-01 11:47:21 +08:00
ea672745b0
Add ability to switch between most common tournament scenes using key bindings
2022-04-01 12:44:49 +09:00
af3835083c
Fix slider relative rotation calculation
2022-04-01 11:41:45 +08:00
998df5a4fe
Fix large slider clamping
2022-04-01 11:37:10 +08:00
cabbc486e9
Rotate sliders in random mod
2022-04-01 11:36:20 +08:00
a987cda30d
Rename "Aim Assist" to "Magnetised" to better suit the mod's behaviour
...
As proposed in https://github.com/ppy/osu/discussions/17375 .
2022-04-01 12:15:52 +09:00
338a21f4f0
Merge pull request #17581 from CenTdemeern1/remove-bpm-slider
...
Remove BPM slider
2022-04-01 11:59:16 +09:00
912b6ae8ff
Merge pull request #17194 from hlysine/extract-random-mod-logic-2
...
Extract the hit object positioning logic of random mod to a separate class
2022-04-01 11:28:53 +09:00
d0873d67e1
Move difficulty graph toggle to individual skin settings
2022-03-31 18:56:57 -07:00
058350dfd8
Fix failing test due to incorrect sizing specification
2022-04-01 10:53:16 +09:00
86d262a355
Merge branch 'ppy:master' into clock-button
2022-03-31 23:08:30 +02:00
d5b0c0ba8c
Merge pull request #17575 from peppy/runtime-clock-weight
...
Increase font weight for runtime clock
2022-03-31 22:30:08 +02:00
1c7b259f8e
Merge branch 'master' into mod-overlay/sheared-toggle
2022-03-31 22:20:20 +02:00
e180db145d
Add constructor argument to facilitate fixed width/autosizing
2022-03-31 22:19:08 +02:00
b3896257ca
Move shear amount to constant
2022-03-31 22:09:03 +02:00
48df34d0a8
Merge branch 'master' into runtime-clock-weight
2022-03-31 21:24:45 +02:00
e14d5b8adb
Remove unused using directives
2022-03-31 21:20:30 +02:00
a6875383fc
Rebind SaveState() to bpmTextEntry
2022-03-31 21:06:05 +02:00
bdb21b17f7
Fix my code according to the changes @bdach requested
2022-03-31 20:39:26 +02:00
52d723aaa6
Remove BPM slider
2022-03-31 20:11:07 +02:00
c64a90b39e
Remove a newline to comply with codefactor
2022-03-31 17:21:50 +02:00
f1aa60c0f1
Make the clock feel more like a button
2022-03-31 16:26:53 +02:00
0b6db31511
Guard other multiplayer client calls with exception handling
2022-03-31 19:45:38 +09:00
e0c125a628
Replace existing usage with helper method
2022-03-31 19:27:45 +09:00
5b3eb2d6f4
Add helper class to handle firing async multiplayer methods
2022-03-31 19:27:45 +09:00
46be6bcadc
Merge pull request #17574 from peppy/fix-tournament-bracket-invalid-ruleset-id
...
Fix tournament bracket parsing's ruleset refetch logic not working correctly
2022-03-31 19:18:18 +09:00
0a34ce2509
Increase font weight for runtime clock
...
Fonts this small are required to be `SemiBold` by design guidelines.
Somehow missed this.
2022-03-31 19:07:30 +09:00
a06b0a4966
Fix tournament bracket parsing's ruleset refetch logic not working correctly
...
Due to equality being based on `ShortName`, it was feasible that the
re-fetch exited early (in bindable shortcutting logic) causing the
ruleset's `OnlineID` to remain `-1` or something equally wrong.
Resolves issue pointed out at
https://github.com/ppy/osu/discussions/17538#discussioncomment-2471746 .
2022-03-31 18:41:00 +09:00
a7a7584d3e
Add test coverage ensuring ruleset ID is correct after bracket read
...
Historically, tournament client may have written incorrect `OnlineID`
values. We wanted to use `ShortName` to re-fetch the ruleset. This test
ensures this flow is working correctly.
2022-03-31 18:39:58 +09:00
bc4d6a3ace
Merge pull request #17570 from peppy/fix-settings-textbox-focus
...
Focus focus not being transferred correctly to parent settings panel on exiting nested panel
2022-03-31 18:07:51 +09:00
140eaa6039
Merge pull request #17572 from peppy/fix-multi-sounds-explosion
...
Fix multiplayer sounds playing too much after gameplay
2022-03-31 16:52:24 +09:00
ef5e37c47a
Fix multiplayer sounds playing too much after gameplay
...
Regressed in https://github.com/ppy/osu/pull/15936 .
Closes #17295 .
2022-03-31 16:18:28 +09:00
ad14b7cac5
Merge pull request #17565 from smoogipoo/fix-gameplay-leaderboard-allocations
...
Remove ScoreInfo allocations in multiplayer leaderboard
2022-03-31 15:48:14 +09:00
496e025fae
Merge pull request #17569 from Joehuu/ignore-line-ending-rev
...
Ignore line ending normalisation commit from blame
2022-03-31 15:31:53 +09:00
