Commit Graph

524 Commits

Author SHA1 Message Date
4314946e10 Reorganise functions to order more logically (hitcircle before slider methods) 2021-07-13 19:37:17 +09:00
6b663037e4 Use switch for pattern matching 2021-07-13 19:37:02 +09:00
db8ffc6316 Merge branch 'master' into osu-random-mod-improvements 2021-07-13 19:31:37 +09:00
63dedb36de Rename variable 2021-07-11 16:49:23 +02:00
7aecafeecb Rename constant to reflect its purpose 2021-07-11 16:46:30 +02:00
c181a724c6 Refactor hit object clamping 2021-07-11 22:01:28 +08:00
e10b7867c1 Rewrite method again to hopefully help readability 2021-07-10 12:13:36 +02:00
90326f8864 Standardise variables 2021-07-09 13:24:26 +09:00
88b00123f6 Use existing reflection methods to avoid manual binding of ExtendedLimits 2021-07-08 17:49:00 +09:00
bd7c334588 Avoid the need for per-settings control classes 2021-07-08 17:49:00 +09:00
a6e94dd491 Add back extended limits support 2021-07-08 17:49:00 +09:00
c4313d6e96 Initial implementation of new flow (only working for approach rate) 2021-07-08 17:48:08 +09:00
0e4f4a6fde Initial storage changes 2021-07-08 14:28:13 +09:00
e1c646b9b2 Remove redundant arguments 2021-07-05 23:52:39 +08:00
eecf4af029 Rename getSliderBoundingBox and add comments 2021-07-05 09:16:01 +08:00
c69455cfd0 Fixed slider bounding box calculation 2021-07-01 11:20:55 +08:00
7585f1f790 Move special case handling back to moveSliderIntoPlayfield 2021-07-01 11:03:22 +08:00
6e1839fcf2 Rename shift_object_count to objects_to_shift_before_slider 2021-07-01 11:03:22 +08:00
328dcb4d6b Use Math.Clamp instead of MathHelper.Clamp 2021-07-01 11:03:22 +08:00
3c1f0452a2 Refactor and rename getMinSliderMargin to getSliderBoundingBox. 2021-07-01 11:03:22 +08:00
4b56d94a98 Revert accidentally pushed part of change 2021-06-30 10:26:34 +03:00
e3344c33ea Better convey reason of "Spin In" incompatibility with "Hidden" 2021-06-30 09:57:15 +03:00
3f185a0622 Fixed an exception when clamping large sliders 2021-06-30 10:35:06 +08:00
dbe3150f88 Mention about marker interfaces even more explicitly 2021-06-29 11:37:08 +03:00
7997d57030 Mention interfaces being "markers" for the time being 2021-06-29 11:25:35 +03:00
8d1eae7c70 Use IndexInCurrentCombo 2021-06-29 14:25:45 +08:00
2722565204 Take circle radius into account when clamping to playfield 2021-06-29 13:36:30 +08:00
0c5777c2c8 Added comments 2021-06-29 12:56:05 +08:00
96e09605d8 Osu random mod improvements
- Reduce "jump streams" by increasing maximum jump angle and variance in jump angle
- Reduce weird jumps to sliders by shifting hit circles in front of sliders
2021-06-29 12:33:40 +08:00
69dac018c7 Make OsuModSpinIn as incompatible with other IHidesApproachCircles mods
Respecting the TODO comment above it, mark `OsuModSpinIn` as
incompatible with other `IHidesApproachCircles` mods as well.
2021-06-28 21:20:07 +03:00
baf736026b Mark IHidesApproachCircles mods as incompatible with IRequiresApproachCircles 2021-06-28 21:20:07 +03:00
6a67a6736a Mark IRequireApproachCircles mods as incompatible with IHidesApproachCircles 2021-06-28 21:20:07 +03:00
006cc331c8 Separate IMutateApproachCircles to requiring and hiding 2021-06-28 21:20:07 +03:00
26086ca1ef Rename VectorUtils to OsuHitObjectGenerationUtils 2021-06-25 09:43:14 +08:00
3fcda83713 Rename VectorHelper to VectorUtils 2021-06-24 22:00:19 +08:00
2268d7f8a5 Extract utility methods into helper class; Better xmldoc and naming 2021-06-24 13:19:42 +08:00
01478d780d Generalize IHasSpinnerApproachCircle from being spinner-specifc 2021-06-21 03:43:11 +03:00
c04b09520d Replace spinner approach circle proxying logic with hooking up to OnSkinChange in mod 2021-06-19 20:06:28 +03:00
843c8bd7a4 Move spinner approach circle to its own SkinnableDrawable 2021-06-18 20:33:50 +03:00
f7b5341663 Merge branch 'master' into legacy-spinner-approach-circle 2021-06-18 19:50:52 +03:00
860626152a Mark all mods which adjust approach circle as incompatible with each other
Closes https://github.com/ppy/osu/issues/13543.
2021-06-18 13:21:53 +09:00
c9458fd9ce Hide spinner approach circle in "Hidden" mod 2021-06-18 06:23:54 +03:00
90a13b8ed3 Use IApplicableToDrawableHitObject for OsuModApproachDifferent
Replacing the obsolete interface.
2021-06-16 22:05:40 +09:00
b6a9fa9999 Merge branch 'master' into applicable-to-dho 2021-06-16 22:04:10 +09:00
af80418ee8 Implement IApplicableToDrawableHitObject for mods
A breaking change in `ModWithVisibilityAdjustment` if the method was overriden.
2021-06-16 18:52:01 +09:00
7891ee4f32 Change order of settings to make scrolling easier
There's an issue with dropdown menus nested inside a scroll view being
very frustrating to scroll to off-screen items. This works around that
to some extent by giving the user more "parent-scrollable" space to
mouse wheel or drag over.
2021-06-16 17:32:31 +09:00
0c1023da31 Simplify transform logic 2021-06-16 17:27:52 +09:00
ee5f4f1856 Remove default (and make default "Gravity") 2021-06-16 17:27:43 +09:00
f6f1a068b2 Rename "easing" references to be "style" instead 2021-06-16 15:15:12 +09:00
b1dd502e06 Rename class to match new name 2021-06-16 15:09:42 +09:00