Commit Graph

45724 Commits

Author SHA1 Message Date
5d784b2ef8 Perform a consistency check by decoding the newly written skin.ini during ComputeHash
As this has regressed twice now, let's play it safe and bail rather than
stack overflowing. Note that as all the underlying issues that could
trigger this have been fixed, no additional tests have been added. To
test, comment out `SkinManager.cs` line 228-229 to cause a failure. The
new logic will kick in and show a log output message, but all tests will
still (correctly) pass.
2021-11-02 14:11:25 +09:00
2e66ab453d Always write automated changes to skin metadata at the end of the file
Apart from being cleaner (and allowing removal at the point of export,
if that is ever requires), this also gives us a better guarantee that
the metadata is going to take effect.

By writing the `[General]` section ourselves, we avoid any issues that
may be present from a user constructing the file (incorrectly)
themselves, such as multiple `Title:` entries or a malformed `[General]`
marker.

The main goal is to ensure that the name is updated to what we expect it
to be.
2021-11-02 14:11:25 +09:00
ee6af1245c Merge pull request #15403 from frenzibyte/android-replay-intent
Add android intent filter for osu! replays
2021-11-02 12:52:13 +09:00
badbbace10 Add android intent filter for osu! replays 2021-11-02 04:58:53 +03:00
399aea6740 Merge pull request #15399 from bdach/update-dependencies
Update dependencies
2021-11-02 10:24:11 +09:00
12c2f03949 Merge branch 'dependabot/nuget/Microsoft.CodeAnalysis.BannedApiAnalyzers-3.3.3' into update-dependencies 2021-11-01 20:53:48 +01:00
90fb536a25 Merge branch 'dependabot/nuget/Microsoft.AspNetCore.SignalR.Client-5.0.11' into update-dependencies 2021-11-01 20:53:43 +01:00
d05d0f2b88 Merge branch 'dependabot/nuget/Sentry-3.10.0' into update-dependencies 2021-11-01 20:53:19 +01:00
bfcd7948fe Merge branch 'dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.MessagePack-5.0.11' into update-dependencies 2021-11-01 20:52:56 +01:00
e4672981d8 Merge branch 'dependabot/nuget/SharpCompress-0.30.0' into update-dependencies 2021-11-01 20:52:44 +01:00
717403c78f Merge branch 'dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson-5.0.11' into update-dependencies 2021-11-01 20:52:43 +01:00
7dc5c5cdcd Merge branch 'dependabot/nuget/Microsoft.NET.Test.Sdk-17.0.0' into update-dependencies 2021-11-01 20:52:38 +01:00
6e17f92f55 Bump Microsoft.CodeAnalysis.BannedApiAnalyzers from 3.3.2 to 3.3.3
Bumps [Microsoft.CodeAnalysis.BannedApiAnalyzers](https://github.com/dotnet/roslyn-analyzers) from 3.3.2 to 3.3.3.
- [Release notes](https://github.com/dotnet/roslyn-analyzers/releases)
- [Changelog](https://github.com/dotnet/roslyn-analyzers/blob/main/PostReleaseActivities.md)
- [Commits](https://github.com/dotnet/roslyn-analyzers/commits)

---
updated-dependencies:
- dependency-name: Microsoft.CodeAnalysis.BannedApiAnalyzers
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-01 17:02:23 +00:00
3b7379b777 Bump Microsoft.AspNetCore.SignalR.Client from 5.0.10 to 5.0.11
Bumps [Microsoft.AspNetCore.SignalR.Client](https://github.com/dotnet/aspnetcore) from 5.0.10 to 5.0.11.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.10...v5.0.11)

---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.SignalR.Client
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-01 17:02:20 +00:00
e0a940be1d Bump Sentry from 3.9.4 to 3.10.0
Bumps [Sentry](https://github.com/getsentry/sentry-dotnet) from 3.9.4 to 3.10.0.
- [Release notes](https://github.com/getsentry/sentry-dotnet/releases)
- [Changelog](https://github.com/getsentry/sentry-dotnet/blob/main/CHANGELOG.md)
- [Commits](https://github.com/getsentry/sentry-dotnet/compare/3.9.4...3.10.0)

---
updated-dependencies:
- dependency-name: Sentry
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-01 17:02:14 +00:00
f215439b4f Bump Microsoft.AspNetCore.SignalR.Protocols.MessagePack
Bumps [Microsoft.AspNetCore.SignalR.Protocols.MessagePack](https://github.com/dotnet/aspnetcore) from 5.0.10 to 5.0.11.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.10...v5.0.11)

---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.SignalR.Protocols.MessagePack
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-01 17:02:10 +00:00
f8f4b9d3d3 Bump SharpCompress from 0.29.0 to 0.30.0
Bumps [SharpCompress](https://github.com/adamhathcock/sharpcompress) from 0.29.0 to 0.30.0.
- [Release notes](https://github.com/adamhathcock/sharpcompress/releases)
- [Commits](https://github.com/adamhathcock/sharpcompress/compare/0.29...0.30)

---
updated-dependencies:
- dependency-name: SharpCompress
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-01 17:02:04 +00:00
f893556b80 Bump Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson
Bumps [Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson](https://github.com/dotnet/aspnetcore) from 5.0.10 to 5.0.11.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.10...v5.0.11)

---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-01 17:02:00 +00:00
7747fd5810 Bump Microsoft.NET.Test.Sdk from 16.11.0 to 17.0.0
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.11.0 to 17.0.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.11.0...v17.0.0)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-01 17:01:54 +00:00
a4e65de2d4 Merge pull request #15356 from peppy/score-refactor/less-create-score-info
Change `DrawableProfileScore` to use `APIScoreInfo`
2021-11-01 16:00:32 +01:00
3a5aed1182 Ensure APIScoreInfo.Mods is non-null 2021-11-01 22:59:12 +09:00
caa9d8997b Merge branch 'master' into score-refactor/less-create-score-info 2021-11-01 22:59:11 +09:00
a19f1e3d6d Merge pull request #15364 from peppy/beatmap-refactor/beatmap-overlays
Update all beatmap overlay views to use `APIBeatmap`/`APIBeatmapSet`
2021-11-01 20:41:51 +09:00
0d65493b56 Mark test usages of Ruleset.CreateInstance() as returning non-null 2021-11-01 12:12:21 +01:00
793c384ecd Remove unnecessary null-conditional access 2021-11-01 12:02:37 +01:00
5dcff7d8b7 Merge branch 'master' into score-refactor/less-create-score-info 2021-11-01 11:41:20 +01:00
95b1f5830d Merge branch 'master' into beatmap-refactor/beatmap-overlays 2021-11-01 19:32:07 +09:00
8c38698506 Merge pull request #15363 from peppy/beatmap-refactor/get-and-present
Update `GetScoreRequest` and `PresentBeatmap` to accept interface types
2021-11-01 19:28:28 +09:00
65d2b54ef6 Merge pull request #15387 from bdach/fix-score-download-tracker
Fix incorrect state transition in score download tracker
2021-11-01 18:36:35 +09:00
87374811e6 Merge branch 'master' into beatmap-refactor/get-and-present 2021-11-01 18:32:51 +09:00
b4b7d6945b Merge pull request #15351 from peppy/score-refactor/isolated-serialisation
Clean up score serialisation
2021-11-01 18:32:09 +09:00
b21e0e7efb Merge branch 'beatmap-refactor/get-and-present' into beatmap-refactor/beatmap-overlays 2021-11-01 18:07:51 +09:00
602fe372c2 Merge branch 'score-refactor/isolated-serialisation' into beatmap-refactor/get-and-present 2021-11-01 18:06:53 +09:00
5dcc940864 Merge branch 'master' into fix-score-download-tracker 2021-11-01 17:50:34 +09:00
6a44cf3ff1 Add missing beatmap spec in test scene 2021-11-01 09:44:08 +01:00
f5feed138d Merge branch 'master' into score-refactor/isolated-serialisation 2021-11-01 09:43:51 +01:00
cd4681496a Fix incorrect state transition in score download tracker 2021-11-01 09:35:02 +01:00
90a0a5e0b7 Fix attempting to set properties of null BeatmapSets in tests 2021-11-01 17:12:15 +09:00
f0b012ebb6 Merge pull request #15385 from peppy/beatmap-refactor/dashboard
Update dashboard components to use `APIBeatmapSet`
2021-11-01 17:10:25 +09:00
63c9512ab1 Update dashboard components to use APIBeatmapSet 2021-11-01 16:04:01 +09:00
722e0d50bb Fix BeatmapInfo not being correctly populated in CreateScoreInfo call 2021-11-01 15:54:39 +09:00
c51349de57 Merge pull request #15358 from peppy/online-id-potentially-zero
Add a note about `OnlineID` potentially being zero in non-autoincrement cases
2021-11-01 15:54:08 +09:00
b98faf6159 Merge branch 'master' into score-refactor/isolated-serialisation 2021-11-01 15:49:25 +09:00
9e633a1b17 Merge pull request #15321 from peppy/beatmap-refactor/download-tracker
Replace `DownloadTrackingComposite` with instantiable `DownloadTracker` components
2021-11-01 15:48:12 +09:00
94dce3f92a Remove whitespace 2021-11-01 15:43:19 +09:00
cd9ee7723a Merge pull request #15384 from peppy/fix-tourney-map-pool-creator-shows-twice
Fix beatmap creator showing twice in tournament map pool panels
2021-11-01 15:24:54 +09:00
227963047a Fix hash validity check function returning incorrect results after soft deleting a beatmap
The soft-deleted one would potentially match before the newly imported
copy, resulting in a false-positive hash mismatch.
2021-11-01 15:15:45 +09:00
123b10f647 Fix playlist item download button being clickable when it shouldn't 2021-11-01 15:10:32 +09:00
df5815e4bd Merge pull request #15383 from peppy/skin-hash-migration-failure-on-case-difference
Fix potential infinite loop when trying to rewrite skin metadata with non-lowercase `skin.ini`
2021-11-01 14:50:25 +09:00
21e0074d3b Add missing AddInternal call for BeatmapSetHeaderContent's download tracker 2021-11-01 14:43:32 +09:00