5f9b13a775
Rename Add/AddRange methods as they are no longer conflicting with Container
2023-03-15 18:02:41 +09:00
9e444af380
Use object initialisers and fix order of initialisation vs add
2023-03-15 18:02:26 +09:00
8908648f97
Fix super-dodgy cast of IEnumerable to Drawable
2023-03-15 18:01:22 +09:00
d806b85a30
revert: make counters an IEnumerable again
...
As suggested by bdach as this would make the last two commits useless
Refs: 5d15426
2023-03-09 10:25:03 +00:00
5d15426c27
refactor: make Counters return a Container
2023-03-08 01:52:12 +00:00
5b0db94a24
docs: add XMLDoc for methods in KCD
2023-03-08 00:58:54 +00:00
44297a7d0a
refactor: make KCD a CompositeDrawable
2023-03-08 00:47:16 +00:00
12af002c4d
Reorder and add xmldoc to KeyCounter members
2023-03-07 21:28:42 +01:00
98f40b2679
Improve documentation of InputTrigger
2023-03-07 21:22:59 +01:00
f711915e5f
Remove unused using directive
2023-03-07 21:16:30 +01:00
6a7c4d0bf7
Remove NRT disables in new classes
2023-03-07 16:41:39 +09:00
97ba236eb1
Add basic xmldoc to KeyCounter classes
2023-03-07 16:41:39 +09:00
28520414aa
Move KeyCounter components to HUD namespace
2023-03-07 16:41:39 +09:00
15d65059b5
Tidy up Add method logic
2023-03-07 16:21:57 +09:00
8f6df5ea0f
Merge branch 'master' into gameplay/key-counter-abstraction
2023-03-07 16:09:45 +09:00
ff59a236ae
Merge pull request #22775 from peppy/dont-filter-results-on-sort-mode
...
Don't filter away results with missing data when using "Date Submitted" or "Date Ranked" sort modes
2023-03-06 18:47:41 +01:00
ec15e2b9cc
Merge branch 'master' into dont-filter-results-on-sort-mode
2023-03-06 17:57:47 +01:00
87d0bef313
Use nullable comparison helper method instead of manual implementation
2023-03-06 15:16:32 +09:00
778cde8932
Merge pull request #22790 from Joehuu/fix-android-external-links
...
Fix external links not working on Android
2023-03-05 22:12:57 +09:00
77257398db
Merge pull request #22787 from bdach/skin-editor-screen-transitions
...
Fix several issues with skin editor behaviour on screen transitions
2023-03-05 22:00:14 +09:00
d120638e68
Use manifest overlay and merger for intent query specs
...
Co-authored-by: Susko3 <Susko3@protonmail.com >
2023-03-05 13:17:46 +01:00
5d6ab5f465
Add mailto scheme to intent queries
2023-03-04 16:07:29 -08:00
92f94278c1
Fix external links not working on Android
2023-03-04 13:35:34 -08:00
60cdd3c070
Clear components sidebar unconditionally on every target change
...
Fixes the working layer dropdown lingering after exiting from a
skinnable screen to a non-skinnable one.
2023-03-04 14:10:05 +01:00
9d4bb2ecf7
Add failing test coverage for clearing sidebar contents
2023-03-04 14:08:50 +01:00
d233f3a3ab
Show non-skinnable screen placeholder at higher level
2023-03-04 13:49:10 +01:00
49e298e304
Accept ISerialisableDrawableContainer directly in SkinBlueprintContainer
...
An end result of #22674 is that `SkinBlueprintContainer`s are only ever
created by supplying a `SkinComponentsContainer` to them. However,
`SkinBlueprintContainer` still contained remnants of code that suggested
it was designed to handle cases where more than the drawable supplied to
it contained more than one `ISerialisableDrawableContainer`, or even
zero.
The zero path is totally dead right now (because every
`SkinComponentsContainer` is *by necessity* an
`ISerialisableDrawableContainer`), and the more-than-one path is dead
*for now* (and potentially forever?). Therefore, just hard-couple
`SkinBlueprintContainer` to receive a single target container.
2023-03-04 13:33:21 +01:00
2f25fb4083
Move NonSkinnableScreenPlaceholder to outer scope
2023-03-04 13:22:43 +01:00
15409b9c15
Fix skin selection not clearing on exit to non-skinnable screen
2023-03-04 13:18:34 +01:00
3dd3b5e77a
Add failing test case
2023-03-04 13:17:54 +01:00
866987d6e1
Merge pull request #22776 from peppy/fix-mania-upscroll
...
Fix upwards scroll direction not working with recent hold note display changes
2023-03-03 21:37:51 +01:00
36058b3da2
Fix upwards scroll direction not working with recent hold note display changes
2023-03-03 18:03:06 +09:00
a14dede036
Ensure TestBeatmapCarousel.Items only returns actually visible items (and in correct order)
...
Turns out that items could be in an order that isn't the same as how
things look on the carousel, so this change ensures that for testing
purposes they are sorted by Y position.
Also uses the `CarouselItem.Visible` flag to ensure that we don't have
to wait for drawable fade transitions after a filter operation.
2023-03-03 17:18:34 +09:00
7a092ea995
Add better coverage and more comments explaining the structure of test setup
2023-03-03 17:18:14 +09:00
82293c0c86
Don't filter away results with missing data when using "Date Submitted" or "Date Ranked" sort modes
...
From a user's perspective, changing a sort / order mode shouldn't filter
away results, but we were doing this.
In terms of UX expectations, in stable this kind of scenario would
results in a group being added to the end of son select with "Not
ranked" or "Unknown". I think we should aim to match this eventually.
2023-03-03 16:36:18 +09:00
29be26b150
Merge pull request #22766 from Joehuu/fix-talking-with-text-overflow
...
Fix "talking with" text overflowing when usernames are too long
2023-03-02 17:04:11 +09:00
af540de69b
Fix "talking with" text overflowing when usernames are too long
2023-03-01 22:10:15 -08:00
bd11d5d29a
Merge pull request #22743 from Joehuu/scroll-back-to-previous
...
Add ability to scroll back to previous position after scrolling to top via button on overlays
2023-03-01 22:55:47 +09:00
21ebcdf5ed
Merge pull request #22755 from EVAST9919/colour-info-framework
...
Use `ColourInfo.Interpolate(Quad)` where possible
2023-03-01 12:05:54 +09:00
24723ca873
Merge pull request #22749 from peppy/rename-setting-source-tests
...
Rename `SettingSource` tests to match attribute name
2023-02-28 20:40:07 +01:00
31f58a33ac
Use ColourInfo.Interpolate where possible
2023-02-28 18:47:27 +03:00
3c45ab677a
Merge pull request #22751 from peppy/update-framework
...
Update framework
2023-02-28 16:40:18 +09:00
89e20a7962
Update resources
2023-02-28 14:47:51 +09:00
bd1460a8d5
Update framework
2023-02-28 14:32:58 +09:00
2615453b31
Rename SettingSource tests to match attribute name
2023-02-28 11:45:32 +09:00
ca47d55f10
Merge pull request #22748 from OpenSauce04/patch-1
...
Fix grammar mistake in taiko relax mod description
2023-02-27 20:17:14 +01:00
4e9d25957a
Merge pull request #22717 from peppy/skin-editor-depth-changing
...
Add ability to send selected skin components to front or back
2023-02-27 19:56:21 +01:00
92edb0f868
Merge branch 'master' into skin-editor-depth-changing
2023-02-27 19:24:53 +01:00
8d747f2402
Fixed grammar mistake in Taiko Relax mod description
2023-02-27 16:06:33 +00:00
fa710ae1b0
Rename ScrollToTopButton to ScrollBackButton
2023-02-26 14:39:34 -08:00
