6033c89e7b
Merge pull request #16734 from bdach/war-on-unused-params
...
Fix several cases of unused constructor and method parameters
2022-02-02 07:40:58 +09:00
3674ed15ce
Remove unused game host parameter
...
No longer used since eeccf836ec
2022-02-01 21:53:21 +01:00
b978010b48
Remove unused allowMissing parameter in audio file check test
...
No longer used since 7f95400f46
2022-02-01 21:53:21 +01:00
7cdf63c654
Remove unused FindProvider() methods
...
No longer needed since 39f99bf785
2022-02-01 21:53:21 +01:00
e4028b8fc1
Remove index ctor param from ColumnHitObjectArea
...
No longer used since 5692cecaa4
2022-02-01 21:49:52 +01:00
e042f29ee3
Remove skin ctor param from LegacyCatchComboCounter
...
No longer used since 004798d61d
2022-02-01 21:49:52 +01:00
75101b1105
Remove unused ruleset ctor params from test beatmap model managers
...
No longer used since 00e3af3366
2022-02-01 21:49:41 +01:00
994fb966b6
Remove Host ctor param from SkinModelManager
...
No longer used since 29d074bdb8
2022-02-01 21:37:19 +01:00
07d09b3520
Remove unused parameter from createGameplayComponents()
...
No longer used since 136843c8e4
2022-02-01 21:35:41 +01:00
a94702b3ae
Remove unused parameters in LegacyComboCounter
...
No longer used since 9bb8a43bce
2022-02-01 21:35:41 +01:00
1fa2bf5d69
Remove unused parameter from createColourBars()
...
No longer used since b61aa660c6
2022-02-01 21:35:40 +01:00
c6a65ccfed
Remove unused parameter from createContent()
...
No longer used since 513e470b52
2022-02-01 21:35:40 +01:00
16e0cc6a2b
Remove IIpcHost param from ScoreManager
...
No longer used since 3e3b9bc963
2022-02-01 21:35:40 +01:00
a378e78ced
Fix RealmLive unnecessarily passing ID around
...
Appears to have never been needed. When the `retrieveFromID` method was
created in 81b5717ae7
2022-02-01 21:35:12 +01:00
3d7af805a3
Fix BeatmapMetadata not using its user param correctly
2022-02-01 21:16:28 +01:00
2c0c44a950
Merge pull request #16722 from smoogipoo/spectator-consistency-frames
...
Implement spectator consistency frames
2022-02-01 17:28:13 +09:00
15479ae046
Add test coverage of no header doing nothing
2022-02-01 16:55:28 +09:00
0f83f77d2b
Add xmldoc for new ResetFromReplayFrame method
2022-02-01 16:52:53 +09:00
0641264a11
Merge branch 'master' into spectator-consistency-frames
2022-02-01 14:35:30 +09:00
aa492270dd
Ignore FodyWeavers.xml files in subdirectories
...
These are created when building specific projects rather than the main
solution (typically iOS / android) and of no use to us.
2022-02-01 13:30:28 +09:00
5a6d57efb7
Update fastlane and dependencies
2022-02-01 12:43:35 +09:00
c421d8d3cd
Merge pull request #16719 from peppy/mania-column-touch
...
Add basic touch input support for osu!mania
2022-02-01 12:26:29 +09:00
c50577e25f
Apply suggestion from review
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com >
2022-02-01 10:48:41 +09:00
2f88efd3c3
Pass column in rather than accessing parent
2022-02-01 00:53:56 +09:00
4fb565e15f
Reset ScoreProcessor from statistics replay frames
2022-01-31 21:32:56 +09:00
39e1d65976
Make ScoreProcessor write all judgement types
2022-01-31 18:53:47 +09:00
0458d408bb
Add replay statistics frames to FramedReplayInputHandler
2022-01-31 18:53:47 +09:00
4727aeda01
Give last bundled replay frame the frame header
2022-01-31 18:53:47 +09:00
f3d4756c7f
Merge pull request #16713 from frenzibyte/fix-spectator-gcc-state-2
...
Fix multiplayer spectator occasionally rewinding time unexpectedly
2022-01-31 18:33:08 +09:00
62603e78fd
Merge pull request #16714 from frenzibyte/rewrite-hardware-correction-clock
...
Rewrite `HardwareCorrectionOffsetClock` to handle seeking on different gameplay rates
2022-01-31 17:32:22 +09:00
a49a9ed0a0
Fix incorrect invoke
2022-01-31 17:19:04 +09:00
6956146cce
Merge pull request #16718 from peppy/add-key-counter-keyword
...
Add "counter" keyword for key overlay setting
2022-01-31 17:10:12 +09:00
575d9671bf
Merge pull request #16717 from peppy/fix-dialog-overlay-missing-test-failures
...
Fix test failures if `DialogOverlay` is not loaded in time
2022-01-31 17:06:24 +09:00
0e764538e0
Retrieve KeyBindingContainer via DI rather than traversal lookup
2022-01-31 17:05:04 +09:00
9005bce0fa
Add "counter" keyword for key overlay setting
2022-01-31 16:37:51 +09:00
cc7fb0e559
Add mouse click support and increase area to full column height
2022-01-31 16:37:02 +09:00
a84fd2e20c
Merge branch 'master' into master
2022-01-31 16:30:08 +09:00
cec16d17ab
Merge pull request #16696 from peppy/fix-migration-crash-case-sensitivity
...
Fix stable import not working when multiple configuration files exist with different file case
2022-01-31 15:52:29 +09:00
8d13e0514b
Merge pull request #16716 from peppy/carousel-less-invalidations
...
Refactor carousel drawables to reduce invalidations
2022-01-31 15:52:08 +09:00
95582a9023
Merge pull request #16690 from smoogipoo/flush-frames-end-play
...
Purge final spectator frames before ending play
2022-01-31 15:40:41 +09:00
25cbe5a0de
Remove acronym shortening of GameplayClockContainer
2022-01-31 15:23:31 +09:00
9001c3a396
Fix test failures if DialogOverlay is not loaded in time
...
As seen at https://github.com/ppy/osu/runs/4999391205?check_suite_focus=true , where `DialogOverlay` hasn't loaded in single file yet.
2022-01-31 15:17:07 +09:00
c8c0ae5658
Merge branch 'master' into flush-frames-end-play
2022-01-31 15:12:41 +09:00
57f793aff0
Rename dictionary and make private for added safety
2022-01-31 15:12:08 +09:00
6bc6675fa1
Adjust fade in times slightly
2022-01-31 14:46:20 +09:00
8917ab78f4
Reduce unnecessary container nesting and adjust empty state opacity slightly
2022-01-31 14:46:20 +09:00
2ee0db0ebf
Move fade in function local
2022-01-31 14:46:20 +09:00
c3e3b2019d
Reduce overhead of ApplyState by tracking previous values
...
Even with pooling applied, there are overheads involved with transforms
when quickly cycling through the carousel.
The main goal here is to reduce the transforms in cases the reuse is
still in the same state. Avoiding firing `FadeIn` and `FadeOut` are the
main areas of saving.
2022-01-31 14:46:20 +09:00
a06287e76a
Remove DrawableCarouselItem.Update updating of height
...
Marginal from a performance aspect, but reads better.
2022-01-31 14:46:20 +09:00
e9f3e7f5cb
Merge pull request #16703 from peppy/leaderboard-component-fixes
...
Rewrite `Leaderboard` component to bring up to current code standards
2022-01-31 14:33:04 +09:00
