Commit Graph

45870 Commits

Author SHA1 Message Date
6197ef426d Disable another "code heurstically unreachable" with comment 2021-11-05 03:50:17 +03:00
af6ae1cce5 Remove hacky code with explicit pragma disable 2021-11-05 03:49:35 +03:00
78ed77805f Merge pull request #15468 from smoogipoo/upgrade-nvika
Use official nvika package again
2021-11-04 15:16:03 +03:00
9846596c02 Merge branch 'master' into upgrade-nvika 2021-11-04 14:48:42 +03:00
66509264ff Merge pull request #15467 from peppy/update-framework
Update framework
2021-11-04 20:19:56 +09:00
4b46833ee9 Merge branch 'master' into upgrade-nvika 2021-11-04 13:53:30 +03:00
aa2711e6ec Merge branch 'master' into update-framework 2021-11-04 13:51:57 +03:00
f12a2c7767 Merge pull request #15458 from peppy/beatmap-refactor/playlist-use-api-beatmap-extended
Refactor `PlaylistItem` to allow `Beatmap` to be an interfaced type
2021-11-04 19:23:33 +09:00
30635fb476 Use official nvika package again 2021-11-04 19:19:00 +09:00
28e9b9a25f Update framework 2021-11-04 19:01:39 +09:00
45dcf187b9 Merge branch 'master' into beatmap-refactor/playlist-use-api-beatmap-extended 2021-11-04 18:59:04 +09:00
df3c3a32ce Fix unintentionally broken background update logic 2021-11-04 18:07:39 +09:00
388c074c15 Merge pull request #15464 from peppy/fix-crash-on-gameplay
Fix crash on gameplay startup if beatmap has no background
2021-11-04 18:07:10 +09:00
b80c02b757 Fix crash on gameplay startup if beatmap has no background 2021-11-04 17:24:40 +09:00
5a078da4d9 Fix APIBeatmapSet.Beatmaps being IEnumerable, causing stupid issues 2021-11-04 16:50:14 +09:00
c820d445ad Merge pull request #15461 from peppy/fix-more-computationally-expensive
Fix a few more "maybe null" inspections
2021-11-04 16:49:38 +09:00
e50c961185 Merge pull request #15312 from jaswon/editor-context-menu-on-select
Fix editor context menu requiring two right-clicks to display
2021-11-04 16:49:19 +09:00
a9eef4199a Merge pull request #15460 from smoogipoo/upgrade-nvika
Upgrade to nvika 1.0.4
2021-11-04 16:47:23 +09:00
317506d4d7 Fix a few more "maybe null" inspections 2021-11-04 16:11:23 +09:00
63cfa69bd1 Merge branch 'master' into upgrade-nvika 2021-11-04 16:10:23 +09:00
0c14d8af23 Upgrade to nvika 1.0.4 2021-11-04 16:03:59 +09:00
09701d0af1 Use explicit primitive type specification 2021-11-04 16:02:37 +09:00
0f4f1349db Merge branch 'master' into editor-context-menu-on-select 2021-11-04 15:59:06 +09:00
222c3e552b Merge pull request #15456 from peppy/beatmap-refactor/beatmap-metadata-nullable-enable
Enable nullable support on `BeatmapMetadata`
2021-11-04 15:47:18 +09:00
84d36cbae7 Add fallback for cases where BeatmapSet may be null
Seems to only happen in tests, but better safe than sorry.
2021-11-04 15:22:33 +09:00
e43d91ad5d Fix another case of incorrect null checking in editor verification processing 2021-11-04 15:18:10 +09:00
09f9731d74 Add temporary disable of failing r# inspection 2021-11-04 15:09:04 +09:00
d1e6d1cb98 Update some other missed incorrect null/empty usages 2021-11-04 14:50:43 +09:00
a49366ff84 Remove nullability from IBeatmapInfo.Metadata 2021-11-04 14:28:39 +09:00
1e73b09e57 Fix another couple of cases of incorrect string null/empty checking 2021-11-04 14:22:28 +09:00
41854f2e16 Fix incorrect check on AudioFile presence 2021-11-04 14:02:09 +09:00
67d9590a79 Fix new inspections 2021-11-04 14:02:09 +09:00
0df339d0b8 Fix incorrect invocation of download method in SoloSpectator 2021-11-04 13:50:04 +09:00
0ab50f1cc9 Add inline comment explaining why we are manually populating beatmap.BeatmapSet 2021-11-04 13:45:59 +09:00
9f9c960fe3 Revert PlaylistItem.APIBeatmap to be private 2021-11-04 13:36:32 +09:00
05f1fd4bc9 Remove unnecessary properties and parameters 2021-11-04 13:33:54 +09:00
3453160a8b Change PlaylistItem.Beatmap to be an IBeatmapInfo 2021-11-04 13:16:56 +09:00
772b6c6dcd Enable nullable support on BeatmapMetadata 2021-11-04 12:11:42 +09:00
6fdeb66dc1 Use APIBeatmap instead of BeatmapInfo in playlist display classes where feasible 2021-11-04 11:55:50 +09:00
1d8e253112 Expose PlaylistItem.APIBeatmap for now 2021-11-04 11:53:26 +09:00
dd948e5ada Merge pull request #15447 from peppy/fix-invalid-characters-zip-export
Fix beatmaps being exported with malformed filenames inside `.osz` zip files
2021-11-04 09:03:51 +09:00
e2ec8e8f40 Merge pull request #15455 from bdach/fix-multiplayer-text-flow-usages-with-correct-hitbox
Fix multiplayer text flow usages incorrectly wrapping text
2021-11-04 08:53:18 +09:00
098fa181b4 Fix text flow wrapping incorrectly in multiplayer usages 2021-11-03 18:36:43 +01:00
6e33fa088f Add test case for drawable room with too long beatmap name 2021-11-03 17:32:53 +01:00
2cc3c959b3 Merge pull request #15440 from bdach/localisable-text-flow
Update `TextFlowContainer` usages to consume `LocalisableString`s
2021-11-03 17:38:54 +09:00
8d40d55d93 Update framework 2021-11-03 17:09:49 +09:00
d85224d7ad Merge branch 'master' into localisable-text-flow 2021-11-03 17:09:46 +09:00
ca438a102d Fix beatmap paths including invalid slash/backslash characters 2021-11-03 16:46:05 +09:00
601b218119 Add test coverage for characters which are invalid in zip storage 2021-11-03 16:45:16 +09:00
900549a771 Merge pull request #15398 from bdach/beatmap-card-basics
Add basic elements of new beatmap cards
2021-11-03 15:35:29 +09:00