80f3a67876
Use for instead of foreach to avoid enumerator overhead
2022-01-20 22:21:00 +09:00
0b93f3c88f
Add <Guid,CarouselBeatmapSet> dictionary to speed up update operations in carousel
2022-01-20 22:12:49 +09:00
a8ce2c5edf
Detach before sending BeatmapSetInfo to any handling method
2022-01-20 21:14:10 +09:00
b1cf3befa6
Fix incorrect query in comment
2022-01-20 18:36:20 +09:00
3ba712703b
Add a note about hidden beatmap check
2022-01-20 17:50:17 +09:00
1dabf6c8a5
Fix BeatmapCarousel signalling it is finished loading before catching up on realm changes
2022-01-20 16:39:42 +09:00
6c46fd6931
Fix some failing tests due to realm beatmaps overwriting test beatmaps
2022-01-20 00:19:16 +09:00
2789986699
Use asynchronous loading for beatmap carousel again
2022-01-19 18:15:43 +09:00
200fcb6f83
Detach beatmap set before checking hidden state
2022-01-19 16:59:49 +09:00
11ca1b6e7b
Remove one more usage of IsManaged which could potentially go wrong
2022-01-17 13:40:27 +09:00
6025fe325d
Fix filter criteria not being applied after carousel loads new beatmap sets
2022-01-13 15:08:51 +09:00
ef0f794fd6
Remove stay newline
2022-01-12 18:13:14 +09:00
34aa1bf21d
Sanitise and remove some usages of Detach which are no longer required
2022-01-12 17:49:11 +09:00
0aff1c232b
Fix deleted/hidden carousel queries
2022-01-12 17:49:11 +09:00
7dba3c3551
Fix most remaining test issues
2022-01-12 17:49:11 +09:00
02d0ca2741
Fix protected beatmaps showing up in the song select carousel
2022-01-12 17:49:10 +09:00
41d90cd0b5
Fix beatmap carousel test failures
2022-01-12 17:49:10 +09:00
e74a5022c9
Fix multiple tests via null checks and changing ToLive to Detach
...
flow
2022-01-12 17:00:17 +09:00
8461eaab46
BeatmapSetInfo detach support
2022-01-12 17:00:16 +09:00
c9257e9ecc
Fix missing disposal of realm subscriptions in BeatmapCarousel
2022-01-12 17:00:16 +09:00
3152d2d8a0
"Update" BeatmapCarousel
2022-01-12 17:00:16 +09:00
00e3af3366
Update model manager and many related classes to get things compiling again
2022-01-12 17:00:00 +09:00
b8cd3cdbbc
Various updates to ruleset and primary key usages to move closer to realm support
2022-01-12 16:57:13 +09:00
729f681938
Update cases where equality can be used instead of primary key equality
2021-11-24 12:49:57 +09:00
66c307e0ee
Remove usage of key repeat helper method
2021-11-18 13:13:36 +09:00
54f72d68ca
Revert weird event flow in model manager/importers
2021-11-05 19:12:49 +09:00
ec61c3c5ee
Rename all remaining cases
2021-10-03 00:55:29 +09:00
973c31132b
Rename BeatmapInfo variables which were named beatmap for clarity
2021-10-02 12:45:34 +09:00
f9d5abff8a
Update with keybinding changes
2021-09-16 18:26:12 +09:00
52a243afca
Don't select random beatmap when previous was filtered
2021-08-25 22:03:07 +03:00
7c4a072568
Merge branch 'master' into scroll-to-20
2021-01-21 13:48:26 +09:00
4998aaaa98
Remove outdated warning disable
...
Does not trigger any more on Rider 2020.3.2.
2021-01-06 18:38:25 +01:00
53e6a349bb
Fix incorrect initial conditional
...
Turns out this wasn't actually required.
2021-01-03 22:44:32 +09:00
a6d4992997
Ensure SelectionChanged events are only sent once when selection is null
2021-01-03 12:53:25 +09:00
e2de5bb8f9
Fix the beatmap carousel not returning to centre correctly after resizing window
2021-01-02 22:05:41 +09:00
78c14fd696
Refactor code into UserTrackingScrollContainer
2020-12-22 17:36:44 +02:00
897f593b37
Fix beatmap carousel panels getting masked away when out of scroll bounds
...
Regressed in https://github.com/ppy/osu/pull/10973 due to removed masking specification.
Closes #11067 .
2020-12-03 13:26:28 +09:00
792934f2c4
Allow scroll type to be specified
...
This brings back the ability for the carousel to scroll in a classic
way. It turns out this is generally what we want for "seek" operations
like "random", else it's quite hard to get the expected animation.
I did experiment with applying the animation after the pooled panels are
retrieved, but in a best-case scenario there is still a gap where no
panels are displayed during the random seek operation.
2020-11-27 13:54:38 +09:00
0a48dd8f76
Delegate scroll animation to panels themselves
2020-11-26 18:42:51 +09:00
ad258e2e52
Update scroll position before applying any panel animations
...
In the case of automatic scroll requirements (ie. scroll to selected) we
are delegating the animation logic to the panels themselves. In order to
make this work correctly, the scroll operation needs to take effect
before any animation updates are run.
2020-11-26 18:33:41 +09:00
6058c66edb
Move drawable carousel set movement logic into panels themselves
2020-11-26 18:32:43 +09:00
f8db7a9902
Remove ScrollableContent container from carousel
...
This was causing multiple issues with masking and sizing and really
didn't need to exist in the first place. Also not sure why the pool was
nested inside the scroll container, but it isn't any more. Probably for
the best.
2020-11-26 18:28:54 +09:00
d5940193a2
Ensure visible items is greater than zero before trying to display a range
2020-10-19 19:55:20 +09:00
9106e97c37
Ensure max value in clamp is at least zero
2020-10-19 19:10:01 +09:00
1c2185e969
Replace comment with link to issue
2020-10-19 18:41:28 +09:00
044622a7a6
Fix out of bounds issues
2020-10-19 18:41:17 +09:00
bff3856c83
Account for panel height when removing as off-screen
2020-10-19 13:13:32 +09:00
ee0efa0b4c
Fix off-by-one in display range retrieval logic
2020-10-19 13:05:42 +09:00
4590d9b93b
Remove outdated comment logic
2020-10-19 13:04:12 +09:00
5d11db7753
Locallise ChildItems to DrawableCarouselBeatmapSet for clarity
2020-10-13 19:31:29 +09:00
