ekrctb
bde390828b
Manage entries of nested hit objects in HitObjectEntryManager
...
- Fix nested hit objects are leaked when parent hit object is edited or deleted
2022-09-14 15:19:05 +09:00
ekrctb
a9eba27129
Factor out pooling logic from Playfield
2022-09-14 15:19:05 +09:00
Dan Balasescu
90e5949e9f
Merge pull request #20300 from peppy/stable-sort-local-scores
...
Fix local scores potentially not being stable-sorted for leaderboard display
2022-09-14 15:11:07 +09:00
Dean Herbert
bc07513c3c
Fix local scores potentially not being stable-sorted for leaderboard display
2022-09-14 14:19:53 +09:00
Dean Herbert
fcf54f1bc8
Fix gameplay leaderboard not being sorted correctly in tie situations
2022-09-14 14:18:12 +09:00
Dean Herbert
8a6977213a
Fix displayed scores in gameplay leaderboard not tracking display mode changes
2022-09-14 14:02:35 +09:00
Dan Balasescu
024f7991ad
Merge pull request #20292 from peppy/fix-preix-matching-status
...
Fix song select status prefix matching no longer working
2022-09-14 13:53:03 +09:00
Joseph Madamba
85e3a681b1
Fix notification overlay toast tray background absorbing input from behind
2022-09-13 21:07:30 -07:00
Dean Herbert
b4e6a20846
Fix song select status prefix matching no longer working
...
Regressed in #19275 due to weird logic.
Closes #20289 .
2022-09-14 12:59:05 +09:00
Dan Balasescu
ef6d60ffe9
Merge pull request #20273 from frenzibyte/duplicate-beatmap-listing-cards
...
Fix beatmap listing potentially showing duplicate beatmap cards
2022-09-14 10:25:24 +09:00
Salman Ahmed
04dbb6fc1b
Add inline comment
2022-09-14 00:49:02 +03:00
Dan Balasescu
4a49433e2e
Merge branch 'master' into notification-fling-right
2022-09-13 20:01:56 +09:00
Dean Herbert
81b5e4a865
Fix back-to-front condition on leaderboard always show configuration
2022-09-13 19:57:40 +09:00
Dean Herbert
94693a4667
Fix oversight when making interface implementation explicit
2022-09-13 19:55:57 +09:00
Dean Herbert
566a61e770
Merge pull request #20244 from peppy/notification-fling
...
Add ability to "fling" notifications to dismiss them
2022-09-13 19:50:34 +09:00
Dean Herbert
9226f0abbc
Implement equality correctly in Live
2022-09-13 19:16:25 +09:00
Dean Herbert
e15a25ea49
Fix leaderboard positioning logic to actually consider elements on the left side
2022-09-13 18:45:11 +09:00
Dean Herbert
678eec1c67
Move LeaderboardFlow to HUDOverlay to share positioning logic
2022-09-13 18:45:11 +09:00
Dean Herbert
5894d2f0bc
Ensure gameplay leaderboard hides with rest of HUD when it should
2022-09-13 18:45:11 +09:00
Dean Herbert
6d167070f8
Add back DI leaderboard retrieval via bindable pathway
2022-09-13 18:45:11 +09:00
Dean Herbert
70e6b595f1
Refactor SoloGameplayLeaderboard to not read scores via DI
...
Also allows updating scores if they arrive late.
2022-09-13 18:00:21 +09:00
Dean Herbert
d2b80645ab
Change Leaderboard to use IUser instead of APIUser
2022-09-13 18:00:21 +09:00
Dean Herbert
ac58c222b9
Allow DrawableAvatar to accept an IUser for now
2022-09-13 18:00:21 +09:00
Dean Herbert
d251c0b2ac
Move leaderboard implementation to Player itself
2022-09-13 18:00:21 +09:00
Dean Herbert
368faa0084
Make constructor protected in base implementation
2022-09-13 18:00:21 +09:00
Dean Herbert
4c669e2bce
Track local Player.Score's user rather than using APIProvider
2022-09-13 18:00:21 +09:00
Salman Ahmed
3490b16056
Add simplified SoloGameplayLeaderboard implementation
...
Note that this doesn't support waiting until leaderboard finishes fetching scores.
2022-09-13 18:00:21 +09:00
Dean Herbert
27a81dfb9f
Merge pull request #20270 from OliBomby/fix-selectionblueprint-order
...
Fixed HitObjectOrderedSelectionContainer being able to become unsorted and causing crashes
2022-09-13 17:18:58 +09:00
Dan Balasescu
53ac9dbc38
Merge branch 'master' into notification-fling
2022-09-13 17:07:16 +09:00
Dan Balasescu
0e2155303e
Merge branch 'master' into fix-song-progress-invalidations
2022-09-13 16:07:05 +09:00
Dan Balasescu
62971ef1cc
Merge pull request #20281 from peppy/fix-drawable-ruleset-dependencies
...
Fix null considerations in `DrawableRulesetDependencies`
2022-09-13 15:26:29 +09:00
Dean Herbert
f53507828c
Rename event to be more generic (and add comprehensive xmldoc)
2022-09-13 14:59:30 +09:00
Dean Herbert
ac034bffeb
Fix potential crash if multiplayer spectator load is aborted early
2022-09-13 14:21:54 +09:00
Dean Herbert
0fcd9e02f6
Fix skin dropdown not updating correctly when skin is changed externally
2022-09-13 14:01:40 +09:00
Dean Herbert
d368f37c3a
Remove redundant second Current set operation
2022-09-13 13:50:59 +09:00
Dean Herbert
6bf6b7e125
Fix null considerations in DrawableRulesetDependencies
2022-09-13 13:13:38 +09:00
Dean Herbert
9c2b0efbc7
Merge pull request #20262 from smoogipoo/scoreprocessor-computeaccuracy
...
Add `ScoreProcessor.ComputeAccuracy()`
2022-09-13 11:55:02 +09:00
Salman Ahmed
0ca4be5e5b
Fix one more inspection
2022-09-13 03:45:31 +03:00
OliBomby
fd48249eef
fix with new event
2022-09-13 02:20:52 +02:00
Salman Ahmed
69b9bae3b3
Merge branch 'master' into scoreprocessor-computeaccuracy
2022-09-13 03:09:52 +03:00
Salman Ahmed
a20c97d072
Merge branch 'master' into fix-skin-animation-edge-case
2022-09-13 02:26:55 +03:00
Salman Ahmed
5fba21d658
Rename parameter to clarify purpose
2022-09-13 02:21:01 +03:00
OliBomby
718f8c4ee2
revert the fix
2022-09-13 01:09:42 +02:00
Salman Ahmed
07f577a0c6
Fix beatmap listing potentially showing duplicate beatmap cards
2022-09-13 01:39:21 +03:00
OliBomby
8400de4b2e
invoking hitobject updated before invoking removed
2022-09-12 17:50:11 +02:00
ansel
8cbc0502ae
Inline CalculateEffect
2022-09-12 15:51:18 +03:00
Dean Herbert
88107108ee
Add ability to flick notifications to the right to store for later
2022-09-12 20:20:57 +09:00
Dean Herbert
802c5629c0
Merge branch 'master' into notification-fling
2022-09-12 20:09:21 +09:00
Dean Herbert
2b4b14ca99
Fix SongProgress invalidating too often
...
This regressed with https://github.com/ppy/osu/pull/19556 . Rather than
try and figure whether that new container needs to handle size
differently, this is a simple solution.
Height was taken from a runtime check (maxes out at about 14.5).
Closes #20235 .
2022-09-12 20:06:53 +09:00
Dean Herbert
f31deaef7c
Simplify skin bindable flow
...
Now, nothing touches the configuration apart from `OsuGame`, making
everything else flow better and avoid weird cyclic set bugs.
Closes https://github.com/ppy/osu/issues/20234 .
2022-09-12 19:51:50 +09:00
