Commit Graph

56420 Commits

Author SHA1 Message Date
674ae9e742 Refactor DrawableSliderHead to never update the drawable position
Slider heads are guaranteed to always be drawn at (0,0). This fixes
weird behaviour in the editor, but also simplifies things in the
process. Win-win.

Closes #20644.
2022-10-26 15:26:22 +09:00
614011d612 Update TestSceneObjectOrderedHitPolicy to provide better output 2022-10-26 15:25:50 +09:00
72b594d72e Merge pull request #20941 from peppy/fix-distance-snap-offset
Offset start of distance snap grid drawing if reference object's start time doesn't align
2022-10-26 13:46:31 +09:00
a8393a81a4 Merge pull request #20922 from ekrctb/fix-mania-hold-note-fade-out
Fix hold note disappearing instantly without fade out
2022-10-26 13:44:40 +09:00
2016d33055 Offset start of distance snap grid drawing if reference object's start time doesn't align
Closes #20938.
2022-10-26 13:11:26 +09:00
cab9a1c012 Add test coverage of distance snap grid failing visually 2022-10-26 13:10:54 +09:00
5f10b81af1 Move distance snap grid test cursor behind grid to better visualise centre-points 2022-10-26 13:10:54 +09:00
ccbc39910c Merge pull request #20934 from bdach/fix-taiko-flashlight-regression
Fix invalid taiko flashlight size calculation
2022-10-26 12:11:48 +09:00
7249542167 Merge pull request #20912 from LittleEndu/carousel-do-not-select-random
Make beatmap carousel select nearest to selection when selection was filtered
2022-10-26 11:40:56 +09:00
0ed40c8676 Merge pull request #20937 from Joehuu/listing-scroll-to-top-tags/source
Scroll beatmap listing to top when searching via tags/source
2022-10-26 11:37:09 +09:00
d9d083752a Clamp backwards index to total current items to fix edge case of item removal 2022-10-26 11:03:11 +09:00
8505848b1a Scroll beatmap listing to top when searching via tags/source 2022-10-25 18:06:49 -07:00
181c7d1d6e Merge pull request #20901 from peppy/add-editor-object-clone
Add ability to clone objects in the editor
2022-10-25 22:16:07 +02:00
f5ca447b8e Rename one more "{duplicate -> clone}" reference 2022-10-25 21:34:41 +02:00
bcdf24b972 Merge branch 'master' into add-editor-object-clone 2022-10-25 21:33:52 +02:00
2ddb94db64 Merge pull request #20903 from peppy/beat-snap-divisor-hotkey
Add ability to use `Shift`+`Number` to set current beat divisor in editor
2022-10-25 21:06:59 +02:00
3d31c9bbc5 Merge branch 'master' into beat-snap-divisor-hotkey 2022-10-25 20:32:32 +02:00
974f22dd97 Attempt to make flashlight code slightly more legible 2022-10-25 20:15:19 +02:00
e3bc1126d7 Fix invalid flashlight size calculation
This regressed in #20714. One usage of `getSizeFor(0)` was replaced by
`adjustSize(GetSize())`, but another usage of `getSizeFor(Combo.Value)`
was replaced by `adjustSize(Combo.Value)`, which is not correct, since
`adjustSize()` is expecting to receive a combo-based size, rather than a
combo value directly.
2022-10-25 20:03:22 +02:00
93e9b4a2c5 Add failing test case 2022-10-25 20:02:28 +02:00
521fbd2ea3 Merge pull request #20345 from mk56-spn/Freeze_frame_implementation
Add "Freeze Frame" mod
2022-10-26 01:28:23 +09:00
0b8b322322 Fix tests 2022-10-25 19:48:33 +09:00
92ab39f5c2 Fix hold note disappear instantly 2022-10-25 19:16:23 +09:00
cf3bf41b49 Harden and simplify logic to avoid weird issues 2022-10-25 18:57:15 +09:00
5a537f13b5 Merge pull request #20914 from peppy/allow-distance-grid-snap
Allow both distance snap and grid snap to be applied at the same time
2022-10-25 16:04:11 +09:00
cb9fc78255 Merge pull request #20916 from peppy/sample-documentation
Rename some pieces and better document `SampleBankInfo`
2022-10-25 15:59:19 +09:00
f4aae9138b Remove Incompatibility with HD 2022-10-25 08:48:45 +02:00
da93849b80 Rename some pieces and better document SampleBankInfo 2022-10-25 14:55:33 +09:00
a9755295e4 Update tests in line with new behaviour 2022-10-25 14:32:08 +09:00
02a3f8c17f Allow both distance snap and grid snap to be applied at the same time 2022-10-25 14:09:22 +09:00
22ea9a8ab4 Add early return of carousel group has no items 2022-10-25 13:34:22 +09:00
279ef556e3 Fix typon in comment 2022-10-25 13:27:26 +09:00
588fc750cd Change approach circles to all appear at the same time, but don't adjust AR 2022-10-25 13:26:32 +09:00
3d72ff28c3 Add test scene for "Freeze Frame" mod 2022-10-25 13:25:38 +09:00
2456a18bc1 Rewrite implementation to avoid duplicated LINQ returns 2022-10-25 12:48:17 +09:00
8e4f5381e3 Add top level test coverage of editor shortcuts 2022-10-25 12:03:46 +09:00
1b42f5ec6e Add test coverage of BeatDivisorControl key bindings 2022-10-25 11:51:31 +09:00
4d4f6e25ba Rename to "clone" instead of "duplicate" 2022-10-25 11:43:23 +09:00
1e579e06f8 Fix duplicate working incorrectly if there is no selection currently made 2022-10-25 11:42:12 +09:00
da74690ec9 Add test coverage of clone operations 2022-10-25 11:38:58 +09:00
f6f30eec0b Merge pull request #20810 from peppy/scoring-test-scene
Add test scene as environment to test changes to score algorithms
2022-10-25 11:19:00 +09:00
b95091fbb0 Move test to improve diff readability 2022-10-24 22:55:09 +03:00
9def12c60b Write new tests 2022-10-24 22:50:56 +03:00
5a118cfdc3 Merge branch 'master' of https://github.com/ppy/osu into carousel-perform-selection
 Conflicts:
	osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapCarousel.cs
2022-10-24 21:40:48 +03:00
6ac7518df4 Merge pull request #20904 from peppy/fix-tournament-seeding-editor-crash
Fix crash when exiting seeding editor too soon
2022-10-24 19:25:20 +02:00
3f6b8ec38c Merge branch 'master' into fix-tournament-seeding-editor-crash 2022-10-24 18:50:49 +02:00
e3e88d0d50 Merge pull request #19048 from ggliv/directoryselector-hidden-toggle
Add hidden item toggle to directory/file selectors
2022-10-24 16:28:47 +09:00
14704fd07c Fix crash when exiting seeding editor too soon
Closes https://github.com/ppy/osu/issues/20783.
2022-10-24 16:08:50 +09:00
f08270f6b0 Fix incorrect maxBaseScore accounting due to silly oversight 2022-10-24 15:54:09 +09:00
247cf589aa Merge branch 'master' into directoryselector-hidden-toggle 2022-10-24 15:33:10 +09:00