678b18dde6
Ensure any non-MemoryStream streams are closed as part of ImportTask
2022-06-20 15:29:56 +09:00
dd93c7359e
Update xmldoc for importFromArchive method
2022-06-20 15:25:43 +09:00
92f1a2958c
Rename Import(TModel) to ImportModel to differentiate from other import methods
2022-06-20 15:18:07 +09:00
a6c8a832aa
Remove Import(ArchiveReader) and redirect existing usages to Import(ImportTask)
2022-06-20 15:14:57 +09:00
7daab2d45b
Merge branch 'master' into skin-editor-transform-fix
2022-06-20 14:10:01 +09:00
329f1a0822
Add test coverage of original fail case and improve test reliability and code quality
2022-06-20 14:08:05 +09:00
a5bc769243
clear skineditor selected components on hide
2022-06-19 14:34:52 -04:00
36df1da57f
Revert "stop component transform when skineditor is hidden"
...
This reverts commit 48ffd6aeb5
2022-06-19 14:26:02 -04:00
3ab8158b92
Do not try to set ruleset from beatmap if it's a dummy
2022-06-19 20:08:39 +02:00
93b3ede2a0
Always use beatmap ruleset in editor gameplay test mode
...
Fixes cases where opening a convertible beatmap (so any osu! beatmap)
with the game-global ruleset being set to anything but osu! would result
in opening the editor gameplay test mode with the game-global ruleset
rather than the beatmap's.
2022-06-19 19:30:40 +02:00
9023fdc947
Merge branch 'master' into reidrect-graceful-exit
2022-06-19 13:43:15 +02:00
495d747da5
Fix mismatching braces in comment
2022-06-19 13:42:45 +02:00
6515b249ec
Change data migration to do an immediate exit, rather than attempted exit
2022-06-19 12:39:58 +09:00
50e40756c4
Rename GracefullyExit to AttemptExit
2022-06-19 12:34:44 +09:00
a2e17941e5
Merge branch 'master' into timing-offset-adjust-seek-only-at-start
2022-06-19 01:27:44 +03:00
2a95715652
Merge branch 'master' into fix-input-regression
2022-06-18 19:44:53 +02:00
f7fc456bb1
Merge branch 'master' into reidrect-graceful-exit
2022-06-18 19:37:53 +03:00
3902dc64f0
Fix adjusting offset via button seeking to timing point's offset unexpectedly
...
This was added with the intention of tracking the offset when already at
the start (the most common case when you're using the tap timing
wizard), but was also seeking when the user may be much further beyond
or before it.
Addresses https://github.com/ppy/osu/discussions/18741#discussioncomment-2975051 .
2022-06-19 01:35:45 +09:00
b2663d9399
Update xmldoc to suggest that GracefullyExit may be overridden
2022-06-19 01:14:48 +09:00
3fa8c19acd
Merge branch 'master' into latency-certifier/hidden-cursor
2022-06-19 00:31:11 +09:00
a5e5172b91
Fix BlueprintContainer eating input from skin editor buttons
2022-06-18 18:28:36 +03:00
56abe54fe6
Redirect graceful exiting to standard exit flow
...
Rather than doing a completely forced exit as we were, this will now
follow a more standard flow with the ability for the user to abort along
the way. This is more in line with how I wanted this to work.
Note that this means a confirmation is now shown. It has been discussed
in the past that this confirmation should only show when there's an
ongoing action implies the user may want to cancel the exit. For now I
think this is fine.
Addresses
https://github.com/ppy/osu/discussions/18399#discussioncomment-2811311
2022-06-18 23:43:46 +09:00
5917c70127
Merge branch 'master' into multi-song-select-operation
2022-06-18 11:58:13 +02:00
f6a3047596
Merge branch 'master' into editor-metadata-name-unification
2022-06-18 10:22:52 +02:00
77e7e4ecb2
Fix selection being blocked after early return
2022-06-18 14:28:30 +09:00
bd5037fcad
Fix new hitobject placements not taking on the existing sample settings
...
Similar to velocity / difficulty points, a user expectation is that
volume and sample settings will be transferred to newly placed objects
from the most recent one.
Closes https://github.com/ppy/osu/issues/18742 .
2022-06-18 13:49:59 +09:00
8a1d11fefb
Cancel previous metronome sound playback on pause
2022-06-18 04:07:21 +03:00
e04df371d1
Merge branch 'master' into multi-song-select-operation
2022-06-18 08:51:24 +09:00
14cdb01fd8
Revert unintended change
2022-06-18 08:49:48 +09:00
48ffd6aeb5
stop component transform when skineditor is hidden
2022-06-17 11:28:58 -04:00
4bc26dbb48
Merge pull request #18743 from smoogipoo/nullable-by-default
...
Enable NRT by default
2022-06-17 23:18:35 +09:00
5d93db1522
Merge pull request #18726 from peppy/disclaimer-stop-handling-after-suspend
...
Fix `Disclaimer` screen handling user change events after initial display
2022-06-17 18:28:06 +09:00
1900480d51
Inline animation method
2022-06-17 17:06:06 +09:00
869db52540
Tie loading layer to ongoing operation state
2022-06-17 17:05:23 +09:00
e51babdb96
Change heart animation flow to be more correct
2022-06-17 17:01:11 +09:00
fd9902e816
Manual #nullable processing
2022-06-17 16:38:35 +09:00
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
ea191da496
Merge pull request #18728 from peppy/fix-unsafe-sample-playback
...
Fix unsafe sample playback in `GameplaySampleTriggerSource`
2022-06-17 12:26:46 +09:00
6ff6a3f5b3
Rename and document chooserPath
2022-06-16 21:51:31 +02:00
6f2f4dda37
Merge branch 'master' into fix-up-down
2022-06-16 21:44:56 +02:00
db02cb81c5
Fix file chooser path not opening home directory initially
2022-06-16 20:48:17 +03:00
f7a27b412a
Revert "Let latency certifier buttons steal hover from area"
...
This reverts commit beb0331640
2022-06-16 20:35:30 +03:00
e4ddf03ad6
Fix toolbar music button handling keys while not hovered
2022-06-16 20:22:57 +03:00
8e088140b2
Reword comment since IRequireHighFrequencyMousePosition isn't the issue
2022-06-16 20:09:10 +03:00
beb0331640
Let latency certifier buttons steal hover from area
2022-06-16 20:00:30 +03:00
ed6817ae6a
Allow switching between latency and menu cursor using IProvideCursor
2022-06-16 19:46:31 +03:00
52538dc708
Refactor LatencyCursorContainer to become a cursor container
2022-06-16 19:46:04 +03:00
47d0ecf5e8
Merge branch 'master' into editor-metadata-name-unification
2022-06-16 18:53:23 +03:00
6aee689586
Fix previous file lookup not using metadata properties
2022-06-16 18:50:38 +03:00
f1081db953
Fix background/track implicitly renamed on initial load
2022-06-16 18:48:32 +03:00
