d9605e8070
Remove test scene description
2021-05-08 18:18:23 +03:00
fe86ee629e
Fix temp files from beatmap listing imports not being cleaned up
...
As reported in #12718 , it turns out that temporary files from beatmap
set downloads performed via the beatmap listing overlay could remain in
the user's filesystem even after the download has concluded.
The reason for the issue is a failure in component integration.
In the case of online downloads, files are first downloaded to a
temporary directory (`C:/Temp` or `/tmp`), with a randomly generated
filename, which ends in an extension of `.tmp`.
On the other side, `ArchiveModelManager`s have a `ShouldDeleteArchive()`
method, which determines whether a file should be deleted after
importing. At the time of writing, in the case of beatmap imports the
file is only automatically cleaned up if the extension of the file is
equal to `.osz`, which was not the case for temporary files.
As it turns out, `APIDownloadRequest` has a facility for adjusting the
file's extension, via the protected `FileExtension` property. Therefore,
use it in the case of `DownloadBeatmapSetRequest` to specify `.osz`,
which then will make sure that the `ShouldDeleteArchive()` check in
`BeatmapManager` picks it up for clean-up.
2021-05-08 17:09:14 +02:00
13bd3e95a9
Merge pull request #12698 from peppy/fix-editor-slider-input-handling
2021-05-08 17:08:48 +02:00
01d732bb65
Revert "Refactor SliderSelectionBlueprint to not reference blueprint pieces for input handling"
...
This reverts commit 54fe10c82a
2021-05-08 23:33:03 +09:00
63e267a3be
Revert "Trim redundant this qualifier"
...
This reverts commit df630d9428
2021-05-08 23:32:52 +09:00
942281d6b0
Merge branch 'master' into fix-editor-slider-input-handling
2021-05-08 14:56:18 +02:00
df630d9428
Trim redundant this qualifier
2021-05-08 14:53:19 +02:00
26c0010fe6
Fix test not handling 0 beatmap sets
2021-05-08 13:03:50 +03:00
dca5efc59a
Remove no longer necessary ruleset info requirement
2021-05-08 13:00:39 +03:00
43090067da
Use BeatmapDifficultyCache.GetBindableDifficulty(...) instead
2021-05-08 12:59:59 +03:00
0410edecaf
Refactor StarRatingDisplay to be mutable with a current bindable
2021-05-08 12:55:34 +03:00
cd25d76dbe
Merge branch 'master' into localisation-proof-of-concept
2021-05-08 18:11:07 +09:00
b4801faf32
Pass ruleset info to constructor instead
...
Follows the way working beatmap is passed, not sure why mods are passed as a bindable though, don't wanna bother too much with that.
2021-05-08 11:57:13 +03:00
169a283402
Add visual test scene
2021-05-08 11:47:18 +03:00
7b7e7a86bf
Allow null logo facade
2021-05-08 11:47:18 +03:00
0f08c2a479
Add star rating display underneath the beatmap metadata
2021-05-08 11:47:18 +03:00
8c564a69ed
Fix InvalidOperationException when exiting a map at the end
2021-05-07 21:11:03 -04:00
495eb04e2f
Merge pull request #12488 from Denrage/add-missing-author-links
...
Add missing author links in Beatmap Details
2021-05-08 05:41:40 +09:00
b475c1a364
Merge pull request #12709 from peppy/update-framework
...
Update framework
2021-05-07 20:44:59 +09:00
5b2f786f97
Update framework
2021-05-07 19:16:00 +09:00
a1aeac5677
Remove remaining cruft from SkinnableAccuracyCounter
2021-05-07 18:12:18 +09:00
68de870986
Merge branch 'skin-components-bind-outwards-health' into remove-hud-overlay-unused-pieces
2021-05-07 18:11:14 +09:00
9fe6e1096a
Remove cruft from SkinnableHealthDisplay
2021-05-07 18:11:08 +09:00
111b501ced
Revert accidental removal of UTF-8 BOM
2021-05-07 18:04:38 +09:00
1cb10c2a22
Remove unnecessary binding logic from HUDOverlay
2021-05-07 17:51:46 +09:00
a7acecc52b
Merge branch 'skin-components-bind-outwards-health' into remove-hud-overlay-unused-pieces
2021-05-07 17:51:41 +09:00
3044b1c432
Add missing cache rules
2021-05-07 17:50:44 +09:00
6c255a0572
Fix drain start time being weirdly incorrect
2021-05-07 17:47:33 +09:00
8e78cac058
Fix HealthProcessor cached as derived type in test
2021-05-07 17:31:29 +09:00
04d35826a3
Merge branch 'skin-components-bind-outwards-accuracy' into remove-hud-overlay-unused-pieces
2021-05-07 17:25:39 +09:00
84a4ff333e
Update skin editor test scene to cache a ScoreProcessor
2021-05-07 17:22:56 +09:00
755588258e
Update HealthDisplay components to use DI to attach data source
2021-05-07 17:22:45 +09:00
4ac234bf7f
Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-accuracy
2021-05-07 17:15:57 +09:00
6dc591fc44
Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-score-display
2021-05-07 17:15:37 +09:00
8d04eba960
Merge pull request #12703 from frenzibyte/editor-wrong-track
...
Fix editor clock not using the beatmap's virtual track when creating one
2021-05-07 17:12:16 +09:00
9d27b11e49
Update skin editor test scene to cache a ScoreProcessor
2021-05-07 17:10:31 +09:00
22677cfeaf
add CreateBorder method in markdown table cell
2021-05-07 14:54:46 +07:00
d92e593ddd
extract out table head and body border into separate component
2021-05-07 14:47:46 +07:00
64e9c5e9ba
add return xmldoc in markdown unordered list
2021-05-07 14:41:27 +07:00
79a1d7b2b3
simplify CreateEmphasisedSpriteText
2021-05-07 14:40:01 +07:00
17b8963cf8
simplify CreateSpriteText in markdown table cell
2021-05-07 14:38:19 +07:00
3524cb7924
simplify CreateSpriteText in markdown heading
2021-05-07 14:36:35 +07:00
01eff7f316
Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-score-display
2021-05-07 16:30:08 +09:00
93f10330e3
Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-accuracy
2021-05-07 16:29:10 +09:00
ad398165a2
Update AccuracyCounter components to use DI to attach data source
2021-05-07 16:27:25 +09:00
17b93361d5
Merge branch 'master' into skin-components-bind-outwards
2021-05-07 16:20:24 +09:00
a2e4fb5b6b
Update ScoreCounter components to bind outwards
2021-05-07 16:16:48 +09:00
fc2a527e9d
Revert "Guard against potentially null track if ever"
...
This reverts commit b1134c3857
2021-05-07 09:57:08 +03:00
7c4e54a1d4
Unrevert null-colaescing/conditionals removal
2021-05-07 09:54:14 +03:00
5b003750f8
change CreateListItem method in OsuMarkdownContainer
2021-05-07 13:20:48 +07:00
