Commit Graph

59284 Commits

Author SHA1 Message Date
6c5ccdfd90 Merge branch 'master' into optimise-search 2023-03-07 22:07:29 +01:00
942feb5550 Merge pull request #22747 from mk56-spn/make_skin_reset_dangerous
Make reverting a skin in the skin editor a dangerous action
2023-03-07 21:42:01 +01:00
5213bfa5c9 Merge branch 'master' into make_skin_reset_dangerous 2023-03-07 21:06:44 +01:00
70ce5ada7a Merge pull request #22797 from ItsShamed/hud/player-components
Add score player avatar and flag to HUD
2023-03-07 20:21:04 +01:00
cfafa8af8c Merge branch 'master' into hud/player-components 2023-03-07 19:44:12 +01:00
7ade525eef Display corner radius setting as percentage 2023-03-07 19:43:52 +01:00
6d94b08415 Merge pull request #22806 from peppy/fix-video-fade-out
Fix storyboard videos not fading out on completion
2023-03-07 18:42:16 +01:00
97bee4db89 Fix localisations 2023-03-07 18:07:53 +09:00
26ef7c2637 Rename confirmation dialog class to mention revert not reset 2023-03-07 18:07:46 +09:00
55467fcbe3 Update xmldoc for DangerousActionDialog to match new behaviour 2023-03-07 18:07:46 +09:00
dc2945f4f8 Move avatar user loading to BDL also 2023-03-07 17:39:21 +09:00
5af41bb1c8 Move filter matching code into own method to simplify early returns 2023-03-07 17:24:17 +09:00
2a9e0317a8 Merge pull request #22710 from frenzibyte/mobile-local-framework-reference
Add local mobile framework reference support
2023-03-07 17:12:35 +09:00
5e90b67be0 Move GameplayState usage to BDL 2023-03-07 17:01:29 +09:00
d98199961b Adjust default sizing to fit a bit better with existing elements 2023-03-07 17:00:10 +09:00
f7f1dff647 Fix incorrect case of localisable string for "corner radius" 2023-03-07 16:45:33 +09:00
2cce785fa5 Fix storyboard videos not fading out on completion
Closes https://github.com/ppy/osu/issues/22802.

Stable uses a 1,000 ms fade-in / out. Rather than matching that, I've
stuck with 500ms (what lazer was already using for the fade-in) because
I think it feels better.

Tested using the beatmap linked in the issue thread.
2023-03-07 15:54:35 +09:00
fc0e27fb15 style: use normalised CornerRadius values 2023-03-06 20:11:52 +00:00
952814604e style: fix late night oopsies 2023-03-06 20:06:56 +00:00
ff59a236ae Merge pull request #22775 from peppy/dont-filter-results-on-sort-mode
Don't filter away results with missing data when using "Date Submitted" or "Date Ranked" sort modes
2023-03-06 18:47:41 +01:00
ec15e2b9cc Merge branch 'master' into dont-filter-results-on-sort-mode 2023-03-06 17:57:47 +01:00
1fcf41379d Added maintainability patch by bdach 2023-03-06 16:20:36 +01:00
3a240aaa5f style: use 64 radius 2023-03-06 10:27:59 +00:00
87d0bef313 Use nullable comparison helper method instead of manual implementation 2023-03-06 15:16:32 +09:00
ddee6400df test: add coverage for Player{Avatar,Flag} 2023-03-05 23:46:51 +00:00
07bde4990d feat: implement PlayerAvatar 2023-03-05 23:17:39 +00:00
20a610ea6c style: a NRT pass on UpdateableFlag 2023-03-05 23:15:58 +00:00
654eacd449 feat(l10n): localise CornerRadius 2023-03-05 23:10:42 +00:00
082bfe3621 refactor: SkinnableAvatar to PlayerAvatar 2023-03-05 23:09:02 +00:00
908651cc11 make ResetConfirmDialog properly utilise its parent's logic
Adjust name of `DeleteAction` to `DangerousAction`
2023-03-05 20:57:26 +01:00
778cde8932 Merge pull request #22790 from Joehuu/fix-android-external-links
Fix external links not working on Android
2023-03-05 22:12:57 +09:00
77257398db Merge pull request #22787 from bdach/skin-editor-screen-transitions
Fix several issues with skin editor behaviour on screen transitions
2023-03-05 22:00:14 +09:00
d120638e68 Use manifest overlay and merger for intent query specs
Co-authored-by: Susko3 <Susko3@protonmail.com>
2023-03-05 13:17:46 +01:00
5d6ab5f465 Add mailto scheme to intent queries 2023-03-04 16:07:29 -08:00
92f94278c1 Fix external links not working on Android 2023-03-04 13:35:34 -08:00
b0cd801405 fix code quality 2023-03-04 19:34:22 +01:00
5146f7c978 using array again in GetSearchableTerms 2023-03-04 16:49:46 +01:00
70a925aab1 added extra early-returns 2023-03-04 16:49:33 +01:00
b90c389ff0 using List instead of Span in GetSearchableTerms 2023-03-04 15:42:35 +01:00
3185418834 Add benchmarks for carousel beatmap filter 2023-03-04 15:14:22 +01:00
60cdd3c070 Clear components sidebar unconditionally on every target change
Fixes the working layer dropdown lingering after exiting from a
skinnable screen to a non-skinnable one.
2023-03-04 14:10:05 +01:00
9d4bb2ecf7 Add failing test coverage for clearing sidebar contents 2023-03-04 14:08:50 +01:00
d233f3a3ab Show non-skinnable screen placeholder at higher level 2023-03-04 13:49:10 +01:00
49e298e304 Accept ISerialisableDrawableContainer directly in SkinBlueprintContainer
An end result of #22674 is that `SkinBlueprintContainer`s are only ever
created by supplying a `SkinComponentsContainer` to them. However,
`SkinBlueprintContainer` still contained remnants of code that suggested
it was designed to handle cases where more than the drawable supplied to
it contained more than one `ISerialisableDrawableContainer`, or even
zero.

The zero path is totally dead right now (because every
`SkinComponentsContainer` is *by necessity* an
`ISerialisableDrawableContainer`), and the more-than-one path is dead
*for now* (and potentially forever?). Therefore, just hard-couple
`SkinBlueprintContainer` to receive a single target container.
2023-03-04 13:33:21 +01:00
2f25fb4083 Move NonSkinnableScreenPlaceholder to outer scope 2023-03-04 13:22:43 +01:00
15409b9c15 Fix skin selection not clearing on exit to non-skinnable screen 2023-03-04 13:18:34 +01:00
3dd3b5e77a Add failing test case 2023-03-04 13:17:54 +01:00
d5ba5eed88 fix(SkinnableAvatar): init avatar.CornerRadius 2023-03-03 23:47:22 +00:00
866987d6e1 Merge pull request #22776 from peppy/fix-mania-upscroll
Fix upwards scroll direction not working with recent hold note display changes
2023-03-03 21:37:51 +01:00
d39b8c7c23 fix(SkinnableAvatar): update outdated interface 2023-03-03 19:35:45 +00:00