Commit Graph

48369 Commits

Author SHA1 Message Date
6e531a574d Merge pull request #16594 from peppy/realm-subscription-tracking
Add tracking of total realm subscriptions
2022-01-25 16:46:53 +09:00
0d575006fb Merge pull request #16605 from peppy/fix-collection-db-migrate-crash
Fix crash when trying to migrate collection database that doesn't exist
2022-01-25 16:25:15 +09:00
7f2e66298b Merge branch 'master' into realm-subscription-tracking 2022-01-25 16:03:21 +09:00
1c6ad56821 Merge pull request #16595 from peppy/realm-block-timeout-assert-failure
Fix a failed `BlockAllOperations` leaving update realm in unretrieved state
2022-01-25 16:03:13 +09:00
a46b06ffe8 Merge branch 'master' into realm-subscription-tracking 2022-01-25 15:56:35 +09:00
fc58b202b1 Fix crash when trying to migrate collection database that doesn't exist 2022-01-25 15:45:23 +09:00
ae0fea8e26 Fix compilation issues due to misnamed fild 2022-01-25 15:29:45 +09:00
47a13c2eb0 Merge pull request #16603 from peppy/update-framework
Update framework
2022-01-25 15:15:49 +09:00
35e1c7de7d Merge branch 'master' into realm-block-timeout-assert-failure 2022-01-25 15:05:11 +09:00
5fb9b58c9b Add tracking of total subscriptions 2022-01-25 14:51:41 +09:00
05a2d7fbfe Merge pull request #16591 from peppy/fix-editor-slider-velocity-saving
Don't include nested hit objects' `DifficultyControlPoints` in legacy encoder logic
2022-01-25 14:50:09 +09:00
bda77fb6b3 Merge branch 'master' into realm-block-timeout-assert-failure 2022-01-25 14:47:34 +09:00
56d7d81465 Fix broken test due to SynchronizationContext never running expected work 2022-01-25 14:47:21 +09:00
bfa521bdd2 Merge pull request #16593 from peppy/realm-clean-up
Clean up realm naming
2022-01-25 14:33:53 +09:00
b2114bd2f0 Merge pull request #16601 from peppy/fix-storage-migration-test-failures
Fix `TestMigration` failing due to changes in realm migration logic
2022-01-25 14:33:35 +09:00
8adf65d2ac Merge pull request #16602 from peppy/restore-missing-files-on-import
During import if files are found to be missing, ensure they are restored
2022-01-25 14:31:53 +09:00
5872dabf60 Fix incorrect flag to options conversion 2022-01-25 14:16:15 +09:00
86c844bd58 Update remaining usages of GetSuitableHost in template projects 2022-01-25 14:15:29 +09:00
8116806db3 Add test coverage of calling BlockAllOperations a second time after timeout 2022-01-25 14:00:58 +09:00
9ad4d66e4d Merge branch 'realm-clean-up' into realm-block-timeout-assert-failure 2022-01-25 13:58:36 +09:00
a5c76a9647 Fix a few more cases of "context" terminology usage 2022-01-25 13:56:47 +09:00
dd2caea694 Update GetSuitableHost usages in line with new HostOptions 2022-01-25 13:52:02 +09:00
df1297ade6 Update framework 2022-01-25 13:50:41 +09:00
bbcc149e2e During import if files are found to be missing, ensure they are restored
This is one step closer to sanity in terms of physical files. As per the
comment I have left in place, we really should be checking file sizes or
hashes, but to keep things simple and fast I've opted to just cover the
"missing file" scenario for now.

Ran into this when testing against a foreign `client.realm` by:
- Noticing a beatmap doesn't load
- Deleting said beatmap
- Downloading via beatmap overlay
- Beatmap is restored but still doesn't work

Note that I've kept the logic where this will undelete an existing
import rather than create one from fresh, as I think that is beneficial
to the user (ie. it will still keep any linked scores on restore).
2022-01-25 13:44:54 +09:00
7d63999eef Merge pull request #16473 from mk56-spn/Liswiera-FL-changes
Add method of adjusting flashlight radius in flashlight mod
2022-01-25 13:16:39 +09:00
d7342880f5 Update remaining cases of clashes with realm.Write and realm.RegisterForNotifications 2022-01-25 13:09:48 +09:00
e23b10e6a5 Update remaining cases of clashing variable name in realm.Run(realm.. 2022-01-25 13:04:05 +09:00
3e5c9e8436 Fix cases of Access instead of Realm 2022-01-25 12:58:15 +09:00
2d34831b5f Fix TestMigration failing due to changes in realm migration logic
Fixes failures as seen at https://github.com/ppy/osu/runs/4927916031?check_suite_focus=true.
2022-01-25 12:54:40 +09:00
8c3fbb6eb4 Merge branch 'master' into Liswiera-FL-changes 2022-01-24 21:32:36 +01:00
2375420d4c Tweak allowable ranges of size multiplier 2022-01-24 21:32:31 +01:00
4a13c93ca7 Disallow zero size multiplier in flashlight implementations 2022-01-24 21:03:03 +01:00
a227af75ed Simplify flashlight parameter passing flow 2022-01-24 21:03:02 +01:00
5874475dff Extract DefaultFlashlightSize to base flashlight class 2022-01-24 21:03:02 +01:00
a7c0d507ce Rename flashlight settings to be more accurate 2022-01-24 21:03:02 +01:00
da771044a7 Merge branch 'master' into realm-clean-up 2022-01-24 19:15:31 +01:00
d544c52f3c Merge pull request #16548 from peppy/music-controller-less-population
Remove pointless initial `MusicController` beatmap set population
2022-01-24 19:12:56 +01:00
6f4c337a56 Fix a failed BlockAllOperations leaving update realm in unretrieved state
If the operation timed out on..

```csharp
   throw new TimeoutException(@"Took too long to acquire lock");
```

..from an update thread, it would not restore the update context.

The next call would then fail on the assert that ensures a non-null
context in such cases.

Can add test coverage if required.
2022-01-24 20:53:29 +09:00
3bc86ee68f Merge branch 'master' into music-controller-less-population 2022-01-24 20:44:37 +09:00
f30894840c Update terminology to realm "instance" rather than "context"
This matches the terminology used by realm themselves, which feels
better.
2022-01-24 20:38:38 +09:00
6eb2c28e41 Rename RealmContextFactory to RealmAccess 2022-01-24 20:38:07 +09:00
bb54ad9ad8 Merge pull request #16547 from peppy/realm-stable-subscriptions
Fix realm subscriptions getting lost after a context recycle
2022-01-24 20:20:04 +09:00
94ad7abfd6 Merge pull request #16590 from peppy/realm-migrate-on-failure
Allow realm migration to run again if interrupted halfway
2022-01-24 20:19:52 +09:00
c3758047fd Don't include nested hit objects' DifficultyControLPoints in legacy encoder logic
The editor doesn't currently propagate velocity to nested objects. We're
not yet sure whether it should or not. For now, let's just ignore nested
objects' `DifficultyControlPoints` for simplicity.

Note that this only affects osu! ruleset due to the pre-check on
`isOsuRuleset`.
2022-01-24 19:54:08 +09:00
deaff340d2 Add test coverage of saving velocity 2022-01-24 19:43:18 +09:00
948867898c ModeMultiplier rename 2022-01-24 11:38:52 +01:00
b396d55758 Merge branch 'master' into realm-stable-subscriptions 2022-01-24 19:01:49 +09:00
66c5d77d63 Allow realm migration to run again if interrupted halfway 2022-01-24 18:55:15 +09:00
9afa034296 Fix attempt to revive update thread realm context from non-update thread 2022-01-24 18:36:16 +09:00
b0919722ac Guard against potential exception while blocking realm 2022-01-24 18:25:48 +09:00