789e8b4d8d
Fix multi-spectator test updating state after removing user
...
Removing user triggers `playingUsers.Remove`, but doing so before
updating the state leads to `EndGameplay` being called with `State ==
Playing` rather than `Quit`.
2022-08-06 05:41:26 +03:00
84ef24c341
Fix multi-spectator potentially getting stuck for passed players
2022-08-06 05:41:26 +03:00
9ac322d337
Merge pull request #19587 from peppy/adjust-hit-object-pooling
...
Adjust pooling to reduce stutters during gameplay on unique hit objects
2022-08-05 21:39:41 +09:00
cf362a6b4f
Merge pull request #19529 from peppy/locally-modified-pill
...
Show "locally modified" pill when local modifications have been made
2022-08-05 21:12:13 +09:00
6afff72865
Fix CI inspections / refactor to single enumeration
2022-08-05 20:54:10 +09:00
a682a823f4
Fix test failures where Beatmap is not provided
2022-08-05 18:20:37 +09:00
9a4d0494de
Adjust various pooling defaults to better handle more intense beatmaps
2022-08-05 18:09:07 +09:00
8ae5429602
Adjust slider pooling based on beatmap
...
Handles edge cases like mentioned in https://github.com/ppy/osu/issues/19585 .
2022-08-05 18:08:05 +09:00
a81a2517b2
Merge pull request #19583 from peppy/fix-preview-track-disposal
...
Fix `PreviewTrack`s not being disposed correctly
2022-08-05 15:16:22 +09:00
94ec653420
Add same load-cancel safeties to ensure tracks are disposed in card PlayButton
2022-08-05 14:26:01 +09:00
7c952f8069
Add more test coverage of locally-modified state change
2022-08-05 14:25:10 +09:00
6823282604
Fix PlayButton potentially not disposing an unused PreviewTrack during load
2022-08-05 14:15:27 +09:00
786af81274
Fix PreviewTrack not disposing its owned audio Track
2022-08-05 14:15:01 +09:00
0d73bfa451
Merge pull request #19575 from smoogipoo/solo-score-info-json-cleanup
...
Clean up SoloScoreInfo serialised output
2022-08-04 23:19:21 +09:00
2d9da07eb6
Trim zero values from hit statistics
2022-08-04 19:27:50 +09:00
8ff7770a71
Omit irrelevant data from SoloScoreInfo serialisation
2022-08-04 19:11:39 +09:00
094eaafd43
Split out common conditional check into local static method
2022-08-04 17:26:54 +09:00
81029fe12b
Merge pull request #19574 from smoogipoo/fix-skin-sample-lookup
...
Ensure skin samples are looked up in correct order
2022-08-04 15:37:49 +09:00
c11a24b3ff
Remove unused using
2022-08-04 15:05:52 +09:00
6632367c6d
Ensure skin samples are looked up in correct order
2022-08-04 14:48:12 +09:00
55234e8069
Merge pull request #19558 from bdach/mod-overlay/create-preset
...
Add flow for creating new mod presets
2022-08-04 14:45:57 +09:00
cbe09b51c4
Merge pull request #19552 from andy840119/remove-nullable-disable-in-the-desktop-project
...
Remove nullable disable in the osu.Desktop
2022-08-04 13:07:06 +09:00
ca1b4689cb
Automatically focus name textbox upon add preset popover open
2022-08-03 21:26:35 +02:00
159d3b032c
Rename locals for legibility
2022-08-03 21:23:31 +02:00
82d3fbd51b
Split AddPresetPopover to separate file
2022-08-03 21:22:55 +02:00
ac9321204c
Merge branch 'master' into mod-overlay/create-preset
2022-08-03 21:21:52 +02:00
656c9eb504
Merge pull request #19570 from peppy/more-until-steps
...
Change all filter control button state test to until steps
2022-08-03 21:55:27 +03:00
571a93e1bc
Merge branch 'master' into more-until-steps
2022-08-03 21:25:30 +03:00
8489963abc
Merge pull request #19548 from peppy/more-beat-sync-dependence
...
Improve `IBeatSyncProvider` interface and reduce beatmap track dependence
2022-08-03 20:54:57 +03:00
b00c3a4d6d
Move properties and mark as get-only
2022-08-03 20:31:51 +03:00
7c45c571a0
Merge branch 'master' into more-beat-sync-dependence
2022-08-03 20:22:42 +03:00
844430502b
Replace parantheses with nullable-bool equality operation
2022-08-03 20:11:08 +03:00
8b02c955d8
Give this class a constructor to make sure that message data will always assigned.
2022-08-03 23:17:09 +08:00
1eb8168a8d
Merge pull request #19522 from frenzibyte/improve-download-limit-message
...
Display readable error message when reaching download limit
2022-08-03 23:32:04 +09:00
7022d9e5f8
Fix test step names being too long
2022-08-03 21:13:49 +09:00
bacbf5b7f0
Update existing test expectations
2022-08-03 20:20:06 +09:00
87cc2db624
Merge branch 'master' into improve-download-limit-message
2022-08-03 20:17:02 +09:00
d3954fc583
Use existing localised error message
2022-08-03 20:15:46 +09:00
a32149fda1
Convert interface methods to extension methods
2022-08-03 20:07:55 +09:00
24d84890e4
Change all filter control button state test to until steps
...
There's multiple schedules at play which could be adding multi-frame
delays. let's play it safe and try and fix flaky tests.
Example of `Schedule` which could cause an issue:
392cb352cc/osu.Game/Collections/CollectionDropdown.cs (L77-L78)https://github.com/ppy/osu/runs/7648118894?check_suite_focus=true
2022-08-03 20:03:07 +09:00
b822a6de9e
Merge pull request #19564 from peppy/fix-legacy-song-progress-mouse-blocking
...
Fix `LegacySongProgress` incorrectly blocking mouse input from gameplay
2022-08-03 18:51:59 +09:00
4063f92381
Merge branch 'master' into fix-legacy-song-progress-mouse-blocking
2022-08-03 12:12:58 +03:00
dbdfa90012
Merge pull request #19563 from peppy/realm-migration-safety
...
Change migration logic to ignore realm pipe files regardless of database filename
2022-08-03 12:11:50 +03:00
16ff8d5c38
Use different variable source
2022-08-03 17:47:32 +09:00
6ad6561e1c
Fix LegacySongProgress incorrectly blocking mouse input from gameplay
...
Closes #19555 .
2022-08-03 17:42:29 +09:00
f743dc623f
Change migration logic to ignore realm pipe files regardless of database filename
2022-08-03 17:37:30 +09:00
add2971eb4
Implement preset creation flow with test coverage
2022-08-02 22:05:54 +02:00
7251389e43
Add localisations for add preset button
2022-08-02 22:05:34 +02:00
059a465fe8
Add border to popover for better visual contrast
2022-08-02 22:03:33 +02:00
1b3074d098
Implement popover for creating mod presets
2022-08-02 22:03:33 +02:00
