Commit Graph

33738 Commits

Author SHA1 Message Date
7f30140b7e Add new method handling hit state specifically
Until now UpdateStateTransforms was applying results offsets to
StartTime. This didn't cover the case of a HitObject with duration,
where the call would be made with `StartTime + hitOffset` rather than
`EndTime + hitOffset`.

To resolve this, a new method has been added which should be used to
handle hit-specific state transforms.
2020-11-04 16:13:14 +09:00
c4076cad4b Merge pull request #10667 from peppy/fix-editor-play-after-drag
Fix editor clock not always remaining stopped when dragging timeline
2020-11-04 15:24:22 +09:00
42c543f5b9 Merge branch 'master' into fix-editor-play-after-drag 2020-11-04 14:45:20 +09:00
98c992004b Merge pull request #10660 from peppy/fix-song-select-first-track-looping
Fix looping mode not being set on first track after entering song select
2020-11-04 14:37:27 +09:00
c6779b414e Merge pull request #10611 from peppy/spectator-listing
Add "currently playing" player listing and spectator UI flow
2020-11-04 14:08:11 +09:00
9b2f396006 Merge pull request #10678 from peppy/fix-load-async-after-disposal-beatmap-wedge
Fix LoadComponentAsync calls potentially occuring after beatmap wedge disposal
2020-11-04 13:10:41 +09:00
cfe3218239 Move scheduler call to inside method itself for added safety 2020-11-04 10:23:06 +09:00
29e8e5ab94 Merge branch 'master' into fix-load-async-after-disposal-beatmap-wedge 2020-11-04 10:23:05 +09:00
9dc2ca666d Merge branch 'master' into spectator-listing 2020-11-04 09:30:15 +09:00
a395ca5e15 Merge pull request #10664 from peppy/catcher-moonwalking-in-replays-fix
Fix osu!catch replay conversion applying left movements to wrong frame
2020-11-04 00:17:18 +01:00
4e80f1955c Merge branch 'master' into catcher-moonwalking-in-replays-fix 2020-11-03 23:42:51 +01:00
921f15aa29 Merge pull request #10673 from peppy/editor-waveform-opacity
Add opacity adjustment for waveform editor
2020-11-03 23:42:12 +01:00
3bb86ce127 Merge branch 'master' into editor-waveform-opacity 2020-11-03 23:04:19 +01:00
66e725b6a2 Merge pull request #10674 from peppy/editor-timeline-scroll-mousewheel
Change editor timeline mouse wheel handling to scroll by default (and zoom with alt held)
2020-11-03 23:03:04 +01:00
13f729916a Merge branch 'master' into editor-timeline-scroll-mousewheel 2020-11-03 22:27:35 +01:00
ddf0d75c38 Don't fall through to seek if handling zoom 2020-11-03 21:49:21 +01:00
4b528e80d0 Use AltPressed shorthand 2020-11-03 21:49:04 +01:00
f3d5e7b15a Merge pull request #10680 from peppy/editor-flip-keybinds
Add key bindings for flip and reverse patterns
2020-11-03 21:17:52 +01:00
b0cf6e3333 Merge branch 'master' into editor-flip-keybinds 2020-11-03 20:41:08 +01:00
6437c33e06 Merge pull request #10677 from peppy/fix-catch-banana-animation
Fix osu!catch banana animation not playing due to incorrect lifetimes
2020-11-03 20:24:09 +01:00
211510fe9a Fix undesirable vertical spacing in currently playing display 2020-11-03 19:12:03 +01:00
86d283ebf4 Adjust layout slightly to avoid specifying width twice 2020-11-03 19:03:48 +01:00
18428dff8e Ensure hotkey actions are executable in handler 2020-11-03 18:01:12 +01:00
d45520be5e Fix incorrect return types on test methods 2020-11-03 21:23:10 +09:00
83c004bbde Add key bindings for flip and reverse patterns 2020-11-03 21:10:31 +09:00
1b2bd6a8c9 Remove redundant base call 2020-11-03 20:10:13 +09:00
3e29e468ea Ensure "start watching" button starts in a disabled state 2020-11-03 20:06:42 +09:00
aaffd59dfe Add test step to reset players (to better allow multiple runs of tests) 2020-11-03 20:02:02 +09:00
d4f8c63f9e Fix reference to dummyAPI not using helper property 2020-11-03 19:59:06 +09:00
a3c67aabe2 Merge branch 'master' into spectator-listing 2020-11-03 19:56:25 +09:00
d788931661 Fix LoadComponentAsync calls potentially occuring after beatmap wedge disposal
As seen in https://ci.appveyor.com/project/peppy/osu/builds/36109658/tests.

Also adds cancellation logic for good measure.
2020-11-03 19:53:45 +09:00
9f8ea93068 Fix osu!catch banana animation not playing due to incorrect lifetimes
Closes #10117.
2020-11-03 18:45:21 +09:00
ff2b01fa6f Add test coverage of zoom-then-scroll 2020-11-03 17:22:56 +09:00
ff4dcf065a Update tests 2020-11-03 17:06:33 +09:00
df9ff76f23 Reduce assert to guard in the outwards direction 2020-11-03 16:49:13 +09:00
f701a38e20 Merge branch 'master' into fix-song-select-first-track-looping 2020-11-03 16:48:20 +09:00
c2ffc18379 Change editor timeline mouse wheel handling to scroll by default (and zoom with alt held) 2020-11-03 16:30:11 +09:00
0dcb4ea441 Add handling of opacity to timeline waveform display 2020-11-03 16:07:01 +09:00
7e4314684b Add editor waveform opacity selection to menu 2020-11-03 16:01:14 +09:00
6bf35d5767 Fix editor menu not supporting stateful item drawables 2020-11-03 16:00:07 +09:00
34aa59f237 Fix editor clock not always remaining stopped when dragging timeline
Closes https://github.com/ppy/osu/issues/10461.
2020-11-03 15:00:01 +09:00
71c04472fa Fix osu!catch replay conversion applying left movements to wrong frame 2020-11-03 14:21:19 +09:00
2d1db6a22d Merge pull request #10658 from peppy/spectator-connection-logging
Add very basic connection status logging for spectator streaming client
2020-11-02 20:59:04 +01:00
b152514bc7 Merge branch 'master' into spectator-connection-logging 2020-11-02 20:21:45 +01:00
3fe965346c Merge pull request #10661 from peppy/debounce-update-ternary-states
Debounce calls to UpdateTernaryStates
2020-11-02 18:00:32 +01:00
ab308d28d2 Debounce calls to UpdateTernaryStates
Just something I noticed in passing recently which may help with
reducing performance overhead of some batch operations.
2020-11-03 01:08:36 +09:00
d5c95a8b46 Centralise into methods and add assertions for safety 2020-11-03 00:45:55 +09:00
c3d3856a64 Fix looping mode not being set on first track after entering song select
Closes #10656.
2020-11-02 23:51:02 +09:00
3765c8abb9 Merge pull request #10659 from smoogipoo/fix-editor-seek-transform
Fix editor seek transform seeking too much
2020-11-02 21:52:14 +09:00
c1d9a0c92c Move click action out of user panel 2020-11-02 21:09:47 +09:00