sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-03 22:56:36 +09:00
Code Issues Packages Projects Releases Wiki Activity
60,286 Commits 3 Branches 1 Tag
812df9d652e73c55565a0667f09f8e0e480fcb29
Commit Graph

60286 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Bartłomiej Dach
812df9d652 Add failing test cases for strong object sample playback 2023-05-21 18:57:55 +02:00
Bartłomiej Dach
6d325651dc Propagate samples to drum roll/swell ticks for correct playback 
In d97daee96b, `DrumSampleTriggerSource`
was changed such that in order to play sounds for the user's inputs, the
bank of the normal sound would always be used.

The problem is that in the case of taiko objects which have nested
objects (swells and drum rolls), the samples were not propagated fully
(drum rolls, where only the finish sample was kept, for the purposes of
determining strongability), or not propagated at all (swells) to ticks.

As ticks of both objects are valid return values of
`GetMostValidHitObject()`, this would lead to the drum making no sounds
if the next object was a drum roll or swell, until that drum roll or
swell was completed. To fix, propagate the full set of samples, so that
`DrumSampleTriggerSource` can retrieve the normal sound to copy the bank
from.

Note that this may not necessarily reproduce prior behaviour. This is
because it is not guaranteed that all realised samples for a given
hitobject have the same bank - some may have been overriden locally on a
given hitobject. Previously, the bank would have been retrieved from the
sample control point, wherein there is only one possible bank to use;
however, when deciding the sound to play on the basis of a constructed
hitobject, it is possible that there are cases wherein the hitnormal
sample was overridden on that given hitobject, and in such cases, this
PR would make samples _play_, but not necessarily the _same_ samples
as prior to #23308.

If that turns out to be the case, this will have to be revisited.
 2023-05-21 18:57:01 +02:00
Bartłomiej Dach
5229cf7343 Add failing test cases for drum roll/swell sample playback 2023-05-21 18:57:01 +02:00
Bartłomiej Dach
7fa8a1148d Merge pull request #22716 from peppy/fix-menu-state-display 
Update in line with framework menu handling changes
 2023-05-20 19:10:22 +02:00
Bartłomiej Dach
8e0a97ca49 Remove usage of HasSubmenu 
Property has been removed in the appropriate framework-side PR and
instead folded into `IsActionable`.

See: https://github.com/ppy/osu-framework/pull/5658#discussion_r1114834647
 2023-05-20 18:02:12 +02:00
Bartłomiej Dach
67c044773b Merge branch 'master' into fix-menu-state-display 2023-05-20 17:57:00 +02:00
Bartłomiej Dach
afdddb0195 Merge pull request #23582 from peppy/placement-blueprint-timeline-combo-fixes 
Fix timeline blueprint display not showing correct combo number / colour during placement
 2023-05-20 15:02:55 +02:00
Bartłomiej Dach
0e11adaaac Merge pull request #23564 from peppy/fix-missing-sample-additions 
Fix sample banks not transferring when adjusting via editor
 2023-05-20 14:36:45 +02:00
Bartłomiej Dach
ec442a94e2 Merge pull request #23595 from peppy/pin-to-6.x 
Pin builds to .NET 6
 2023-05-20 13:25:56 +02:00
Dean Herbert
e8cb19e40a Pin builds to .NET 6 
As more things move to having the 7 SDK installed, let's pin for now.

This helps with mobile build scenarios, which fall over on the new SDKs
and require further attention.
 2023-05-19 17:49:27 +09:00
Dean Herbert
ee522253cb Remove a couple of unnecessary volume declarations 2023-05-18 14:12:57 +09:00
Bartłomiej Dach
9ca1c7f7b7 Merge pull request #23580 from peppy/fix-profile-button-depth 
Ensure scroll-to-top button is displayed above all overlay content
 2023-05-17 21:23:46 +02:00
Bartłomiej Dach
fb441b864e Merge pull request #23576 from peppy/fix-random-button-right-click 
Fix random button hover state sticking when rewinding using right mouse button
 2023-05-17 21:02:39 +02:00
Dean Herbert
b58ab28765 Make EditorClock non-nullable in PlacementBlueprint 2023-05-17 21:40:52 +09:00
Dean Herbert
214d7e07fa Add TODO regarding failing stack display code 2023-05-17 17:52:17 +09:00
Dean Herbert
0b25818bd2 Update combo information on placement blueprint 2023-05-17 17:26:19 +09:00
Dean Herbert
9563d4f730 Fix weird purple tint on placement object in timeline 2023-05-17 17:26:19 +09:00
Dean Herbert
8d925c8a8a Move combo information updating to an interface level helper method 2023-05-17 17:26:19 +09:00
Dean Herbert
e43f2c2c43 Improve previous hitobject lookup efficient and correctness 2023-05-17 17:19:29 +09:00
Dean Herbert
7d7d402d4e Apply NRT to PlacementBlueprint 2023-05-17 17:19:29 +09:00
Dean Herbert
79e1d978e7 Ensure scroll-to-top button is displayed above all overlay content 2023-05-17 15:42:38 +09:00
Dean Herbert
764f0323f4 Show "rewind" text on random button when beginning a right mouse press 2023-05-17 14:51:40 +09:00
Dean Herbert
94b184712d Fix random button hover state not correctly being reset on right click 2023-05-17 14:51:40 +09:00
Dean Herbert
dc421bd2af Revert "Merge pull request #23570 from huoyaoyuan/inspect-code-cs11" 
This reverts commit ab2bd123e7, reversing
changes made to 267e63320f.
 2023-05-17 14:49:47 +09:00
Dean Herbert
510ebe1f23 Fix weird optional usage in HitSampleInfo.With 2023-05-17 14:11:52 +09:00
Dean Herbert
dc51d5ecf3 Rename GetSampleInfo to better describe what method does 
Also add full xmldoc
 2023-05-17 14:07:48 +09:00
Dean Herbert
a8bc337006 Change default volume when constructing a HitSampleInfo to non-zero 2023-05-17 14:06:02 +09:00
Dean Herbert
0d3c64dc32 Merge pull request #23572 from bdach/avoid-display-settings-feedback 
Work around issues with bindable/event feedback in layout settings
 2023-05-17 12:03:45 +09:00
Dean Herbert
ab2bd123e7 Merge pull request #23570 from huoyaoyuan/inspect-code-cs11 
Update InspectCode to 2022.3.3 and enable C# 11
 2023-05-17 11:37:57 +09:00
Bartłomiej Dach
c97b7a077e Use better issue reference 2023-05-16 23:47:47 +02:00
Bartłomiej Dach
70426a5042 Add reference to youtrack issue to suppression 2023-05-16 22:42:25 +02:00
Bartłomiej Dach
0dcf1b540e Attempt to preserve old resolution when switching displays 2023-05-16 21:14:09 +02:00
Bartłomiej Dach
88ce627c8e Avoid bindable/event feedback when changing resolution 2023-05-16 21:02:23 +02:00
Huo Yaoyuan
84de463e2e Turn off inspection of MSBuild unknown property 2023-05-17 00:13:08 +08:00
Huo Yaoyuan
ddfdd712bd Update InspectCode to 2022.3.3 and enable C# 11 2023-05-17 00:07:06 +08:00
Dean Herbert
ebce39cd1c Add test coverage of failing sample bank transfer 2023-05-16 18:52:52 +09:00
Dean Herbert
8528fcaedc Rename editor sample adjustment test scene to increase scope of tests 2023-05-16 18:52:52 +09:00
Dean Herbert
31fff72eb6 Fix bank not correctly being assigned to some taiko hit cases 2023-05-16 18:52:52 +09:00
Dean Herbert
d9ae822966 Fix bank not correctly being assigned when adding sample additions in editor 2023-05-16 18:52:52 +09:00
Dean Herbert
83dcd78826 Make HitSampleInfo.Bank non-nullable 2023-05-16 18:12:56 +09:00
Bartłomiej Dach
267e63320f Merge pull request #23558 from peppy/add-abbreviations-framework 
Add abbreviations found in framework functions
 2023-05-15 19:41:13 +02:00
Dean Herbert
26ed50d8fd Add abbreviations found in framework functions 
Brings total inspections down to zero when using local framework
checkout (in conjuncation with https://github.com/ppy/osu-framework/pull/5793).
 2023-05-15 21:42:49 +09:00
Bartłomiej Dach
8e497bd99b Merge pull request #23492 from alixdotsh/master 
Fix angle sharpness slider value not always scaling by 0.5
 2023-05-14 20:35:41 +02:00
Bartłomiej Dach
a6ddb107cd Merge branch 'master' into master 2023-05-14 19:45:31 +02:00
alix
d503312788 updates and add changes 2023-05-14 13:37:44 -04:00
Bartłomiej Dach
592fcafcd4 Merge pull request #23451 from timiimit/fix-default-progress-graph-flipping 
Fix default progress graph not updating after flip
 2023-05-14 19:19:10 +02:00
Bartłomiej Dach
265096bed7 Merge pull request #23509 from peppy/editor-slider-placement-tool-change 
Force placement of in-progress object when changing tools in the editor
 2023-05-14 18:48:43 +02:00
Bartłomiej Dach
a99bf0fc5a Add test coverage 2023-05-14 12:29:24 +02:00
Bartłomiej Dach
cc2dfc8371 Merge branch 'master' into editor-slider-placement-tool-change 2023-05-14 12:26:37 +02:00
Bartłomiej Dach
144eba9bc8 Merge pull request #23508 from peppy/editor-slider-placement-input 
Allow commiting / undoing placement of blueprints using back / select bindings
 2023-05-14 12:20:54 +02:00