846291d203
Refactor new tests to not suck as much as the old importer tests
2022-07-26 16:33:00 +09:00
9939866f7d
Revert one more missed change
2022-07-26 15:54:10 +09:00
8370ca9765
Add ImportAsUpdate method to IModelImporter to avoid otehr changes
2022-07-26 15:49:04 +09:00
7d8a78ef01
Move tests to own class
2022-07-26 14:53:20 +09:00
d41ac36a69
Fix scenario where import is expected to be empty
2022-07-25 23:59:27 +09:00
9c411c2250
Fix test nullability assertions
2022-07-25 20:06:37 +09:00
8a0c8f5fd8
Fix some realm pieces not being cleaned up
2022-07-25 19:51:19 +09:00
92dd1bcddb
Add test coverage of actual update flow
2022-07-25 19:51:19 +09:00
2e14d8730c
Move implementation of updating a beatmap to BeatmapImporter
2022-07-25 19:51:19 +09:00
2363a3fb7b
Persist DateAdded over beatmap updates
2022-07-25 19:51:19 +09:00
e5ad07454c
Ensure previous version prior to update loses online info after marked pending delete
2022-07-25 19:51:19 +09:00
912218e123
Ensure scores are transferred after beatmap update if difficulty hash didn't change
2022-07-25 19:51:19 +09:00
b7f6413bce
Fix old version of beatmap potentially not being deleted during update flow
...
This can happen if the online IDs are not present in the `.osu` files.
Previously this was only working due to the early logic in the import
process (that relies on matching all online IDs perfectly).
2022-07-25 19:51:19 +09:00
6a3e8e31de
Centralise calls to reset online info of a BeatmapInfo
2022-07-25 19:51:19 +09:00
ec477a3ebf
Add basic coverage of current behaviour of beatmap reimport
2022-07-25 19:51:19 +09:00
068063a43a
Merge pull request #19371 from peppy/fix-working-cache-invalidation
...
Fix calls to `GetWorkingBeatmap` invalidating cache too often
2022-07-25 18:29:46 +09:00
1d48cee230
Merge pull request #19373 from peppy/fix-negative-star-rating-display
...
Fix star ratings which are still being calculated showing as "-1" at song select
2022-07-25 18:20:30 +09:00
6937296192
Merge pull request #19374 from peppy/fps-counter-no-scheduler
...
Refactor `FPSCounter` to not use scheduled tasks
2022-07-25 18:19:59 +09:00
35462a04a0
Merge pull request #19367 from smoogipoo/log-diffcalc-failure
...
Log beatmap difficulty retrieval failures during score calculation
2022-07-25 11:49:55 +03:00
678acabf7e
Merge branch 'master' into log-diffcalc-failure
2022-07-25 11:16:31 +03:00
3c12b357e6
Merge pull request #19372 from frenzibyte/more-unprocessed-pp-handling
...
Update more places to support displaying unprocessed PP placeholder
2022-07-25 16:45:54 +09:00
2dd99ef1fd
Refactor FPSCounter to not use scheduled tasks
...
While on the surface this looks harmless (ignoring allocations),
`Scheduler` doesn't clear cancelled tasks until they reach their
execution time. This can cause an increase in time spent processing the
scheduler itself.
I don't think a per-frame updating component should use scheduled tasks
in this way in the first place, so I've just rewritten the logic to
avoid that overhead altogether.
2022-07-25 16:26:48 +09:00
4d90e6bbac
Flip method to read better
2022-07-25 10:03:06 +03:00
6bf2645b1a
Fix StarRatingDisplay not handling negative numbers as "pending"
2022-07-25 15:44:54 +09:00
6bdd1f43a2
Add visual test coverage
2022-07-25 09:40:20 +03:00
e402e919ab
Display placeholder for user profile scores
2022-07-25 09:40:20 +03:00
2ec90e37bb
Fix calls to GetWorkingBeatmap invalidating cache too often
...
With recent changes, the pathway between refetching (on request) and
refetching (on requirement due to unpopulated files) was combined.
Unfortunately this pathway also added a forced invalidation, which
should not have been applied to the second case.
Closes https://github.com/ppy/osu/issues/19365 .
2022-07-25 15:30:49 +09:00
bbbc0a863f
Add test coverage of WorkingBeatmap retrieval from BeatmapManager
2022-07-25 15:30:49 +09:00
f54cee0270
Display placeholder for leaderboard top scores
2022-07-25 09:18:04 +03:00
91d1c9686c
Separate unprocessed PP placeholder to own class
2022-07-25 09:07:51 +03:00
fa1bc0fe0e
Merge pull request #19343 from frenzibyte/beatmap-overlay-null-pp
...
Display exclamation icon for online scores with unprocessed PP
2022-07-25 14:45:15 +09:00
7facd6d822
Merge branch 'master' into beatmap-overlay-null-pp
2022-07-25 07:38:59 +03:00
6c95c49da3
Mark test score with null PP for visual testing
2022-07-25 07:31:52 +03:00
54eb2b98a9
Display exclamation triangle on scores with unprocessed PP
2022-07-25 07:30:57 +03:00
40b76d7560
Merge pull request #19368 from smoogipoo/disable-timeline-test
...
Disable timeline test for now
2022-07-25 13:21:10 +09:00
0226b358ee
Disable timeline test for now
2022-07-25 13:20:33 +09:00
3beb1da3de
Merge branch 'master' into beatmap-overlay-null-pp
2022-07-25 07:18:03 +03:00
12e2e63a1c
Merge pull request #19349 from bdach/mod-overlay/presets-column
...
Implement basic appearance of mod preset column
2022-07-25 13:10:47 +09:00
3d97b74813
Log beatmap difficulty retrieval failures during score calculation
2022-07-25 13:03:47 +09:00
af8349e673
Merge pull request #19363 from frenzibyte/late-end-playing-signal
...
Fix `Player` potentially disappearing in spectator list after restart
2022-07-25 12:05:36 +09:00
fa9daa6899
Fix TestSceneReplayRecorder not using score provided by gameplay state
2022-07-25 05:21:27 +03:00
e0266b0d81
Reword comment slightly
2022-07-25 04:39:14 +03:00
f5a5887669
Fix players potentially not displaying in spectator after restart
2022-07-25 04:21:53 +03:00
feef16b09b
Add potentially failing test case
2022-07-25 04:18:30 +03:00
446485f804
Move localisation string to common location
2022-07-24 23:30:52 +02:00
8af9cfbe40
Add readonly modifier
2022-07-24 23:29:18 +02:00
6a67d76d7c
Add basic mod preset column implementation
2022-07-24 16:39:04 +02:00
b2f8934117
Extract base mod select column presentation logic
2022-07-24 16:39:03 +02:00
08024e70eb
Merge pull request #19345 from frenzibyte/fix-slider-bar-crash
...
Fix `OsuSliderBar` throwing on negative draw width
2022-07-24 19:36:19 +09:00
4332e6cae9
Fix OsuSliderBar throwing on negative draw width
2022-07-24 08:34:24 +03:00
