Commit Graph

59221 Commits

Author SHA1 Message Date
87d0bef313 Use nullable comparison helper method instead of manual implementation 2023-03-06 15:16:32 +09:00
a14dede036 Ensure TestBeatmapCarousel.Items only returns actually visible items (and in correct order)
Turns out that items could be in an order that isn't the same as how
things look on the carousel, so this change ensures that for testing
purposes they are sorted by Y position.

Also uses the `CarouselItem.Visible` flag to ensure that we don't have
to wait for drawable fade transitions after a filter operation.
2023-03-03 17:18:34 +09:00
7a092ea995 Add better coverage and more comments explaining the structure of test setup 2023-03-03 17:18:14 +09:00
82293c0c86 Don't filter away results with missing data when using "Date Submitted" or "Date Ranked" sort modes
From a user's perspective, changing a sort / order mode shouldn't filter
away results, but we were doing this.

In terms of UX expectations, in stable this kind of scenario would
results in a group being added to the end of son select with "Not
ranked" or "Unknown". I think we should aim to match this eventually.
2023-03-03 16:36:18 +09:00
29be26b150 Merge pull request #22766 from Joehuu/fix-talking-with-text-overflow
Fix "talking with" text overflowing when usernames are too long
2023-03-02 17:04:11 +09:00
af540de69b Fix "talking with" text overflowing when usernames are too long 2023-03-01 22:10:15 -08:00
bd11d5d29a Merge pull request #22743 from Joehuu/scroll-back-to-previous
Add ability to scroll back to previous position after scrolling to top via button on overlays
2023-03-01 22:55:47 +09:00
21ebcdf5ed Merge pull request #22755 from EVAST9919/colour-info-framework
Use `ColourInfo.Interpolate(Quad)` where possible
2023-03-01 12:05:54 +09:00
24723ca873 Merge pull request #22749 from peppy/rename-setting-source-tests
Rename `SettingSource` tests to match attribute name
2023-02-28 20:40:07 +01:00
31f58a33ac Use ColourInfo.Interpolate where possible 2023-02-28 18:47:27 +03:00
3c45ab677a Merge pull request #22751 from peppy/update-framework
Update framework
2023-02-28 16:40:18 +09:00
89e20a7962 Update resources 2023-02-28 14:47:51 +09:00
bd1460a8d5 Update framework 2023-02-28 14:32:58 +09:00
2615453b31 Rename SettingSource tests to match attribute name 2023-02-28 11:45:32 +09:00
ca47d55f10 Merge pull request #22748 from OpenSauce04/patch-1
Fix grammar mistake in taiko relax mod description
2023-02-27 20:17:14 +01:00
4e9d25957a Merge pull request #22717 from peppy/skin-editor-depth-changing
Add ability to send selected skin components to front or back
2023-02-27 19:56:21 +01:00
92edb0f868 Merge branch 'master' into skin-editor-depth-changing 2023-02-27 19:24:53 +01:00
8d747f2402 Fixed grammar mistake in Taiko Relax mod description 2023-02-27 16:06:33 +00:00
fa710ae1b0 Rename ScrollToTopButton to ScrollBackButton 2023-02-26 14:39:34 -08:00
dc00905f8d Add ability to scroll back to previous position after scrolling to top via button on overlays 2023-02-26 14:38:51 -08:00
d98d330da2 Add expected behavior test for scroll back to previous position 2023-02-26 14:30:46 -08:00
dc3c1150b8 Set better defaults for SkinBlueprint transforms 2023-02-23 21:10:15 +09:00
c48aceb055 Fix undo history not being batched correctly for depth change operations 2023-02-23 20:03:36 +09:00
d679703fa2 Merge pull request #22659 from peppy/fix-taiko-drum-nested-sample-detection
Fix `GameplaySampleTriggerSource` not considering nested objects when determining the best sample to play
2023-02-22 18:56:59 +01:00
a8c692a215 Merge pull request #22635 from peppy/use-overlays-container-more
Use `Overlays` container rather than `KeyBindingInputManager` for flashlight
2023-02-22 18:30:21 +09:00
32a9c066df Add test coverage of bring-to-front / send-to-back operations 2023-02-22 18:17:20 +09:00
90ca635a17 Fix weird nullability in TestSceneSkinEditor 2023-02-22 18:17:20 +09:00
16c8a392a1 Add ability to send selected skin components to front or back 2023-02-22 18:17:20 +09:00
f61fbcf3fc Update assertion to also check GameplayClockContainer's current time 2023-02-22 15:26:09 +09:00
a511e64fa5 Seek using GameplayClockContainer 2023-02-22 14:41:20 +09:00
4f9f4b3970 Merge pull request #22674 from peppy/skin-editor-layer-select
Add the ability to select a target layer in the skin editor
2023-02-22 12:51:15 +09:00
051eb18b33 Merge branch 'master' into skin-editor-layer-select 2023-02-21 21:38:51 +01:00
ab97b02235 Remove contradictory remark from xmldoc 2023-02-21 21:05:46 +01:00
d59d153654 Fix test compile failures from Audio hoisting 2023-02-21 21:03:00 +01:00
3d2fcb0cca Merge branch 'master' into fix-taiko-drum-nested-sample-detection 2023-02-21 20:53:06 +01:00
eb0c3ca174 Merge pull request #22650 from peppy/skin-editor-clipboard
Add skin editor clipboard support
2023-02-21 20:10:32 +01:00
ec1bf7b0b2 Merge branch 'master' into skin-editor-clipboard 2023-02-21 19:35:58 +01:00
9384687d6d Switch ModMuted to add its metronome to components rather than overlays 2023-02-21 19:04:06 +09:00
1acc536248 Move DrawableRuleset.Audio to a less generic level 2023-02-21 19:03:52 +09:00
af062e7a68 Change placeComponent to only add to selection, not clear an existing selection 2023-02-21 14:11:18 +09:00
9321ec29dc Update slider sample source asserts to match expected behaviour
As pointed out in review, if the current time is after the end of the
slider, the correct hit object to use for sample retrieval is the object
itself, not any nested object.
2023-02-21 14:04:38 +09:00
e686b4393e Add wait steps to ensure frame-stable clock has caught up before checking state 2023-02-21 14:04:19 +09:00
5ba6059911 Merge branch 'master' into fix-taiko-drum-nested-sample-detection 2023-02-21 13:58:15 +09:00
ee87a29376 Merge pull request #22543 from Cwazywierdo/hitcircle-late-miss-fade
Fix hit circle late-miss fading differences compared to stable
2023-02-21 13:56:57 +09:00
0d229d959b Remove unnecessary TriggerChange call 2023-02-21 13:50:19 +09:00
6799492596 Merge branch 'master' into skin-editor-layer-select 2023-02-20 21:33:48 +01:00
8818341047 Merge pull request #22673 from peppy/skin-per-ruleset-layouts
Add support for per-ruleset skin layouts
2023-02-20 21:33:28 +01:00
86a7f4dfd0 Do not serialise SkinLayoutInfo.AllDrawables
- It is entirely derived from `SkinLayoutInfo.DrawableInfo`, which is
  the actual primary thing we want to serialise.
- It will never get read out from any serialised files anyway (corollary
  of the previous point - it is a get-only property derived from another).
- It is only used in tests.

All of the three reasons above make serialising the property out to skin
files nothing more than a waste of space.
2023-02-20 20:37:48 +01:00
c9999bdeb1 Merge branch 'master' into skin-per-ruleset-layouts 2023-02-20 20:14:38 +01:00
43724472c4 Clarify comment to avoid playing pronoun game 2023-02-20 20:09:24 +01:00