8c94b77de1
refactor(InputTrigger): move out of KCD
...
I love JetBrains Rider.
2023-02-22 15:05:07 +00:00
1beec71037
refactor(KeyCounterDisplay): apply suggestions
...
I also took the freedom to add type checking, as we can't limit the
usage of `Add()` since it's a Container. The exception thrown also
advises of using the suggested `AddTrigger()` instead.
2023-02-22 14:58:27 +00:00
42a5a06b9d
style(KeyCounter): fields and methods visiblity
2023-02-21 19:10:37 +00:00
5bec2d7c52
style(KeyCounter): forwardPlayback
2023-02-21 19:02:56 +00:00
8830e06588
fix: compilation
2023-02-17 09:17:11 +00:00
c94e647e21
style(KeyCounterDisplay): remove type check
2023-02-17 09:09:56 +00:00
d0e8d65766
style(KeyCounter): rename IsLit to IsActive
2023-02-17 00:56:17 +00:00
6193aeed12
fix(TestSceneOsuTouchInput): missing Value call
2023-02-17 00:13:45 +00:00
e3ca751027
refactor: make FillFlowContainer read-only
2023-02-16 23:17:47 +00:00
c61fac578c
style(KeyCounter): rename methods and arguments
...
As for the second suggestion in
https://github.com/ppy/osu/pull/22654#discussion_r1109047998 ,
I went with the first one as only one Trigger actually uses this
argument for rewinding.
2023-02-16 23:15:03 +00:00
ddd6c1a1c6
refactor(KeyCounter): address bindables issues
...
`IsCounting` is back being an auto-property.
`countPresses` is now encapsulated and being exposed as an
`IBindable<int>` via `CountPresses`
2023-02-16 22:20:34 +00:00
6340730427
refactor(KeyCounter): remove circularity
2023-02-16 21:59:39 +00:00
e9dcc257b4
reafactor: simplify type checking
2023-02-15 22:06:35 +00:00
b0a2e69f95
style: nullable pass on KeyCounterDisplay
2023-02-15 22:06:10 +00:00
076eb81b21
refactor: rename trigger classes
...
Makes it better to understand their purpose
2023-02-15 21:46:13 +00:00
a644fae364
style(KeyCounter): rename (Un)lit methods to (Un)light
2023-02-15 21:41:41 +00:00
df0633858c
fix(KeyCounter): don't override Handle
...
This caused the Keyboard inputs to register twice, which is not what we
want.
2023-02-15 21:41:41 +00:00
157bba7830
refactor: rename Trigger class to InputTrigger
2023-02-15 21:41:36 +00:00
aa2e0028ab
refactor: hide trigger presence from content
2023-02-13 10:59:10 +00:00
11d0e185b8
refactor: separate impl of KeyCounterDisplay
...
This allows for different layouts of display. Idk, maybe someone would
want to mix both variants? (don't do this please). This commit is mostly
prep for further changes.
2023-02-13 01:36:12 +00:00
74a58fb674
refactor: separate things in KeyCounter
...
To implement different different sources of input for KeyCounter, it
is now possible to create a Trigger class (to inherit) instead of
inheriting KeyCounter. This eases the creation of more input sources
(like for tests) while allowing to implement different UI variants.
That way, if another variant of the key counter needs to implemented
(for whathever reason), this can be done by only inheriting KeyCounter
and changing how things are arranged visually.
2023-02-13 01:24:27 +00:00
8fb72b971d
Merge pull request #22597 from peppy/editor-select-timing-on-enter
...
Automatically select the closest timing point on entering the timing screen
2023-02-11 17:08:08 +01:00
774eae98cc
Merge branch 'master' into editor-select-timing-on-enter
2023-02-11 16:27:22 +01:00
a3cc0d23b3
Fix typo in xmldoc
2023-02-11 16:26:32 +01:00
7b2c5ab7eb
Merge pull request #22608 from peppy/update-dependencies
...
Update realm and other dependencies
2023-02-11 12:37:02 +01:00
ebf469272f
Merge pull request #22544 from peppy/fix-change-join-leave-loop
...
Attempt to fix channel join / leave loop
2023-02-11 12:26:26 +01:00
20f3ab167e
Re-centralise BannedApiAnalysers nuget package
2023-02-11 19:36:40 +09:00
8292052dc2
Merge pull request #22598 from peppy/fix-skip-intro-replay
...
Fix "skip" key binding no longer working in replay playback
2023-02-11 11:27:10 +01:00
0c5dae5f26
Merge pull request #22529 from ItsShamed/dsc/presence
...
Add support for `Watching` and `Spectating` activities in `ReplayPlayer` and `SoloSpectatingPlayer`
2023-02-11 17:29:47 +09:00
86c8675910
Update realm and other dependencies
2023-02-11 13:52:24 +09:00
463e8221e0
Merge pull request #22600 from Terochi/song-progress-time-left-fix
...
Song progress incorrectly displaying `timeLeft` counter after rotation
2023-02-11 13:19:06 +09:00
2ecc3e773b
Merge pull request #22607 from Joehuu/fix-skin-component-one-frame-sizing
...
Fix skin component previews on toolbox buttons having incorrect size for one frame
2023-02-11 12:49:37 +09:00
bfd83768c1
Fix skin component previews on toolbox buttons having incorrect size for one frame
2023-02-10 17:58:34 -08:00
65bb3a5cad
Merge pull request #22588 from Joehuu/fix-clickable-avatar-bloat
...
Remove code bloat from `ClickableAvatar`
2023-02-10 22:07:49 +01:00
75e19bb89f
Merge branch 'master' into fix-clickable-avatar-bloat
2023-02-10 21:30:40 +01:00
11296c4ffe
Use better exception type
2023-02-10 21:25:19 +01:00
81c3e0da31
Fixed timeLeft counter in SongProgressInfo being out of bounds after rotation
2023-02-10 17:58:48 +01:00
5c795f492f
Reorder game key bindings to allow skip overlay to have precedence over replay controls
2023-02-10 18:57:21 +09:00
96fbd04698
Add failing test coverage of skip no longer working in replay playback
2023-02-10 18:57:04 +09:00
4f7d26b776
Actually apply new parameter
2023-02-10 18:29:39 +09:00
6d876fdb9a
Automatically select the closest timing point on entering the timing screen
2023-02-10 17:48:56 +09:00
03e623d1d2
Move ControlPointList to own file
2023-02-10 17:37:31 +09:00
ad8b01b478
Merge pull request #22589 from sw1tchbl4d3r/file_hitsample_additions
...
Always add to additions soundbank in `convertSoundType`
2023-02-10 17:14:29 +09:00
eccde923e5
Merge pull request #22554 from Walavouchey/ranking-accuracycircle-readability
...
Improve readability of `AccuracyCircle`
2023-02-10 17:03:46 +09:00
1df6fc6311
Use if statements rather than conditional case
2023-02-10 17:03:27 +09:00
f70614aa8b
Merge pull request #22587 from sw1tchbl4d3r/taiko_large_bonus
...
Make `LargeBonus` a valid `HitResult` in taiko
2023-02-10 17:00:53 +09:00
199fb0fd85
Apply NRT to ClickableAvatar and UpdateableAvatar
2023-02-10 16:32:58 +09:00
5866b67a5b
Simplify tooltip implementation
2023-02-10 16:24:44 +09:00
68c37585e5
Use string.Empty instead of default
2023-02-10 16:22:06 +09:00
a86f06df96
Add back Enabled checks to TooltipText and OnClick to fix guest case
2023-02-09 17:00:32 -08:00
