Commit Graph

53908 Commits

Author SHA1 Message Date
8ca8484f0e Fix failing tests 2022-07-30 11:49:33 +03:00
369ab10212 Fix exit confirmation dialog not blocking all exit cases 2022-07-30 11:00:31 +03:00
0a2265b0e8 Add test coverage of playlist exit confirmation 2022-07-29 17:11:37 +09:00
9d457535c6 Add confirmation dialog when about to discard a playlist
The confirmation will only show if items have been added to the
playlist.

Closes https://github.com/ppy/osu/issues/19444.
2022-07-29 17:11:37 +09:00
eb92c35335 Merge pull request #19442 from smoogipoo/fix-beginplaying-misordering
Move spectator begin/end playing to SubmittingPlayer
2022-07-29 16:09:50 +09:00
be7a9e1487 Merge pull request #19453 from smoogipoo/multiplayer-test-misordering
Fix potential test failures due to Setup/SetUpSteps ordering
2022-07-29 15:59:51 +09:00
aaa6f963bd Fix potential test failures due to Setup/SetUpSteps ordering 2022-07-29 15:27:39 +09:00
bc685918b6 Merge pull request #19451 from peppy/dont-wait-spectator-frames
Revert blocking call when sending spectator frames
2022-07-29 14:17:57 +09:00
fd09155990 Revert blocking call when sending spectator frames
There are a lot of these requests, and we don't really care about
waiting on them to finish sending. This may have negatively affected
send performance for users with very high latency.

Reverts part of 0533249d11.

Addresses concerns in https://github.com/ppy/osu/discussions/19429#discussioncomment-3276400.
2022-07-29 12:24:54 +09:00
45879f7836 Merge pull request #19443 from smoogipoo/fix-intermittent-hud-tests
Fix intermittent HUD tests
2022-07-28 23:20:46 +09:00
0d6b45e515 Merge pull request #19431 from peppy/collections-track-beatmap-updates
Add collection transfer logic to beatmap import-as-update flow
2022-07-28 22:52:54 +09:00
a59d7f6710 Merge branch 'master' into collections-track-beatmap-updates 2022-07-28 22:05:34 +09:00
aa03df905f Merge pull request #19441 from peppy/test-working-beatmap-unfuck
Reduce calls to `LoadTrack` by implicitly running on test/dummy classes
2022-07-28 22:05:25 +09:00
5003eb5629 Merge pull request #19430 from peppy/realm-collections
Move beatmap collections to realm
2022-07-28 22:05:10 +09:00
11e0022fad Merge branch 'master' into realm-collections 2022-07-28 21:00:08 +09:00
ce694123eb Move spectator begin/end playing to SubmittingPlayer 2022-07-28 20:44:04 +09:00
a21aee4e9c Reduce calls to LoadTrack by implicitly running on test/dummy classes 2022-07-28 18:11:40 +09:00
1039338d80 Fix intermittent HUD tests 2022-07-28 17:58:07 +09:00
628a30193f Remove incorrect TrackLoaded override from TestWorkingBeatmap 2022-07-28 17:49:17 +09:00
1da9830145 Merge pull request #19435 from peppy/remove-beatmap-manager-ruleset-store
Remove unused `RulesetStore` from `BeatmapManager` constructor
2022-07-28 17:46:12 +09:00
6d4023b933 Adjust comment 2022-07-28 16:56:11 +09:00
ebe64422d6 Merge pull request #19433 from peppy/beatmap-model-documentation
Add more comprehensive xmldoc for beatmap model classes
2022-07-28 16:40:29 +09:00
cd01c5d3ac Fix assertion 2022-07-28 16:34:31 +09:00
fe6b487d75 Merge pull request #19432 from peppy/fix-update-test-failures
Add realm refresh calls to fix intermittent test failures on new update tests
2022-07-28 16:19:46 +09:00
2b9d46d803 Remove unused RulesetStore from BeatmapManager constructor 2022-07-28 16:19:05 +09:00
c1aaf27c54 Link to correct model in xmldoc 2022-07-28 16:02:19 +09:00
525e4a2019 Fix crash in DrawableRoomPlaylistItem context menu creation due to incorrect enumeration casting 2022-07-28 15:51:18 +09:00
6bf293e130 Fix managed object reused between test runs 2022-07-28 15:45:33 +09:00
452d82f292 Add more comprehensive xmldoc for beatmap model classes 2022-07-28 15:41:28 +09:00
ce48984bda Merge pull request #19419 from andy840119/remove-nullable-disable-in-the-mods-for-taiko-ruleset
Remove nullable disable annotation in mods for taiko ruleset.
2022-07-28 09:32:35 +03:00
8ac886a247 Update test to account for sort order 2022-07-28 15:20:25 +09:00
67c44552cb Add realm Refresh calls to ensure tests are stable 2022-07-28 15:18:04 +09:00
485d140a21 Add realm refresh calls to fix intermittent test failures on new update tests 2022-07-28 15:15:41 +09:00
070f56c30c Add collection transfer logic to beatmap import-as-update flow 2022-07-28 15:03:23 +09:00
2209afd0e8 Mark Live methods as InstantHandleAttribute 2022-07-28 15:03:08 +09:00
2ae5a34c0e Add test coverage of beatmap updates transferring collection hashes 2022-07-28 15:02:58 +09:00
1f13d89205 Merge branch 'master' into remove-nullable-disable-in-the-mods-for-taiko-ruleset 2022-07-28 09:01:50 +03:00
61bdcab651 Merge pull request #19418 from andy840119/remove-nullable-disable-in-the-mods-for-mania-ruleset
Remove nullable disable annotation in mods for mania ruleset.
2022-07-28 08:57:12 +03:00
ca68574473 Make NotificationOverlay dependency optional in CollectionSettings 2022-07-28 14:35:27 +09:00
c74ffea236 Merge branch 'master' into remove-nullable-disable-in-the-mods-for-mania-ruleset 2022-07-28 08:21:23 +03:00
392cb352cc Force alphabetical ordering for now 2022-07-28 14:07:42 +09:00
da06467891 Add missing realm subscription cleanup 2022-07-28 13:57:21 +09:00
ad482b8afc Tidy up naming of collection dropdowns 2022-07-28 13:57:21 +09:00
226eefcc5c Add note about hash storage 2022-07-28 13:57:21 +09:00
1669208a54 Add migration of existing collections database 2022-07-28 13:57:21 +09:00
34a2d1a6e1 Fix ManageCollectionsDialog and remove weird placeholder logic 2022-07-28 13:57:21 +09:00
67c7f324ee Simplify CollectionFilterDropdown filter flow weirdness 2022-07-28 13:57:21 +09:00
4332b409be Merge pull request #19410 from novialriptide/add-notif-externalbutton
Add Toast notification to ExternalLinkButton's context menu
2022-07-28 13:43:14 +09:00
aa65b73f19 Merge branch 'master' into add-notif-externalbutton 2022-07-28 12:17:36 +09:00
8da499fb0f Add proper test coverage 2022-07-28 12:16:21 +09:00