Commit Graph

54110 Commits

Author SHA1 Message Date
8ff7770a71 Omit irrelevant data from SoloScoreInfo serialisation 2022-08-04 19:11:39 +09:00
55234e8069 Merge pull request #19558 from bdach/mod-overlay/create-preset
Add flow for creating new mod presets
2022-08-04 14:45:57 +09:00
cbe09b51c4 Merge pull request #19552 from andy840119/remove-nullable-disable-in-the-desktop-project
Remove nullable disable in the osu.Desktop
2022-08-04 13:07:06 +09:00
ca1b4689cb Automatically focus name textbox upon add preset popover open 2022-08-03 21:26:35 +02:00
159d3b032c Rename locals for legibility 2022-08-03 21:23:31 +02:00
82d3fbd51b Split AddPresetPopover to separate file 2022-08-03 21:22:55 +02:00
ac9321204c Merge branch 'master' into mod-overlay/create-preset 2022-08-03 21:21:52 +02:00
656c9eb504 Merge pull request #19570 from peppy/more-until-steps
Change all filter control button state test to until steps
2022-08-03 21:55:27 +03:00
571a93e1bc Merge branch 'master' into more-until-steps 2022-08-03 21:25:30 +03:00
8489963abc Merge pull request #19548 from peppy/more-beat-sync-dependence
Improve `IBeatSyncProvider` interface and reduce beatmap track dependence
2022-08-03 20:54:57 +03:00
b00c3a4d6d Move properties and mark as get-only 2022-08-03 20:31:51 +03:00
7c45c571a0 Merge branch 'master' into more-beat-sync-dependence 2022-08-03 20:22:42 +03:00
844430502b Replace parantheses with nullable-bool equality operation 2022-08-03 20:11:08 +03:00
8b02c955d8 Give this class a constructor to make sure that message data will always assigned. 2022-08-03 23:17:09 +08:00
1eb8168a8d Merge pull request #19522 from frenzibyte/improve-download-limit-message
Display readable error message when reaching download limit
2022-08-03 23:32:04 +09:00
7022d9e5f8 Fix test step names being too long 2022-08-03 21:13:49 +09:00
87cc2db624 Merge branch 'master' into improve-download-limit-message 2022-08-03 20:17:02 +09:00
d3954fc583 Use existing localised error message 2022-08-03 20:15:46 +09:00
a32149fda1 Convert interface methods to extension methods 2022-08-03 20:07:55 +09:00
24d84890e4 Change all filter control button state test to until steps
There's multiple schedules at play which could be adding multi-frame
delays. let's play it safe and try and fix flaky tests.

Example of `Schedule` which could cause an issue:
392cb352cc/osu.Game/Collections/CollectionDropdown.cs (L77-L78)

Example of test failure:
https://github.com/ppy/osu/runs/7648118894?check_suite_focus=true
2022-08-03 20:03:07 +09:00
b822a6de9e Merge pull request #19564 from peppy/fix-legacy-song-progress-mouse-blocking
Fix `LegacySongProgress` incorrectly blocking mouse input from gameplay
2022-08-03 18:51:59 +09:00
4063f92381 Merge branch 'master' into fix-legacy-song-progress-mouse-blocking 2022-08-03 12:12:58 +03:00
dbdfa90012 Merge pull request #19563 from peppy/realm-migration-safety
Change migration logic to ignore realm pipe files regardless of database filename
2022-08-03 12:11:50 +03:00
16ff8d5c38 Use different variable source 2022-08-03 17:47:32 +09:00
6ad6561e1c Fix LegacySongProgress incorrectly blocking mouse input from gameplay
Closes #19555.
2022-08-03 17:42:29 +09:00
f743dc623f Change migration logic to ignore realm pipe files regardless of database filename 2022-08-03 17:37:30 +09:00
add2971eb4 Implement preset creation flow with test coverage 2022-08-02 22:05:54 +02:00
7251389e43 Add localisations for add preset button 2022-08-02 22:05:34 +02:00
059a465fe8 Add border to popover for better visual contrast 2022-08-02 22:03:33 +02:00
1b3074d098 Implement popover for creating mod presets 2022-08-02 22:03:33 +02:00
085080576a Add button for creating new mod presets 2022-08-02 22:03:32 +02:00
8d175bc402 Remove the null check. 2022-08-02 23:14:08 +08:00
c8c2758d63 give the object a default value(null). 2022-08-02 23:02:14 +08:00
13b2441c51 give the field a default value. 2022-08-02 22:29:54 +08:00
11a4bb5833 Prevent return the null value. 2022-08-02 22:29:54 +08:00
78cc28d75f Remove nullable disable annotation and fix the api broken. 2022-08-02 22:29:54 +08:00
258ad7c6b9 Tidy up kiai time access 2022-08-02 18:18:40 +09:00
cc4cde2c79 Improve IBeatSyncProvider interface and reduce beatmap track dependence 2022-08-02 17:59:18 +09:00
227906e30e Merge pull request #19543 from peppy/dont-clear-chat-overlay
Avoid clearing chat overlay textbox when pressing "back" key binding
2022-08-02 14:34:17 +09:00
34ffc51c51 Avoid clearing chat overlay textbox when pressing "back" key binding
Generally this is expected behaviour for usages of focused text boxes
(ie. to clear search content), but not so much here.

Addresses https://github.com/ppy/osu/discussions/19403#discussioncomment-3230395.
2022-08-02 13:56:03 +09:00
fc0914bf77 Merge pull request #19536 from frenzibyte/playlists-settings-leak
Fix playlist settings reference leak due to unsafe binding
2022-08-02 13:30:55 +09:00
4295dc3cb9 Merge pull request #19535 from naipofo/overlay-filter-rank
Hide F rank from the beatmap overlay
2022-08-02 13:06:27 +09:00
9a468f85f7 Merge pull request #19534 from andy840119/fix-up-remaining-issue-in-the-mods
Update nullability specifications in osu!catch and osu!taiko mods
2022-08-02 12:09:44 +09:00
5501195ed7 Merge pull request #19538 from bdach/mod-overlay/sheared-button-broken-autosize
Fix broken sheared button autosizing logic
2022-08-02 11:51:14 +09:00
eb73f9e88c Remove un-need using. 2022-08-02 10:23:52 +08:00
298efa5391 Fix broken ShearedButton autosizing logic 2022-08-01 22:04:16 +02:00
923d9a4e5f Add failing assertions to demonstrate autosize failure 2022-08-01 22:04:14 +02:00
3356909026 Merge branch 'master' into overlay-filter-rank 2022-08-01 21:54:44 +02:00
7354f9e6ba Remove localisation for now 2022-08-01 22:05:52 +03:00
c0e5f11c90 Merge pull request #19532 from frenzibyte/fix-new-items-sort-stability
Fix newly imported beatmaps not using correct comparer for sorting
2022-08-02 02:20:51 +09:00