Commit Graph

38297 Commits

Author SHA1 Message Date
1448c9e381 Merge remote-tracking branch 'upstream/master' into combo-colors 2020-08-15 23:01:38 +02:00
7a33a6b08a Merge remote-tracking branch 'upstream/master' into duplicate-multi-room 2020-08-15 13:07:12 -07:00
0e8411f76c Rename fields and make readonly 2020-08-15 22:06:26 +02:00
9e4b9188e1 Cache LoungeSubScreen, separate method, rename option 2020-08-15 13:06:16 -07:00
c4a7fac760 Add required parameters and other various changes 2020-08-15 22:03:24 +02:00
5f35b3ebb9 Fix constant casing 2020-08-15 20:44:02 +02:00
390e872730 Fix acoording to review 2020-08-15 21:34:17 +03:00
a1079bac32 Move frequency values into consts 2020-08-15 21:19:47 +03:00
40445d0005 replicate osu-stable behaviour for spinningSample frequency 2020-08-15 21:07:44 +03:00
07c25d5a78 Move spinnerFrequencyModulate set to ApplySkin 2020-08-15 20:51:33 +03:00
61de3c7540 Replace accidental tab with spaces 2020-08-15 20:18:56 +03:00
896a87e629 Replace accidental tab with spaces 2020-08-15 20:14:36 +03:00
5c11270b98 Add SpinnerFrequencyModulate skin config option 2020-08-15 20:12:06 +03:00
bffdb73624 Merge pull request #9867 from bdach/fix-pause-menu-selection
Fix pause menu selection not resetting on visibility change
2020-08-15 22:33:03 +09:00
a426ff1d5b Refactor gameplay menu overlay to fix regression 2020-08-15 14:18:50 +02:00
c1a9bf507a Add failing test case 2020-08-15 13:06:53 +02:00
f2bc16f4bd Merge pull request #9853 from peppy/update-framework
Update framework
2020-08-14 22:21:59 +09:00
e39b2e7218 Update framework 2020-08-14 21:53:18 +09:00
a2119fd9e3 Merge pull request #9849 from peppy/fix-beatmap-cover-permaload
Fix beatmap covers not being unloaded in most overlays
2020-08-14 20:24:36 +09:00
e465afa280 Merge branch 'master' into beatmap-track-rework 2020-08-14 20:02:43 +09:00
f44e55c7f5 Merge pull request #9793 from peppy/fix-skinnable-sound-mute
Add more resilient logic for whether to avoid playing SkinnableSound on no volume
2020-08-14 19:33:34 +09:00
c3757a4660 Fix beatmap covers not being unloaded in most overlays
Eventually we'll probably want something smarter than this, but for the
time being this helps stop runaway memory usage.
2020-08-14 19:22:26 +09:00
b7ae70ff96 Merge branch 'master' into fix-skinnable-sound-mute 2020-08-14 19:01:32 +09:00
7cfc20efd0 Merge pull request #9848 from peppy/menu-background-memory-usage
Load menu backgrounds via LargeTextureStore to reduce memory usage
2020-08-14 18:47:06 +09:00
671141ec61 Load menu backgrounds via LargeTextureStore to reduce memory usage 2020-08-14 18:05:05 +09:00
445f5c330b Merge pull request #9839 from peppy/delay-beatmap-load
Delay beatmap load until after PlayerLoader transition has finished
2020-08-14 15:42:30 +09:00
626cd4042f Merge branch 'master' into delay-beatmap-load 2020-08-14 15:09:30 +09:00
52ad856ee5 Merge pull request #9841 from peppy/fix-spinner-appear-duration
Adjust legacy skin spinners fade in time to match osu-stable
2020-08-14 15:05:12 +09:00
2c6afce524 Merge pull request #9843 from smoogipoo/fix-playlist-mods 2020-08-14 11:11:13 +09:00
74a8a4bca8 Make testing code clearer to understand. 2020-08-13 21:53:17 +02:00
0500d82b5b Fix playlist items sharing mod instances 2020-08-13 19:48:41 +09:00
3cb22fad82 Fix mods sharing bindable instances 2020-08-13 19:48:31 +09:00
662281d727 Adjust legacy spinners to fade in later
Matches stable 1:1 for legacy skins. I've left lazer default as it is
because changing to use the shorter apperance looks bad. This will
probably change as we proceed with the redesign of the default skin.
2020-08-13 18:20:46 +09:00
84cb36b6a8 Defer subscriptions for updateOverlayActivationMode() to OnEntering() 2020-08-13 10:57:18 +02:00
9e7a28002d Merge branch 'master' into beatmap-track-rework 2020-08-13 17:56:50 +09:00
52374ac9c9 Merge pull request #9833 from bdach/fix-spun-out-mod-rate-dependency 2020-08-13 17:52:13 +09:00
ab56980f8c Merge branch 'master' into fix-spun-out-mod-rate-dependency 2020-08-13 17:24:11 +09:00
2067e1ce44 Merge pull request #9798 from EVAST9919/dashboard-news 2020-08-13 17:23:54 +09:00
4467a5599a Merge pull request #9840 from peppy/update-fastlane
Update fastlane and plugins
2020-08-13 14:40:34 +09:00
c71ee0877f Update fastlane and plugins 2020-08-13 14:07:07 +09:00
8ded5925ff Xmldoc colour strain 2020-08-13 13:47:35 +09:00
cf9bda6c19 Add coverage of early exit with null and non-null player 2020-08-13 13:05:13 +09:00
fd7bf70b7d Remove weird "after load" action
This was pretty pointless anyway and from its usages, doesn't look to
need to exist.
2020-08-13 13:03:18 +09:00
5b536aebe7 Add missing null checks and avoid cross-test pollution 2020-08-13 12:53:37 +09:00
99bea6b8e9 Add missing null check (player construction is potentially delayed now) 2020-08-13 12:52:35 +09:00
27cd9e119a Delay beatmap load until after transition has finished
Previously the beatmap would begin loading at the same time the
`PlayerLoader` class was. This can cause a horribly visible series of
stutters, especially when a storyboard is involved.

Obviously we should be aiming to reduce the stutters via changes to the
beatmap load process (such as incremental storyboard loading,
`DrawableHitObject` pooling, etc.) but this improves user experience
tenfold in the mean time.
2020-08-13 12:04:32 +09:00
5010d2044a Replace IsKat with HitType 2020-08-13 01:35:56 +09:00
d2a03f1146 Refactor TaikoDifficultyHitObject 2020-08-13 00:59:22 +09:00
1c771471d5 Merge pull request #9837 from peppy/update-framework
Update framework and resources
2020-08-13 00:41:58 +09:00
90189fc40c Merge branch 'master' into morth-taiko-changes 2020-08-13 00:31:10 +09:00